Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <69dda7be-d7c8-401f-89f3-7a5ca5550e2f@oracle.com>
Date:   Tue, 3 Oct 2023 10:32:07 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] fs: apply umask if POSIX ACL support is disabled
Content-Language: en-US
To:     Max Kellermann <max.kellermann@ionos.com>,
        Xiubo Li <xiubli@redhat.com>,
        Ilya Dryomov <idryomov@gmail.com>,
        Jeff Layton <jlayton@kernel.org>, Jan Kara <jack@suse.com>
Cc:     ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net
References: <20230919081900.1096840-1-max.kellermann@ionos.com>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20230919081900.1096840-1-max.kellermann@ionos.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzRITkVUWkZyYTIxWml6clFNT2RzRGZRaEtQS3pndmRWMGkzcmdReHliUzU1?=
 =?utf-8?B?aDY1YWJiZEhrOGlqWG9HYXY0UVZCMlV5TXQwUGxMSk9ZT2gzRi9BOTlJRXJk?=
 =?utf-8?B?bUtLNnR4bkxlODZUMXkzWTJZMEQzVDlpMFlXTjdaMGxSdVBIaEoxaCs3ZGwy?=
 =?utf-8?B?YWtMc09Pa3Rad2dQWjltWmdDZUdNVzNoaW9SWUxsU3lWdFBLTXhRRlk0SFIz?=
 =?utf-8?B?MXdKcWNhV2NmVlBjSS9WaUNVQmJKN3BSM1RQeWp5eDJ3MVdkekg3S3UwRmtu?=
 =?utf-8?B?SUFab2tncDlzSjNkaWQvMHFBWGlrRVNmbkM3NzJSMVdyWWxHQTREdkZnemRD?=
 =?utf-8?B?V1lzQUNZVnU3ZDlEUklrd0JTUlJUeitpMzhueU5YVlJRK3lQeDB0T2ViWDBh?=
 =?utf-8?B?NFpTRXpmL2NDMEFrSnJhMjNqd2JoMHVtcENTbVp0MWJPZkhSRGQxRzVwU3JF?=
 =?utf-8?B?RTNjeDFGMm1qbTVKOVFyZ2plME1mQmo5SDhaK1hZdTFMS0s4YiswYVk0b0xM?=
 =?utf-8?B?ZEkwTHFudzFIeHRTeHFZcStzcE13cFh5SzhNWUl6RStmb1BwRUFtbGlxb2hu?=
 =?utf-8?B?OVM3OFM4VG04SWJ5R2xZM21DclVKczBjUDNLODdybEIxejFTaVk3SmkvbUhr?=
 =?utf-8?B?NFBUdzVIMGF3QW1WMll2NnhCR1BON0p6c0dTQjhHVFIwaVFxcTZNUnQzV1VJ?=
 =?utf-8?B?WjV3dXMzVGYraWFuM3AxaUd2QmhmY3BvUGc3dnJkYlg5bFQyTkVWcnFqS2hM?=
 =?utf-8?B?K1BTdGI3bkpDWitMaTJGZldLTFJDZTdmU1ZrcHY2Y01URlhXeDJtWXNaU3Jx?=
 =?utf-8?B?ZEVyZVFoN3FJRkhmLzFzY0dFK0k1eTliajh6NHFEL1pVR3VWYUpzbHVBbjVq?=
 =?utf-8?B?TXV3T0s1UnovYmxxbFh4cUF3U0UraE43QmFIbUsvSlV6dWk0MnEwL3VNZ0wx?=
 =?utf-8?B?MncyS2VuSTNDa1pOUVZGb0lrN2huckFSaXlqRTZFUWwzaVY1aWJhNS9rM0dF?=
 =?utf-8?B?K3N3WVBrWDlDNGpndGtFY2lJajg0UGMzc0ZXS2xCTFpvV0trajJNUXgyTHIr?=
 =?utf-8?B?cnRZdHpNQy8xc2FWSkZYcjZJd21sbVIvM1ZnaHdZRW9IdndhMUpNTVJYNDRl?=
 =?utf-8?B?TGQ5T1Z1N2ZtM0NRYWc4VXFzUHVqc2JCc3U2LzNTS29WTklaUm54VzR6bWlX?=
 =?utf-8?B?YjFudmlKaTN3N1ZpMjJrVW1qTUpZeWo5UUEzUVVnN3BTZnlEZXpZakJJeU4w?=
 =?utf-8?B?YnFFdlBHNkFsaS9JUW1nblNhUXlXS2piUlhoazNEL29zMHhFQ0ZtWm1SUmZz?=
 =?utf-8?B?dXE2Smt5Z3ZPRU5XUWo1VkluWU9pVm01QVJTaGl0c3lyVStyVmRWYWEyVDNP?=
 =?utf-8?B?dEgybVc5VFB6RXZRZEZxL1lwSzl6ZHRJdHlodDZ3b0lSS2J0VE4yeVc2c2Zz?=
 =?utf-8?B?N0xMSlE5cUhMc20yTFdCOHE5aVhTODVZU3EwRWNDQjE1SWg0MFZRMkpxOUZG?=
 =?utf-8?B?ck1DbEVRRkx4bEVkNXBCVm1DbG5aM0ZkdjRmKytNdGV5MWhhRHpDK1BrM2tT?=
 =?utf-8?B?OXV5eFhIdkVMU0xqdGMwc2ttM1F3U2Y1YjRwOXpHMXBpVXZhK2Jvb3BxOEFx?=
 =?utf-8?B?Q2ZJdWVxSld2b0p5TGh6bHFPWGFWOXROT3A1TEptblNQUnlEZTM0LzNqelpj?=
 =?utf-8?B?eXkvcDRmb0hmZUhQc0JoVWhEQzRoTHNlbW5uZERUTlRoQStyK1FtR09QSHFv?=
 =?utf-8?B?Q1E3ZmJEdUdKN3MwL081VXpOZUpwU0NKaE9UKzlBbkdSY1RHZDZFdWROa0Fs?=
 =?utf-8?B?YmdBbTFVQXlSZGNCejdxN3h2UWQ2RHhYRUV0QlJpVFdRTVBEUkpSSFRmcjQ0?=
 =?utf-8?B?eXNpRmxESXBaLzZTSlJCNjdwTWliaEJuOGdHY0VZTk5nYy9qenpKWkI4QWtz?=
 =?utf-8?B?cUpWekVXenZWMTNtZUIzOE01ZndseVI5T1loVmJBaWFWbHgzTUpmeUptYVBk?=
 =?utf-8?B?WS92R0k3YmNCQjhQSVdQRkphQlYwZ0RyRFRIcXNJaGZNaWdCTWVJcGRoRGhm?=
 =?utf-8?B?VHBmMno0RUdRSUUxR2FLSW5NRWVLdVY1TENuVDhldmFPSm9iRzJVczdqYS9u?=
 =?utf-8?B?cnRWVVkzQ3JWYVUvaDlIUjFoa2NUMm1rWHkvTTZrZDBOYXZlaVNDM2RKR0hN?=
 =?utf-8?B?VXc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?YXpLNkZDYmozaUlZTW05ODAzZHV6c2g3UkFLakhMYnRVTlh4QndmNnkxQ05V?=
 =?utf-8?B?Y2NneVZjUUV0TGJQN0dDRVBtYVhIWTVWbE1pVVpVK3NTL1plUDEzMkN2UHdF?=
 =?utf-8?B?RU9sV3UxdU9SeUxUTFhtNU5Gdjd3SUZiQkM4clRYTUZuVDB0aGhLZVloUlJM?=
 =?utf-8?B?SVVVMkd0a2xmaUtpeFYwc2dRWURiVVdqdEVCN3czVlE0VVlERDBuL1I2RmRa?=
 =?utf-8?B?VE9DMlNvWWFZNVFTVUpscXppQ0FTNkY3cHRXYmVNLy9ZM0ZLKzJsMGpldTM0?=
 =?utf-8?B?d0M3NXBjNVd1UVUyc2QyWTZlTHZNZGlDOFJ1MXRjL1JsanJqWWM0emtEQUZa?=
 =?utf-8?B?aysyMm9Hb3hva1hLb0psdVFvMG5iRmxXSkxnNEJxVGorL1NZOHNuN29yTm13?=
 =?utf-8?B?VGdTVjZWVVpoKzNsQklDOVJFSlFCT3NsVzNQcjZlMG9ZK0tYWWY1blJqWmNL?=
 =?utf-8?B?OWFXWmI4MHJobC9icDRUMlNwOFVnZWhCSzhLVHUzWUUwY0ZVbnBzaklhcW9x?=
 =?utf-8?B?Z3hWREJaZTA1MVpGaFEwQlRqTmZ5enVMVXM5TEJUQlMrN2cxeE4zeUsyc25C?=
 =?utf-8?B?WmUyVVpNOVpmajgvNTdlZ3V2TWNBYVZwSm04UTdDY3V6Q21kcVZyUHJkT1ll?=
 =?utf-8?B?UEJORHRTdGJ5VkVJN2hhSDhudjFMZHZBSDFMeHNOQk15N1ZkYldhdnlEdXk2?=
 =?utf-8?B?UzdVWjhuMXBVUGFLSXRBdEZwOVJadG8raHo5T3o3SzQzYkc3N3ZGYURDN0pZ?=
 =?utf-8?B?YXhiVWRrWWFtbHNEaExsb0tJZzRsZWRkNzJET3k3VGpLbkY5T2k4V0t3WTVG?=
 =?utf-8?B?RUZMMEVCZmZQQkErWncxOUhzd0RTNitwT3c1c2V1WTYrWnhDRzJwU3dQZUtN?=
 =?utf-8?B?aEZ3SGV5WGliKzVJTVRPRzlVR3hvMXZUUGVsTU8wYWhFa1lTVDQ3TUptNDQ3?=
 =?utf-8?B?Nmo2N3ZaUXF4K3M1QTk0bi9aL01kVVNjaWhrbHBEUXJiUXNJSUVmcFp4Zk9k?=
 =?utf-8?B?SGZoQ09NUGswVkxia3g0TnlnRXBJakp4SmtFRzk1ZHBDNTlYL013T2czVy80?=
 =?utf-8?B?U0tiUnY3SWlvM2JBOXFKLzRQc3BDNFFseFMyUXcvUDlVNkxjR1pjRWpxQ21j?=
 =?utf-8?B?YXI3RzdhMWNWeUczKzltYkUxdk1TTVlCMUlKTXl3REtocFNTc2hYTTBzVzRO?=
 =?utf-8?B?S21Ba3hBY0tJWDkvZTRWbllSR2tlV1RQWmVQMTQxM3dLTUJRbXhFZ2M1NHh5?=
 =?utf-8?B?ZGtodVNnQlJ4OExiRWRmcWtFS0hPdTlvcjd0Y1o3WTZ2Mzg1dz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15d25adf-1463-47a3-1167-08dbc425e8ea
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 15:32:10.4890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YPAzYSCwFzURUO4pp5z2QY2S4NAc03Kxo8qQt5Ni3xxcuP1boNHqB7n3IfHwl6TgYmvsjM+OscCw66F5Cliy/xAX9R8jp/BkeByPT47n5o4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5691
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-03_12,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=701 mlxscore=0
 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310030116
X-Proofpoint-GUID: IVcy5QIRTvzRAKsNGbCHLqEbFuVZXQwb
X-Proofpoint-ORIG-GUID: IVcy5QIRTvzRAKsNGbCHLqEbFuVZXQwb
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 03 Oct 2023 08:32:42 -0700 (PDT)

I think this is sane, but the patch needs a description of why this is 
necessary for these specific file systems.

Thanks,
Shaggy

On 9/19/23 3:18AM, Max Kellermann wrote:
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
>   fs/ceph/super.h           | 1 +
>   fs/ext2/acl.h             | 1 +
>   fs/jfs/jfs_acl.h          | 1 +
>   include/linux/posix_acl.h | 1 +
>   4 files changed, 4 insertions(+)
> 
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 51c7f2b14f6f..e7e2f264acf4 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -1194,6 +1194,7 @@ static inline void ceph_forget_all_cached_acls(struct inode *inode)
>   static inline int ceph_pre_init_acls(struct inode *dir, umode_t *mode,
>   				     struct ceph_acl_sec_ctx *as_ctx)
>   {
> +	*mode &= ~current_umask();
>   	return 0;
>   }
>   static inline void ceph_init_inode_acls(struct inode *inode,
> diff --git a/fs/ext2/acl.h b/fs/ext2/acl.h
> index 4a8443a2b8ec..694af789c614 100644
> --- a/fs/ext2/acl.h
> +++ b/fs/ext2/acl.h
> @@ -67,6 +67,7 @@ extern int ext2_init_acl (struct inode *, struct inode *);
>   
>   static inline int ext2_init_acl (struct inode *inode, struct inode *dir)
>   {
> +	inode->i_mode &= ~current_umask();
>   	return 0;
>   }
>   #endif
> diff --git a/fs/jfs/jfs_acl.h b/fs/jfs/jfs_acl.h
> index f892e54d0fcd..10791e97a46f 100644
> --- a/fs/jfs/jfs_acl.h
> +++ b/fs/jfs/jfs_acl.h
> @@ -17,6 +17,7 @@ int jfs_init_acl(tid_t, struct inode *, struct inode *);
>   static inline int jfs_init_acl(tid_t tid, struct inode *inode,
>   			       struct inode *dir)
>   {
> +	inode->i_mode &= ~current_umask();
>   	return 0;
>   }
>   
> diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
> index 0e65b3d634d9..54bc9b1061ca 100644
> --- a/include/linux/posix_acl.h
> +++ b/include/linux/posix_acl.h
> @@ -128,6 +128,7 @@ static inline void cache_no_acl(struct inode *inode)
>   static inline int posix_acl_create(struct inode *inode, umode_t *mode,
>   		struct posix_acl **default_acl, struct posix_acl **acl)
>   {
> +	*mode &= ~current_umask();
>   	*default_acl = *acl = NULL;
>   	return 0;
>   }