Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp556303rdb; Fri, 6 Oct 2023 11:07:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGiMVYXR/SDGx0YehzDdL1Zu2JEEXZBSJJxfMMKK2GbMl93xXOBpwWGMIDov/8KrbtfOWHR X-Received: by 2002:a17:903:11c6:b0:1c5:76b6:d94f with SMTP id q6-20020a17090311c600b001c576b6d94fmr10479858plh.31.1696615636209; Fri, 06 Oct 2023 11:07:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696615636; cv=none; d=google.com; s=arc-20160816; b=qCxxqd2xtx+snptjj+tANCn6aNXzrT7oYErpdzGeBTBciaivmQ9SwhJlW7RwPwaqCV pBXOgWf1HV8m2EI0gC7QbJ8MZnkkPjQzV54IQIR2YXtx1XlMOwsGefv9ZuRzJRIj9UAo FiENkr0bL3r2QHIIlBMLJ0pOWjVIsi5K1fzaJbZRDcq/GycZVZvHD3YAiMnR0HKrWpcS Asb4xetPOpKPLCevyWAE4UShmnKKAP/f008tMTKQqaxsmopQKw38/f7G4Wd/UCyeBUuW mOV26KuWrC7ouBIXcyGKPJulzGrSADEvfc9dRocuasZiwh33btkSmZK3QPFtttCQZLBq hGwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bXYY3Wx31qEWsln/08L3bdR2MQEOn8sQrXOUxm8LR1Q=; fh=uV+LZkQWm8TiEmQFA9BOQW5WCgYup6Dsb+FljbAapuE=; b=agFG9rtnaoZ1PplGumVWZH6T+pNM5wdwRA2wyQdN3/HSGXsDJpiv7KSPHwL1w+Vic/ RO21PIj8hnWgRucMfYv+AJUjdnaEMbsF1D60q3VMXYrjiDgt6c5aBftYSggDSzysRfwL 7jdw88jOv5bffkxbGPs49OfpowRKLCHBfRZnUAIZ6JEFdWh8RXfn4sNrSpytjYQWeKXT Zex4pWP3kiANghLmQlq5Aco1Sir5h8FO+0bKhcBhzf5g2FOp/mwIme4CZY4js2a/nlew Mecl0yKfiTQzblYH6O0Sdo1XXtPVS+5wySOs+plZWvtL7p94C6ZuByhsa2v0nJZXUjSw 782Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=LPT+V+2l; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id j10-20020a170902da8a00b001bdf71d52b0si4415638plx.456.2023.10.06.11.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 11:07:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=LPT+V+2l; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 38BFC8265B4B; Fri, 6 Oct 2023 11:06:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233187AbjJFSGo (ORCPT + 99 others); Fri, 6 Oct 2023 14:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233182AbjJFSGn (ORCPT ); Fri, 6 Oct 2023 14:06:43 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0D37CE for ; Fri, 6 Oct 2023 11:06:40 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-111-143.bstnma.fios.verizon.net [173.48.111.143]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 396I6ZXe008086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Oct 2023 14:06:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1696615597; bh=bXYY3Wx31qEWsln/08L3bdR2MQEOn8sQrXOUxm8LR1Q=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type; b=LPT+V+2lrO8gUMDV3GDsV+sQLm6dFuRk3W6fUjjZpY7SR6n2DcvK8vy0D6Us9k+ep jGlJKbEZFm4F6jX/v4wupZrcYQKY2zL3xN0JOMxEOSVHIzSIkT3ywHQM3gfQmIClFB SBn7tjt+wEng34iFJ64WKHxQgT4NbAvCUr9ypltpuggIM3EMhadbWjJVRTtpnb0Pye idtGqGvQaeshtDH68iZkJlc63ttNSdnrb266BOamR0wa0R2KGuhCsNZuYrYWE4MA43 R5nLRN9WguLbOhoTVR55Cdvf863a/ER8B7wwgZLo7zIerNqA7QM4x2NaQ5xWCeWJ7J fUw3UTvBqBRSg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2309915C0260; Fri, 6 Oct 2023 14:06:33 -0400 (EDT) From: "Theodore Ts'o" To: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Lu Hongfei Cc: "Theodore Ts'o" , opensource.kernel@vivo.com Subject: Re: [PATCH] ext4: Fix traditional comparison using max/min method Date: Fri, 6 Oct 2023 14:06:21 -0400 Message-Id: <169661554695.173366.10172426933007973778.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230529070930.37949-1-luhongfei@vivo.com> References: <20230529070930.37949-1-luhongfei@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 06 Oct 2023 11:06:46 -0700 (PDT) On Mon, 29 May 2023 15:09:30 +0800, Lu Hongfei wrote: > It would be better to replace the traditional ternary conditional > operator with max()/min() > > Applied, thanks! [1/1] ext4: Fix traditional comparison using max/min method commit: a8c1eb77edfc92a64788dad70fedf9277cbafe76 Best regards, -- Theodore Ts'o