Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org,
        "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
        Dave Chinner <david@fromorbit.com>, stable@vger.kernel.org,
        Gao Xiang <xiang@kernel.org>
Subject: Re: [PATCH v3] ext4: Properly sync file size update after O_SYNC direct IO
Date:   Sun, 22 Oct 2023 20:55:29 -0400
Message-Id: <169802252287.2300216.15136208439429495793.b4-ty@mit.edu>
In-Reply-To: <20231013121350.26872-1-jack@suse.cz>
References: <20231013121350.26872-1-jack@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On Fri, 13 Oct 2023 14:13:50 +0200, Jan Kara wrote:
> Gao Xiang has reported that on ext4 O_SYNC direct IO does not properly
> sync file size update and thus if we crash at unfortunate moment, the
> file can have smaller size although O_SYNC IO has reported successful
> completion. The problem happens because update of on-disk inode size is
> handled in ext4_dio_write_iter() *after* iomap_dio_rw() (and thus
> dio_complete() in particular) has returned and generic_file_sync() gets
> called by dio_complete(). Fix the problem by handling on-disk inode size
> update directly in our ->end_io completion handler.
> 
> [...]

Applied, thanks!

[1/1] ext4: Properly sync file size update after O_SYNC direct IO
      commit: c388da1dad59dc24801b61bc63539cab6cd83e23

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>