Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <4CEE0B491E07CA77+c77a8b3d-095b-b33c-0091-dcb55fd40d28@uniontech.com>
Date:   Tue, 24 Oct 2023 10:35:13 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] ext4: delete redundant calculations in
 ext4_mb_get_buddy_page_lock()
To:     Jan Kara <jack@suse.cz>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        gouhaojake@163.com
References: <20231023013416.17246-1-gouhao@uniontech.com>
 <20231023114447.crn3bt4qdmkxkrxi@quack3>
Content-Language: en-US
Reply-To: 20231023114447.crn3bt4qdmkxkrxi@quack3
From:   Gou Hao <gouhao@uniontech.com>
In-Reply-To: <20231023114447.crn3bt4qdmkxkrxi@quack3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Feedback-ID: bizesmtp:uniontech.com:qybglogicsvrgz:qybglogicsvrgz7a-0
Precedence: bulk

On 10/23/23 19:44, Jan Kara wrote:

> On Mon 23-10-23 09:34:16, Gou Hao wrote:
>> 'blocks_per_page' is always 1 after 'if (blocks_per_page >= 2)',
>> 'pnum' and 'block' is equal in this case.
>>
>> Signed-off-by: Gou Hao <gouhao@uniontech.com>
>> Signed-off-by: Gou Hao <gouhaojake@163.com>
> No need for two signed-off-by here. Any one from you is enough :)
ok
>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>> index 454d5612641e..8442f5474b25 100644
>> --- a/fs/ext4/mballoc.c
>> +++ b/fs/ext4/mballoc.c
>> @@ -1456,9 +1456,7 @@ static int ext4_mb_get_buddy_page_lock(struct super_block *sb,
>>   		return 0;
>>   	}
>>   
>> -	block++;
>> -	pnum = block / blocks_per_page;
>> -	page = find_or_create_page(inode->i_mapping, pnum, gfp);
>> +	page = find_or_create_page(inode->i_mapping, ++block, gfp);
> 						     ^^^ perhaps just
> "block + 1" here? Maybe also add a comment before this call like:

Yes, 'block +1' is better here, i will add a comment.

Thanks for your review.

> 	/* blocks_per_page == 1, hence we need another page for the buddy */
>
> Otherwise the patch looks good!
>
> 								Honza
>
-- 
thanks,
Gou Hao <gouhao@uniontech.com>