Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp1121641rdb; Sat, 18 Nov 2023 04:10:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFGa3rSdGLZGcRv0tgWR+L5b/+L3FIlkcAcb1pWFiz4MbnI25tf/fD5iKdUwnt8WLOvh/b X-Received: by 2002:a05:6a00:301d:b0:6b5:ec98:4289 with SMTP id ay29-20020a056a00301d00b006b5ec984289mr2311315pfb.14.1700309410891; Sat, 18 Nov 2023 04:10:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700309410; cv=none; d=google.com; s=arc-20160816; b=sx4+8NvWRhGj4OalQddxYFvX+vQHmEPbf1tLB9W47kySG7I80zUil7R1hkiasWnx+W 1EzA6Qb3w7mW51j0p4BGo9a01aVI0ZJXlCvYFNQSZQkmdxpN/TbDHPxPnYcSwIFjP1Cb Uox+IICT6P8ro2L04Wp/wRb3SmTU++XokBoAtkssElXYKv4ZNM13VP1YBVLpt9h02tMo Qye/DRYe3TGJ/Q/8V3Jz/RvIOkcW5xlCqLkLCG9yCPBTnTwQvj3nbAZwa/QOrWEhENNi Jjrj9bDjp/JzL1m5CuBZdA6IHcjEQiBtbO0/sCxUfUrbmGmPSKEQbPV5p+G1us+/i2Fs E6hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :auto-submitted:content-transfer-encoding:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=0sA5BnhMh1p9FBBWBrm1hHmuBv2jHLGeJP9VM9Osrbg=; fh=lfmAJNlsrgVlLfgmf+xa0zOkAKc6VKVRczifYgkRnAY=; b=bvXxPeHWYLC6i62carxsQoDe+PxJVY2DVxzOcgpBz4NsHTjuzDsXSw11ueokDqNnfG 3g7VfAno6oUn7y9SMyw3R31BmjdaDXG6KajyLlmj0vTaotJ49Yq5wNZAi1v0hxsftHDL QFoJPWLGjkLB402o90voeFlpC0o8bxXosfMmSe3Apf895ipdvDhvDNadvBN8XBfMS81q 8OEbOVkYUopCLIR8sImX8sMfiUUZk/tuVlNikRm2DgrD3uy6qHNWjBAn+zZW49gD1xkx 2p8sZPObi9HltA9y+0XZSNHl4+DfFeoGFHJW7o0kxmaXHRnEuFgSwYY4nwccBLuOGdRP yQNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JNAlVyOs; spf=pass (google.com: domain of linux-ext4+bounces-32-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-32-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w68-20020a636247000000b00578f23273a3si4254914pgb.738.2023.11.18.04.10.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 04:10:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-32-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JNAlVyOs; spf=pass (google.com: domain of linux-ext4+bounces-32-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-32-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 553B628100E for ; Sat, 18 Nov 2023 12:10:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BF36510A38; Sat, 18 Nov 2023 12:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JNAlVyOs" X-Original-To: linux-ext4@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D3FB10976 for ; Sat, 18 Nov 2023 12:10:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 9F601C433CA for ; Sat, 18 Nov 2023 12:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700309404; bh=0sA5BnhMh1p9FBBWBrm1hHmuBv2jHLGeJP9VM9Osrbg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=JNAlVyOszEjVWtNZ/HPJv+TnS81vu7PVAZMFCsUNnLjTnUPywmyQKJ4SHZCulQs2G KVagPfT21XNCibrmi7T2gEHab4/pRm0nJBl6MXQrQ9JZ0PLI0U9kbruBtfHv502rui jdfXcj3xaYLyHcmq/ZoaYjhT7YsIze9uz/kubihdMQVScj+jAnr2pCPlyjKJsuIqfC yKNtrRwqUgDz32agyFKC9hF9oFwI72rVyuNQY7InLTtNKgWLN1cj83ia9HafGmPTVt X5CYFYGRehI1GDVykoI4wy2ePWwI+QrMxX1O0ig3w7odN+KCOe/uI9dv7trBYKEBy1 wS6/sC3qbF3lw== Received: by aws-us-west-2-korg-bugzilla-1.web.codeaurora.org (Postfix, from userid 48) id 87501C53BD0; Sat, 18 Nov 2023 12:10:04 +0000 (UTC) From: bugzilla-daemon@kernel.org To: linux-ext4@vger.kernel.org Subject: [Bug 217965] ext4(?) regression since 6.5.0 on sata hdd Date: Sat, 18 Nov 2023 12:10:04 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Product: File System X-Bugzilla-Component: ext4 X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ojaswin.mujoo@ibm.com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 https://bugzilla.kernel.org/show_bug.cgi?id=3D217965 --- Comment #40 from Ojaswin Mujoo (ojaswin.mujoo@ibm.com) --- Hey Eyal, Thanks for the data, the perf probes you added were correct! I see that the problem is as I suspected where we keep looking trying to fi= nd aligned blocks in ext4 when probably none of them exist. Aligned allocation right now is only done when stripe mount option is passed as an optimizatio= n. Currently we don't seem to fallback to normal allocation if aligned allocat= ion doesn't work and this causes the very long, seemingly infinite looping.=20 I can try to work on a patchset that fixes this however as a temporary fix = you can continue with stripe mount option turned off for ext4. This will then instruct ext4 to just use normal allocation rather than aligned. One point to note is that -o stripe=3Dxyz is sometimes automatically added = during mount even when we don't pass it. You can look at Comment #6 #7 and #8 in t= his bug for more info. To confirm it's off you can look into /proc/fs/ext4//options file which has all the currently active mount options, you shouldn't see stripe there. Further, this is not something that was changed between 6.4 and 6.5 however seems like the allocator changes in 6.5 made it even more difficult to come= out of this loop thus prolonging the time taken to flush.=20 Also, just wanted to check if you have any non-prod setup where you'd be op= en to compile kernel with patches to see if we are able to fix the issue. Lastly, thank you so much for all the probe data and logs, it's been a huge help :) Regard, ojaswin --=20 You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.=