Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp149198rdf; Mon, 20 Nov 2023 20:39:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjHep6Zn+qLTBzKg9xQ+/sxdHXp7pmdQMy5OGhHMB6j2cYidEad7sd9qN8GDM4eJKDVWbn X-Received: by 2002:ad4:574a:0:b0:670:ba7c:938d with SMTP id q10-20020ad4574a000000b00670ba7c938dmr2404706qvx.25.1700541580213; Mon, 20 Nov 2023 20:39:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700541580; cv=none; d=google.com; s=arc-20160816; b=WzPVl7UrwkStvv4XF/nZ0I7oDmR9Z+oK6ptFs8sY7daT/OoVgyumQOgXFm3Y41dEHz xin1yRfiqxwQ5/NC/poa43WSPjM9a38iSh9B6zz9MUF7KdLtQDxF4fbhxv9LAfA7BAAF fgoTKLogjfjUYTP7Q8aY6bfn/OWqY76+tUpAxMTBRZSOhWyvyxKZ7W66QyJsyhUlNHtx kTbXMXj6k0FJh10I4r4ffnswKPyAICy2PnPv5DgRorF4CQjyjZUCFSy6MoRMlIoA17uz +/xJlsHpAixKS5YgYfQEK23xveJExheIqZbgW/Cgc9GedkhpeJBnnBtb0dyAr+GPhcfL f5iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bTJJPadAeJVnTikEqzzM+h8zjE6rG0xXKqndLgJTXvw=; fh=FW3K8SsatDsWIpbiCVYsxhuaXmltdDjxfyWwgebVeiU=; b=CnbxuugIAOEB9o9JElxRm0ui5K53/mpkZNObPpFIgatX7znVDOGWArf7MYnNMpSq6x +Yohcz+l8tKrdlDouAoGCrMLQc6gS+hOHNJMTziK5I4RCg6yFLUv8XJzMK+bSzU5d483 KDXL7mkwfnHJeMLdM7meDNyHqUwGnGK/TNdNGifacJ7CirkHq7ouhVoBbSOl256+Mkk5 FfWwnltSobrctb/w9eEsNA6zhnwm7VmvmfiqFlCNmpbdVpNGFvj259MT8mUO7fZFiKVj Gj7999vawLAdjuwkdjaOj0qr4tUfAZ2+UJh60j+fyMO6zLc8vYMTlixKwsaJh7XwX4At zl2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jQfcYKsP; spf=pass (google.com: domain of linux-ext4+bounces-60-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-60-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f5-20020ad443e5000000b00677e7da97d1si8748338qvu.544.2023.11.20.20.39.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 20:39:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-60-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=jQfcYKsP; spf=pass (google.com: domain of linux-ext4+bounces-60-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-60-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 020161C218A3 for ; Tue, 21 Nov 2023 04:39:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4509546B8; Tue, 21 Nov 2023 04:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jQfcYKsP" X-Original-To: linux-ext4@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66693DC; Mon, 20 Nov 2023 20:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bTJJPadAeJVnTikEqzzM+h8zjE6rG0xXKqndLgJTXvw=; b=jQfcYKsPwpTWa7v/kaXGCzm+ff 7taxF0s3zGT4ROV5MxGt5w6BxRNbCyDUi3ZAoKczroeB4DSOzJbOayORz3iArrAfPlh2j1cJc6aRT dn1yL/sKZw2TVgppkBeO9kw4rBVJDAB2PQBvp1DEr4ragN1rNsExR9cF3JiT7xdj+9oNPxaK1GX/d qlNL2NsAGExG1YcFb76Hv+zAc3VDSLZlEzbFvToKTayUO0MSVbNEg8pv5z6sD705dE7cfvzV2obDi YqmSD7QSrCpn96RdAUCZK9u5F8BbatrqJ6s+RGifuIBWThQVHHQV0QRL1B9I4G+ui9Sm0HAFgA+wv Ggca/7Aw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1r5IXo-00Fbn9-2Z; Tue, 21 Nov 2023 04:39:28 +0000 Date: Mon, 20 Nov 2023 20:39:28 -0800 From: Christoph Hellwig To: "Ritesh Harjani (IBM)" Cc: linux-ext4@vger.kernel.org, Jan Kara , linux-fsdevel@vger.kernel.org Subject: Re: [RFC 1/3] ext2: Fix ki_pos update for DIO buffered-io fallback case Message-ID: References: <9cdd449fc1d63cf2dba17cfa2fa7fb29b8f96a46.1700506526.git.ritesh.list@gmail.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9cdd449fc1d63cf2dba17cfa2fa7fb29b8f96a46.1700506526.git.ritesh.list@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Nov 21, 2023 at 12:35:19AM +0530, Ritesh Harjani (IBM) wrote: > Commit "filemap: update ki_pos in generic_perform_write", made updating > of ki_pos into common code in generic_perform_write() function. > This also causes generic/091 to fail. > > Fixes: 182c25e9c157 ("filemap: update ki_pos in generic_perform_write") Looks like this really was an in-flight collision with: fb5de4358e1a ("ext2: Move direct-io to use iomap"). How did we manage to not notice the failure for months, though? Otherwise looks good: Reviewed-by: Christoph Hellwig