Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp1069428rdf; Wed, 22 Nov 2023 05:03:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGk2uVa5pxRfYXtqj6Lp2YLrNAP0DwRP297UWAv1p9v4OQ5Y3iLF1jX+SprDVkJEPFswGM9 X-Received: by 2002:a05:6358:590e:b0:16b:b189:3aa6 with SMTP id g14-20020a056358590e00b0016bb1893aa6mr2086443rwf.3.1700658180602; Wed, 22 Nov 2023 05:03:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700658180; cv=none; d=google.com; s=arc-20160816; b=nofe4O9t+Gult6+/duBMzY97ugFk5GwhvxC95/ZYXJZmw8gP3Ly5G65Eaa/vBu5yHi h3sInNV/XmDNollzirbPGZ0MDBlWh7o0qX/9HSp/1wOJEakIERSQAv8jHMnrXFi8ocP1 I9DyQ8VjfsMNVPU1VHyuqJbFpa8xah71UwNwLt0cT5vy3OBwALHzmW9GijaRhd9po8Sw lagauM7qExE7l9HGSYvNkrKJtoIUz+Pcji0cLj9XTBp4iTsLmWfVFwUmOAQRvV6NQPyL yTrxYmKbFCuekeFkvACwrVw6dhDXzA63uoSrn8COTPIL4/vt/aBEmbqWcgm66dTHNd4B 0NBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:from:references:cc:to:subject; bh=z+7gMVcpXsi8QwsBzu4lDuE3/6rmcZwKKz+sbNbZ5c4=; fh=A1h0zjvYMmoSxJWxKz5sHFz7gIKanPUBkJbF6K4rcfc=; b=0i/b4ilpjOWG00aZ+4mqS7Yy/qJlYur+euQiLtb7pxPBT7/m77Fojy77Cxmul0Nry6 gJG25ghDsnYSjjng1bWGyJMcUZ0Pq6F5HNh1gF2K08Iw/39ZrHaBzTT9BIrnMp3+dFPR fuSAknw7J8G/ZCfxIfvC+zwRorGYp3jaxUc7hNnzq8jLQKjVvdGUgRv5iGnpWEcy8Wqx Myzw96QzaZVPTp9JUxRD3DB0UpnqXop7KcbQ0zdf8yADgL4ORXhU/qUzANxRcgJHwf6J YnU6GqM3PIR53EsZRehTVK21WTI3VzmnNGzo9a+iMzwaHt9t/qqzY7YyL11WSJvVGGpw R2dQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-81-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-81-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v21-20020a67c015000000b00460d355a65esi2447847vsi.52.2023.11.22.05.03.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 05:03:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-81-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-81-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-81-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 08A331C20953 for ; Wed, 22 Nov 2023 13:03:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 323E44C634; Wed, 22 Nov 2023 13:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none X-Original-To: linux-ext4@vger.kernel.org Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69BE5193 for ; Wed, 22 Nov 2023 05:02:51 -0800 (PST) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Sb1Xm2Fk1z1P8fl; Wed, 22 Nov 2023 20:59:20 +0800 (CST) Received: from [10.174.176.34] (10.174.176.34) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 22 Nov 2023 21:02:48 +0800 Subject: Re: [PATCH 0/5] jbd2: Add errseq to detect writeback To: Zhihao Cheng , , CC: References: <20231103145250.2995746-1-chengzhihao1@huawei.com> From: Zhang Yi Message-ID: <1d45466e-44e2-5be4-d2be-f7339dd4b5b7@huawei.com> Date: Wed, 22 Nov 2023 21:02:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20231103145250.2995746-1-chengzhihao1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected For series. Reviewed-by: Zhang Yi On 2023/11/3 22:52, Zhihao Cheng wrote: > According to discussions in [1], this patchset adds errseq in journal to > enable JDB2 detecting meatadata writeback error of fs dev. Then, orginal > checking mechanism could be removed. > > [1] https://lore.kernel.org/all/20230908124317.2955345-1-chengzhihao1@huawei.com/T/ > > Zhihao Cheng (5): > jbd2: Add errseq to detect client fs's bdev writeback error > jbd2: Replace journal state flag by checking errseq > jbd2: Remove unused 'JBD2_CHECKPOINT_IO_ERROR' and 'j_atomic_flags' > jbd2: Abort journal when detecting metadata writeback error of fs dev > ext4: Move ext4_check_bdev_write_error() into nojournal mode > > fs/ext4/ext4_jbd2.c | 5 ++--- > fs/jbd2/checkpoint.c | 11 ----------- > fs/jbd2/journal.c | 11 ++++++----- > fs/jbd2/recovery.c | 7 +------ > fs/jbd2/transaction.c | 14 ++++++++++++++ > include/linux/jbd2.h | 37 ++++++++++++++++++++++++++----------- > 6 files changed, 49 insertions(+), 36 deletions(-) >