Received: by 2002:a05:7412:e79e:b0:f3:1519:9f41 with SMTP id o30csp173081rdd; Wed, 22 Nov 2023 12:26:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCn+Ih5wkBZZ2WZJYHJ1nDBTisPSM4MfxGOLlQsWXfEp6rgUG5mFKiczssDJweRQMXS7a6 X-Received: by 2002:a17:90b:3b8c:b0:27d:3e8f:26dc with SMTP id pc12-20020a17090b3b8c00b0027d3e8f26dcmr3327345pjb.9.1700684799529; Wed, 22 Nov 2023 12:26:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700684799; cv=none; d=google.com; s=arc-20160816; b=naIZxxoNmCz+6qtptJ8w3RC3y9yt8TiUi3lAlp2bjoNFy9Frr8g5WP38ol4UWKU+5K afwZA103q6wOCuQ/BFPvu3unEvrkjzDjJzGFbta291Wtjn8fpvrGXp88CLcLDPKdQXEL hyz+79dtZgwoVZh+cFXgz0HjUfNSoDH554ySoR1vuHgqFutOTM1/rRYt9tea/0i+VZo6 AFT9NoSu/c6thpj4knXVFPNPxeICqP/ApwgpqGZ0EaQAD+N/jEObOgJG3c8eevych+0G lhdQnwLk4QFDgt/eSuRYdL0pgtcF4JREmcBultZ5/JTYPWEnO2+wq2uoxlGAbQI6WXo3 lorg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature; bh=MYNW2A2wXnMUotvyb3lU3//WT+ELjlFrTwfx+eM2UFY=; fh=NUsYj6z/YCSHzceQqm9/f8LOql64KgJA6IHGjHxRN+g=; b=zQr6s2is+gIfkkAUPjhDnKNMaGB77/RlfjUmeQbQdi9sOXpnHwC44kPaI8OmGmRDIH a90anIX1AwOsdKMQG9KCxYAWoHCneBD/S4uE3Sj6HcMk1c66rMZi1N490o0oDH8PKEjr Pmf77MMblr5T+UeDX4hM3A0hxfK0ufZpElgMQEflhLR1dWEgK45IOHjLBVUS8D+QEklr HZs453gZXnNMcxHUXLnNaKgJ90SBdS1Cw1xBUxTo+5WYslMudAIl/40xxAQGdrXI85PR bjhihx810Ay9uOQMC2RIBW6qa6b550EvzJp9u212S0feZhNPbZeo8cH1GIaeqIc57HCH hOVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BY+U2osZ; spf=pass (google.com: domain of linux-ext4+bounces-88-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-88-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id co2-20020a17090afe8200b0028524e799b3si287336pjb.42.2023.11.22.12.26.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 12:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-88-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BY+U2osZ; spf=pass (google.com: domain of linux-ext4+bounces-88-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-88-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 74FCB281683 for ; Wed, 22 Nov 2023 20:26:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39AC15CD0E; Wed, 22 Nov 2023 20:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BY+U2osZ" X-Original-To: linux-ext4@vger.kernel.org Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BA29A; Wed, 22 Nov 2023 12:26:27 -0800 (PST) Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-359c22c44d6so629325ab.2; Wed, 22 Nov 2023 12:26:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700684785; x=1701289585; darn=vger.kernel.org; h=in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=MYNW2A2wXnMUotvyb3lU3//WT+ELjlFrTwfx+eM2UFY=; b=BY+U2osZRKvoMw9Vo+OdWRQP3vfbAlq7j+ipaaRlahG5hkxiPwb8ssXwRKKuwGbZT0 +UWiYv7C0Weov3kwGVT73vNLH8IUqXZ6NYD+m88qjOUjQFh6gy8Z3J/QgepujxVZtY5V OCfXTu0qjABjdcEUlBDLXcSwt5PWG1IhS890A7h9/QOfYRqhj2PH29vQPkoYRUrY340a t4w9V7ca89m0YKwp/Ae4nFdDvSMWHcfcqmTtzZUcf8iSZp1JEFtdSDwClee1UJBJwJ56 wMcXxdO9lrCfnzW6LMWidt6CFBriVjYah3qyeqdE2SkhfbM1WhhETNGcGvqQSq0jIs5C nZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700684785; x=1701289585; h=in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MYNW2A2wXnMUotvyb3lU3//WT+ELjlFrTwfx+eM2UFY=; b=dB9m/7iewo4kcNl+VMaXYLEFTtDNgY29HIofOi1qwEhzy9gaNEV6mu/NpPea6tlP/B bTbJRY1xxAjLkpmXOr/UdY52mbLPx4lC6odtFtPULkxccsPhPhMq1JIneKUNxZW03QI2 5k2BJ+6+scDA3Pgrt/GwbiAaPscuVO21LP6FPa4U1EKyM67+1dzUKUcKbJhdCdqQ7TKK qxiYq7RNGSJjWfGAzP0fMbXxaowJioMwSVQAu06BK55GYBHRilrsnIUDbT592SWhhHQ1 tgzh/7OengGdA0cOf39nkfPx4uhNkzuv1A7NNoZIuiD2TIUl3XvLoaKjn2HcjZS51JF1 WB3A== X-Gm-Message-State: AOJu0YxyC4N1oyKDWMjdX7D3uho1bgnk+/5riICwK2ncTeMn13NGNpcH h5FyDnJ5vQJQhYD9RaTUGeh2GmwuGwo= X-Received: by 2002:a05:6e02:1c2d:b0:359:3ac2:5123 with SMTP id m13-20020a056e021c2d00b003593ac25123mr4920456ilh.23.1700684785468; Wed, 22 Nov 2023 12:26:25 -0800 (PST) Received: from dw-tp ([49.205.218.89]) by smtp.gmail.com with ESMTPSA id b20-20020a63d314000000b005c215baacc1sm94413pgg.70.2023.11.22.12.26.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 12:26:24 -0800 (PST) Date: Thu, 23 Nov 2023 01:56:21 +0530 Message-Id: <87msv5r0uq.fsf@doe.com> From: Ritesh Harjani (IBM) To: Christoph Hellwig , Jan Kara Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC 2/3] ext2: Convert ext2 regular file buffered I/O to use iomap In-Reply-To: Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Christoph Hellwig writes: > On Wed, Nov 22, 2023 at 01:29:46PM +0100, Jan Kara wrote: >> writeback bit set. XFS plays the revalidation sequence counter games >> because of this so we'd have to do something similar for ext2. Not that I'd >> care as much about ext2 writeback performance but it should not be that >> hard and we'll definitely need some similar solution for ext4 anyway. Can >> you give that a try (as a followup "performance improvement" patch). > > Darrick has mentioned that he is looking into lifting more of the > validation sequence counter validation into iomap. > > In the meantime I have a series here that at least maps multiple blocks > inside a folio in a single go, which might be worth trying with ext2 as > well: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/iomap-map-multiple-blocks Sure, thanks for providing details. I will check this. -ritesh