Received-SPF: pass (google.com: domain of linux-ext4+bounces-137-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Subject: Re: [RFC PATCH 11/18] iomap: add a fs private parameter to
 iomap_ioend
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu,
 adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com,
 djwong@kernel.org, yi.zhang@huawei.com, chengzhihao1@huawei.com,
 yukuai3@huawei.com
References: <20231123125121.4064694-1-yi.zhang@huaweicloud.com>
 <20231123125121.4064694-12-yi.zhang@huaweicloud.com>
 <ZV9xgAXbJMCJqWvt@infradead.org>
From: Zhang Yi <yi.zhang@huaweicloud.com>
Message-ID: <12a61016-1df7-5cf7-94e3-3a07103cbbb6@huaweicloud.com>
Date: Fri, 24 Nov 2023 09:36:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <ZV9xgAXbJMCJqWvt@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 2023/11/23 23:36, Christoph Hellwig wrote:
> On Thu, Nov 23, 2023 at 08:51:13PM +0800, Zhang Yi wrote:
>> From: Zhang Yi <yi.zhang@huawei.com>
>>
>> Add a private parameter to iomap_ioend structure, letting filesystems
>> can pass something they needed from .prepare_ioend() to IO end.
> 
> On it's own this looks fine.  Note that I have a series that I probably
> should send out ASAP:
> 
>    http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/iomap-map-multiple-blocks
> 
> that makes each ioend only have the embdeed bio, and bi_private in that
> is unused, so you could just use that if we go down that route.
> 

Thanks for this improvement, I will analyze the changes of this series
in depth.

Thanks,
Yi.