Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1722441rdh; Sat, 25 Nov 2023 00:13:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqLgcWfdY0tE3k43u21iR9XRpzPkeUMYtO50qJ1P5V6FDkGpRjrkt+SAjysm5+dvSBfGD3 X-Received: by 2002:a17:907:7289:b0:a04:bcc4:b8d8 with SMTP id dt9-20020a170907728900b00a04bcc4b8d8mr3950940ejc.43.1700899990167; Sat, 25 Nov 2023 00:13:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700899990; cv=none; d=google.com; s=arc-20160816; b=DWWZUdv1HUhN+jIvBe0AemRGTDZammK4m2SPq6vfLGaf964jPPlzB/OnqfQWvPFtPe OtCva5wQYoQROQc3UpUz70OsU9vOcKto2QlTvInRvuuvuz+6SjC2qHE/z+Nwf5ZAiGYx /wY4sEFy7oe3gmo54KahjBJ/C3wPr8MmgYo2RgDhqWy8kVbz/hHUILyktNoo1l8wqtYg SgweV8pmCtsTCnzUovSw37azwFTddQFQ2DgPTqK5GxACHYWBHfagsuenVz5LLlFg7Q2R zEZQ+MHI0a2shLVUHS3wK/zY1fTFpHpvFc8z1G1cmPnyPjC8XgmtTephlw4OVtgvfafo QMbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Ilualq1MUEYYRqmt8PF8a/Y8LFdYvuw0frNNzhzDiC4=; fh=eu2llfKjKKC0QBUtW6YWJ13du6subP7SB8ZN6DjSWMA=; b=cUw4PHdmHoHX0Juv7WB9bqkBDMxmyoe3AgOHy+qn/aGY/SGrh57slTW1nhaGtV5136 DjYVTLY4tUXCsoucNOTQcUhbX3UJjj6jG2xWZUm6RtIgNYukceg7d8pOIJ49Q/0LK15+ N9roFDvXhIyWQStfUCQfTGnzMROWGmZRICPtpunfgsg5Ii3Bvx30za+PIJY90lxTMRLC o8NzylONPpa1UHJR6Pu2cRFkECmHgzAnvwzdU8k06Z66jekKu0MKLmlgy8E27lnyKNvH 4SYceP2pl4B972eWwL+SYfEg7nZDJE0ZuEGDtANDRGmSwHsh70LtyRVkK9lhuNiphOI8 wFTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-150-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-150-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z9-20020a170906270900b0099cb1ff44bcsi2816823ejc.613.2023.11.25.00.13.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 00:13:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-150-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-150-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-150-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DDF411F20EF4 for ; Sat, 25 Nov 2023 08:13:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E0F05945F; Sat, 25 Nov 2023 08:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none X-Original-To: linux-ext4@vger.kernel.org Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87BDC10F7; Sat, 25 Nov 2023 00:12:55 -0800 (PST) Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Scl2p1Vm2z4f3kjX; Sat, 25 Nov 2023 16:12:50 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id F39F91A01F4; Sat, 25 Nov 2023 16:12:52 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgCnSkmCrGFlWcLEBw--.36822S5; Sat, 25 Nov 2023 16:12:52 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/8] ext4: remove unneeded return value of ext4_mb_release_context Date: Sun, 26 Nov 2023 00:11:38 +0800 Message-Id: <20231125161143.3945726-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20231125161143.3945726-1-shikemeng@huaweicloud.com> References: <20231125161143.3945726-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:Syh0CgCnSkmCrGFlWcLEBw--.36822S5 X-Coremail-Antispam: 1UD129KBjvdXoWrKFyDWF1UXFyDJw1kCw1kuFg_yoWkuwb_GF WUGr4xCFyrA34fC3WFy3yrtFZagrs3Ar1jqFs5tFW3uayUXr4xCw1qyrn8ZrZrWr48A343 Crn8Cr1UCrZaqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfxYFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r1rM28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jy0PhUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Function ext4_mb_release_context always return 0 and the return value is never used. Just remove unneeded return value of ext4_mb_release_context. Signed-off-by: Kemeng Shi --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 765b62729..f79e87ad3 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -5939,7 +5939,7 @@ static void ext4_mb_add_n_trim(struct ext4_allocation_context *ac) /* * release all resource we used in allocation */ -static int ext4_mb_release_context(struct ext4_allocation_context *ac) +static void ext4_mb_release_context(struct ext4_allocation_context *ac) { struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); struct ext4_prealloc_space *pa = ac->ac_pa; @@ -5976,7 +5976,6 @@ static int ext4_mb_release_context(struct ext4_allocation_context *ac) if (ac->ac_flags & EXT4_MB_HINT_GROUP_ALLOC) mutex_unlock(&ac->ac_lg->lg_mutex); ext4_mb_collect_stats(ac); - return 0; } static int ext4_mb_discard_preallocations(struct super_block *sb, int needed) -- 2.30.0