Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3176913rdh; Mon, 27 Nov 2023 08:02:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFW7P/UhELh+txu2EIr+BVsE+U5HhFNTg2PlrI+dtHYEu65M3wePincZbP+DDyYkbGK9WUt X-Received: by 2002:a05:6a20:918a:b0:187:c496:898b with SMTP id v10-20020a056a20918a00b00187c496898bmr13403061pzd.3.1701100923923; Mon, 27 Nov 2023 08:02:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701100923; cv=none; d=google.com; s=arc-20160816; b=g8UI+G5dM8qU9U4aMj2OHmdw3XaKU18/hzsqfjk5zSHe2CB9nubSRuRZf569JPqSil YKRIMgmSRru0yD7bvXL/RsKixiyiBGnaDb10WLYukmnEw3axynw1LTw6J8pL6ogaKftT xjDSPWaYlvve9gV6iomion9DG7knzwwOSp7Z9+bM94YdHWgnKPhzZWIM/OnxpA4MJEqC RXeeWyYa5EkWxE6Hqs34vXiaSXtJr1C4RwuNotR+fNGImvMBV3RdFGwsEStzxgrFjqEx tNJEUQ6Nl7H2j6xxnRDJV1OnMyFgREl27t41nbr2SAgB34DBZzcFA5EVqg7RUG7rFV25 ut6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:user-agent:message-id:in-reply-to:date:references:cc:to :from; bh=MnIsW2gRlEkCMgJZdG09I4YKTZY6znkqa+JAZFPAg/o=; fh=P3kCxdGoXMkJ/fP9FnXKuBFFC0vf/QjN0oTfgcS/b3U=; b=hXCHFvihm2rmoa+ty/b3sxW9jXPKoDQTsDaptIuagMbgnsudRasstpVBTyC0mjtmvj LGCWRZ+6KNqixvsvXeFqihRhyKbnNqmgx5GGaWKkvRU5Ns1/is/f6ujDZGm+Ei+F7R7r 0Tv8Tfk0OdLfEEGCGPmPm5TiXZ+VzVs8u0/KIH0vOlr5Z/ZIf3XwZRS+WCVyAd7OOKoP YVjgEiFVsMJgD0dxfPFUgFTyfIHIL5G4ry8xAdnygcIm8Ez8Dwvc5qv9wHS7Ustne1xN 8bP8W4b3ZDrngIjj/XaCJdvZ3o8lhQ50ZOxEqtW4jvlZLwZCLQXypCWMAywSwNIUpGA1 eN9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-ext4+bounces-196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id v4-20020a056a00148400b006b618af5cd5si10278326pfu.300.2023.11.27.08.02.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 08:02:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-ext4+bounces-196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9D18EB212C4 for ; Mon, 27 Nov 2023 16:01:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C8A8C34CF4; Mon, 27 Nov 2023 16:01:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none X-Original-To: linux-ext4@vger.kernel.org Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B58B3B4; Mon, 27 Nov 2023 08:01:45 -0800 (PST) Received: from in01.mta.xmission.com ([166.70.13.51]:53182) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1r7e3M-00Ahie-5g; Mon, 27 Nov 2023 09:01:44 -0700 Received: from ip68-227-168-167.om.om.cox.net ([68.227.168.167]:51768 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1r7e3K-006NOb-0n; Mon, 27 Nov 2023 09:01:43 -0700 From: "Eric W. Biederman" To: Al Viro Cc: Gabriel Krisman Bertazi , Linus Torvalds , Christian Brauner , tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, Miklos Szeredi References: <20231121022734.GC38156@ZenIV> <20231122211901.GJ38156@ZenIV> <20231123171255.GN38156@ZenIV> <20231123182426.GO38156@ZenIV> <20231123215234.GQ38156@ZenIV> <20231125220136.GB38156@ZenIV> <20231126045219.GD38156@ZenIV> <20231126184141.GF38156@ZenIV> <20231127063842.GG38156@ZenIV> <87jzq3nqos.fsf@email.froward.int.ebiederm.org> Date: Mon, 27 Nov 2023 10:01:34 -0600 In-Reply-To: <87jzq3nqos.fsf@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Mon, 27 Nov 2023 09:47:47 -0600") Message-ID: <878r6jnq1t.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1r7e3K-006NOb-0n;;;mid=<878r6jnq1t.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.168.167;;;frm=ebiederm@xmission.com;;;spf=pass X-XM-AID: U2FsdGVkX18LzyKBjPL9+mOeggwlTuuNaPzk+DvVEcQ= X-SA-Exim-Connect-IP: 68.227.168.167 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Al Viro X-Spam-Relay-Country: X-Spam-Timing: total 1572 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 12 (0.8%), b_tie_ro: 10 (0.6%), parse: 1.54 (0.1%), extract_message_metadata: 48 (3.1%), get_uri_detail_list: 1.85 (0.1%), tests_pri_-2000: 66 (4.2%), tests_pri_-1000: 3.9 (0.2%), tests_pri_-950: 1.64 (0.1%), tests_pri_-900: 30 (1.9%), tests_pri_-90: 340 (21.6%), check_bayes: 337 (21.5%), b_tokenize: 15 (1.0%), b_tok_get_all: 65 (4.1%), b_comp_prob: 2.9 (0.2%), b_tok_touch_all: 201 (12.8%), b_finish: 1.20 (0.1%), tests_pri_0: 1017 (64.7%), check_dkim_signature: 0.73 (0.0%), check_dkim_adsp: 18 (1.2%), poll_dns_idle: 15 (0.9%), tests_pri_10: 4.2 (0.3%), tests_pri_500: 43 (2.7%), rewrite_mail: 0.00 (0.0%) Subject: Re: fun with d_invalidate() vs. d_splice_alias() was Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) "Eric W. Biederman" writes: > I am confused what is going on with ext4 and f2fs. I think they > are calling d_invalidate when all they need to call is d_drop. ext4 and f2f2 are buggy in how they call d_invalidate, if I am reading the code correctly. d_invalidate calls detach_mounts. detach_mounts relies on setting D_CANT_MOUNT on the top level dentry to prevent races with new mounts. ext4 and f2fs (in their case insensitive code) are calling d_invalidate before dont_mount has been called to set D_CANT_MOUNT. Eric