Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp61772rdb; Wed, 29 Nov 2023 20:23:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwTGPHrpoIqcChELsOJTcVB2cuTbVuU3UM7eEnmJ0KOQRPz+05WAt26aoKp3nkIztcFlHM X-Received: by 2002:a17:902:b194:b0:1cf:f359:ce37 with SMTP id s20-20020a170902b19400b001cff359ce37mr7551586plr.2.1701318188205; Wed, 29 Nov 2023 20:23:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701318188; cv=none; d=google.com; s=arc-20160816; b=fWLB00uXlb36iHAOWFTidAzEjuAiPnrGuY+GJP8CswtxavgN4sJ20X3KHjsVJdTAnT Od73Vb+3LAtxo/lvajNZeXakMVcP4e8M5JkBX0PXv9xoOvWOktXbCNFBLrXIcWtgNHxs o9XdKmfHqJyprNqAKFtmhnfQB8KM4Q8yezMKGNKEjdslLZBmsklKQyK356+jZPxsb8yj DFmXCBTmHyUa3LjmJn2U1aAbd4ZedfoZU39ud4kyi0XmpokwLHI8gVNnLEhq3TV8lGOp RgHBRCYOtTqimabL1hZaO9anXzUvdxvl4iUCJEFZEATi27ibrdmjTJr1Q84x/jkrrJG8 VmSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=3eVTSPU/wHc1JxPlc9sW5c1lU34h67IEdzpeTekuaiM=; fh=V27LbAvSmQJYIXm5tSWviLTBmLElXzk2J/hfFga/8SY=; b=eKr5m7qKvGeaeEIrf+J8ypKsChRi2WudP7NqjBpr+prnaIBwA+ndDSgH/1SN/5kZUx 6BfNhst+vVinXTyRdnOcna9RNN4Ed8Z9eMmtZE9AJFBJQtrTubHbLDnwC4dz/v/2XFI6 I9pJKn9xsslZiTU+b8pSJX/cBl3MZRiZ6c+sGFhfsjErRd13TED9ZNfo4PlSBXQRi6A4 U+9NQJF+VTSg27iqwrGKto15l+YkNkBnwOFiC++KPpyUgKX6gPqPFs4doicX3XOcDqix FwQTMB1h1MN/dujTh1E9Mo0GGAJIgs/mPZm/f2X39WAx+xVmTCikLtpjjBsa9Kev0AQz e1fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cQF0DvTO; spf=pass (google.com: domain of linux-ext4+bounces-227-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-227-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l6-20020a170902ec0600b001cfb87c51f2si339551pld.194.2023.11.29.20.23.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 20:23:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-227-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cQF0DvTO; spf=pass (google.com: domain of linux-ext4+bounces-227-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-227-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 09DB128182E for ; Thu, 30 Nov 2023 04:23:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5745C171AB; Thu, 30 Nov 2023 04:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cQF0DvTO" X-Original-To: linux-ext4@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5107110DB; Wed, 29 Nov 2023 20:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3eVTSPU/wHc1JxPlc9sW5c1lU34h67IEdzpeTekuaiM=; b=cQF0DvTO/vJOPZ8a3h7bZqdMwc EV94pQnXknE9uCAeBH8zeE4XdgstKhhm0A8asG7CVIXLyyMrnR236UIdc1FNqbnflOrx6HZlMdCQC Q2S9isiopWOoyjVoMTcoBpf75VkovSU5UvKHL8l/Bq6UGl3HQG5Cky7WnC1420ztJHtfP28oOFEdV pwBFTSlmf/0teUV68i7lBlvSVhfyQkieE8ElftYYVOE256hVpaK2oHzR2JbK4DCkvnnwxhU9rWFLL krG2CL9qwaafRCi2IL12zlHI8hP9VTg5nqEDDe8fVEUSrXNziGTaf2fsa/G7KPlW0tOm2jNmb/w4r rbhrsomg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1r8YZh-00E4tj-J3; Thu, 30 Nov 2023 04:22:53 +0000 Date: Thu, 30 Nov 2023 04:22:53 +0000 From: Matthew Wilcox To: Ritesh Harjani Cc: Christoph Hellwig , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC 2/3] ext2: Convert ext2 regular file buffered I/O to use iomap Message-ID: References: <87msv5r0uq.fsf@doe.com> <8734wnj53k.fsf@doe.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8734wnj53k.fsf@doe.com> On Thu, Nov 30, 2023 at 08:54:31AM +0530, Ritesh Harjani wrote: > diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h > index 677a9ad45dcb..882c14d20183 100644 > --- a/fs/ext2/ext2.h > +++ b/fs/ext2/ext2.h > @@ -663,6 +663,7 @@ struct ext2_inode_info { > struct rw_semaphore xattr_sem; > #endif > rwlock_t i_meta_lock; > + unsigned int ib_seq; Surely i_blkseq? Almost everything in this struct is prefixed i_.