Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp66396rdb; Wed, 29 Nov 2023 20:38:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBGUdxEmy7KGMVDRhA+9ml1FboN4kNBcWtgeJCAGfikvSlXjqLbT0NjTjG3ysmqfQvMMKq X-Received: by 2002:a05:6a21:33a4:b0:18c:18d3:c8fd with SMTP id yy36-20020a056a2133a400b0018c18d3c8fdmr16240885pzb.14.1701319089757; Wed, 29 Nov 2023 20:38:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701319089; cv=none; d=google.com; s=arc-20160816; b=u9mbBmEa8L8OsXJb1Ch+X6BcGrrcBARguOs95InJCohh8GJBEbCtLI2C4CnFlSiykh VKIwz7RataxDIZym1WwU5cwS8U/uQTIzGfEI/k3evwKnMzkvaducGmMQZI+PC5KgPDBt zKIKuMJ1fotS6koc36xjUNr391yvsC8BAPj5mj7FCAJJypNd2c8PShFk/SM51yfXlLIv Fkt0K5X+u1E9Ox039IFIHWNze8q1NY0lcH5tbDG4ZPkt+o59JL47pyMowXEhbVtcoXNE V+PIBFt7TALW+rnV+M3qk97laendcJ8SCJNX9zC63hyOdbRmBfu0ieFi2YRZKZ7WVqHp aUPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature; bh=ByPdLVUoOLVZ48+By0ZGaQZsMUA+NEYCsjkvaY2u+8I=; fh=EFyv9VarNfZItVYYX0gD0hciJBpi6/51DPPpU3xe/jo=; b=UHFh+vWewH6wkxSRm8GAzl+2wVQR1Qv3GkOdf0z+38wyRka8BugIguGmXqA7HZliw2 oJu+nbQL3AkcvdTQCOV+qa4IuI2r76EwrKrD/P5ksN1jIMR1bAdkdme4koUNT1ow5YLG A+Q1U3yTtfMAVM+oWX+hf+SAJhUD2krj5Xic2vg6Pd7gKYq4RlppHyaZs+wGB7HH8cK4 mNKPw/6CPj2BV7Fm11beGnF68VFk+b7nhd/hwzxJWqt1jwaGEUIj+VhsAzNSQ6B4DUKk sA3g3iwAaHmQkCZJBt13A+AwxmctWRQawb788Jxxh4a2pHh5gE4Td6rVQmxDOhWHRIyq PXAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=afQ17xJa; spf=pass (google.com: domain of linux-ext4+bounces-229-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-ext4+bounces-229-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id e7-20020a170902744700b001bbf293f45esi318637plt.625.2023.11.29.20.38.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 20:38:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-229-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=afQ17xJa; spf=pass (google.com: domain of linux-ext4+bounces-229-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-ext4+bounces-229-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AFCBFB2118B for ; Thu, 30 Nov 2023 04:38:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1EAB410A3B; Thu, 30 Nov 2023 04:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="afQ17xJa" X-Original-To: linux-ext4@vger.kernel.org Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B118710D5; Wed, 29 Nov 2023 20:37:52 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6cdd584591eso554356b3a.2; Wed, 29 Nov 2023 20:37:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701319071; x=1701923871; darn=vger.kernel.org; h=in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=ByPdLVUoOLVZ48+By0ZGaQZsMUA+NEYCsjkvaY2u+8I=; b=afQ17xJaP1NYZ70l7vSIyXMn9XBFPGmUtcFoWqZhnFi1AjvFslRwqxIxnRnDMxl3W1 EGBRX1AXPSiqhNyOROAly4fQazJFcZ+IBwOz7zBv7s4O2IYsIAnS3hXpUHQWr4hGVbDz LY9y4U0lHEnbTBJmP+oB2Vb9MiwAbrqJo7dSaq1fCetWmD2a5L3CMYcvOXSShN/iCnNq V8pp039b8+KyEnnFyRZ4o4MaoTYfmlMJQgYiegOZsD7aopy36ZdB9Xxfjm5zgLsWNDVu LgZQo7rrrDdu44oIciIf4qyXfKTgj7Uevd2TG3foBgaXPrAylWajhrGIDRfGu0U8gfF6 d72A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701319071; x=1701923871; h=in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ByPdLVUoOLVZ48+By0ZGaQZsMUA+NEYCsjkvaY2u+8I=; b=DQ2q832KEFYFgg02JhgbVm40V+Ru+AxsqqURlebO9WrUdfsupW5+ArAEQaQWx+4WOE tWYl+gRKgJ9o4RoqjyCRvJMjgX9M7ElMZENUgCilo8jNtlRbITq2g0BEAshVJzLcmGnE NGzbrPatjGXHl5GgOar9vLhr6W8eF9jRpCd8bDBKPdkpQUAJ+qO+EF1x8nmAIjHlc45e 4+5ImXHFlykIGFsq5OvTN8oQVh7j+Vu/s6EzZCJciBIRw8EIX0mE3Wadi6I3WGQo486J ARnx7Y8pThpsfRwOBB82JNOLFugbMznzbik8wnz1ELhr2PR3+ei8HeTszoNvH9oSYsAI p+dQ== X-Gm-Message-State: AOJu0YzjQJCVL8Roc1Kb/FQmR5ijKXcNCTXIPopltALgaII0ti0RGN4s ymGzFZbeBEyZJ8f7GXlWjbxFG/3hUOM= X-Received: by 2002:a05:6a21:998d:b0:187:a2ca:409c with SMTP id ve13-20020a056a21998d00b00187a2ca409cmr23146492pzb.5.1701319071210; Wed, 29 Nov 2023 20:37:51 -0800 (PST) Received: from dw-tp ([49.205.218.89]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c10d00b001c73f3a9b7fsm228003pli.185.2023.11.29.20.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 20:37:50 -0800 (PST) Date: Thu, 30 Nov 2023 10:07:47 +0530 Message-Id: <87zfyvhn50.fsf@doe.com> From: Ritesh Harjani (IBM) To: Matthew Wilcox Cc: Christoph Hellwig , Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC 2/3] ext2: Convert ext2 regular file buffered I/O to use iomap In-Reply-To: Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Matthew Wilcox writes: > On Thu, Nov 30, 2023 at 08:54:31AM +0530, Ritesh Harjani wrote: >> diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h >> index 677a9ad45dcb..882c14d20183 100644 >> --- a/fs/ext2/ext2.h >> +++ b/fs/ext2/ext2.h >> @@ -663,6 +663,7 @@ struct ext2_inode_info { >> struct rw_semaphore xattr_sem; >> #endif >> rwlock_t i_meta_lock; >> + unsigned int ib_seq; > > Surely i_blkseq? Almost everything in this struct is prefixed i_. Certainly! -ritesh