Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1759810rdb; Thu, 7 Dec 2023 08:06:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmZTD/HabAuu8BSuUJEij0l0U1b4KJKb49AiJnq0e+hqKDyRmKDTLRz8FDKc6SwdNx5S0X X-Received: by 2002:a05:6a20:4caa:b0:18f:d141:f608 with SMTP id fq42-20020a056a204caa00b0018fd141f608mr1945375pzb.104.1701965175963; Thu, 07 Dec 2023 08:06:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701965175; cv=none; d=google.com; s=arc-20160816; b=OB8zTa/ngSFEVyT6rbnAsj2k32qBWIu6GV/3ZS4UzsLfDeQOVsgkydT4vR3tSBZTSa Mzu6bWpRooaRQKxHd897/2M0yYcRDCMaMvxuwYWoa+FrqIXCecIEHCi567yXWf2jYjRK FIr1R7yDnakBzDsW3fGMP0rv1XwXebhwq93aM9jb1v2dzG/uk9/twxPa9T5GXB0GICot GMh7ab3hNgMelBmK+9P4Sc4yOqPZZ8qA6rWucoMePFF0PZEtkrDAL81X7Fu3fZ89OsrK /LpajHqBXBi5u1O2NIyT9B1wRnyXzcuwhlDODsqMtMOhXK9yVjEs+cPVDHwipceN07Dg 326Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=8BdDr1D3xUuDvfKV4qPcVeU4Ul2r9TwrsoOPCjJK3AM=; fh=15nh+a6OArP6uU9HsiQMWuNisZoxH8+5c9elX12U0wE=; b=ceryeo87Vjf22RaMMYSaKM6m4r9P1lp7/etNWgR67AZLk+RF8ABONUvwgyBfw4koLW kx+E3UODDfU/exjM4mZ7ovscvyf156IHOxYpVPboKvN/ZLDomAab81nCepueOC9B2c0/ fx2O7g+AAVd5nSFBzozLdGXc9CIdN631DvZ6nLBOCmG/l9sfb+2yaHfkaxMRTidSrXVh wlnIfP1dB1d5WQ1brXXvnzKgP8flnDCGlhV0iCRXoiF2IxjR0kcr1QXy9Fht19ZVFAGw WhGTKhd+rgsW66xdrvN/cjZtQOyCzwCLwtDW6C4mSwr6hMpX+BNV/lYzIOaGihJvbjuc F8bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b="gmeyRRi/"; spf=pass (google.com: domain of linux-ext4+bounces-341-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-341-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k1-20020a63d841000000b005b8eacb29c1si1343308pgj.437.2023.12.07.08.06.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 08:06:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-341-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b="gmeyRRi/"; spf=pass (google.com: domain of linux-ext4+bounces-341-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-341-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8396228210E for ; Thu, 7 Dec 2023 16:06:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59DE946B90; Thu, 7 Dec 2023 16:06:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="gmeyRRi/" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CA2A3 for ; Thu, 7 Dec 2023 08:06:04 -0800 (PST) Received: from cwcc.thunk.org (pool-173-48-130-174.bstnma.fios.verizon.net [173.48.130.174]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 3B7G5wYw030813 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 Dec 2023 11:05:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1701965159; bh=8BdDr1D3xUuDvfKV4qPcVeU4Ul2r9TwrsoOPCjJK3AM=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type; b=gmeyRRi/kLLUS3YirVKsvfDLfT3P1/v02NfZWE69A9I2LtQNy9rYsoLZ+INPH9iEY XaoSbWqPHylOvrZVyXGP8f+nLjiXF+O2+0Krn24HUs4xbNU+S+3YEqFBri79zsC2TJ de/VQEla2vwac+Vk/gtvTeAFrTiwbVVCWx+0tW+eBkCSsTo8s085aoBSDs2sAPjXes BBr3XF5vLzEv5mRUo3qbqkpliHLbhOa16AZEr6ynlsgW1WRJzpcaJ2VO+jcQlrXgw1 5bvRMXJaT7j6JQkxRJjD5JLtEMoy5u43bMFpUBA+WqUromucekmoOzjieLbcWPBijM tB5Muzeh8T8Gg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 59A7115C057B; Thu, 7 Dec 2023 11:05:58 -0500 (EST) From: "Theodore Ts'o" To: Andreas Dilger Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext2fs: don't retry discard/zeroout repeatedly Date: Thu, 7 Dec 2023 11:05:53 -0500 Message-Id: <170196512708.16594.7215006522173799558.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <1683695929-26972-1-git-send-email-adilger@dilger.ca> References: <1683695929-26972-1-git-send-email-adilger@dilger.ca> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 09 May 2023 23:18:49 -0600, Andreas Dilger wrote: > Call safe_getenv(UNIX_IO_NOZEROOUT) once when the device is > opened and set CHANNEL_FLAG_NOZEROOUT if present instead of > getting uid/euid/getenv every time unix_zeroout() is called. > > For unix_discard() and unix_zeroout() don't continue to call > them if the block device doesn't support these operations. > > [...] Applied, thanks! [1/1] ext2fs: don't retry discard/zeroout repeatedly commit: cc20e3c4320ae34dd06ec4d6a71d07aa7d6599d7 Best regards, -- Theodore Ts'o