Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4628796rdb; Tue, 12 Dec 2023 05:15:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNZuGQiPihyZWTmUJ2I1Y1ZRPriGXndOUBzL7bXgi0vKifMoeHudFT3LaHwgReWSF6EOUk X-Received: by 2002:a05:6e02:1d0f:b0:35d:6ac4:a430 with SMTP id i15-20020a056e021d0f00b0035d6ac4a430mr10198636ila.50.1702386924050; Tue, 12 Dec 2023 05:15:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702386924; cv=none; d=google.com; s=arc-20160816; b=FL38B1UMOuKw06qhur1qz+1BlPGkf1OsfVpCfgCQBLHY6aamJ/zsgW0noSiOI+JLj3 EFyauUQqqb/soVR0jCs8XF+9XxYLzmCSOvDgBIaFB6n8l8RuEWI//eUJxo/Rx/+4OoIh LadjYG4tgGm+qZrfqckJb3eiLwclnLX+JHofpS9UghX3dL+qkpIkTJ48t+IpBv7xd96b Mxrph9D1ohFISqOLsOwv/ITcEcXXfyOOOtK8ikfqe/P65qOJ7yaFvrgLi10PplEodCga VHO1bhwVtfty9A2S6w5Qe6M93QYvoWZ7ppwAbTNpdoIkMqCICBMWxg1Nkdt4VgwMQoKv o2ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=d9GOM1CReQqHO2Eq5TSJ+QFrtD+BDx0i0I5iG3RHOkc=; fh=hRoTRAxkyHRqj5r1cgocIXAECH+86Ka7P4pBocLQuDA=; b=NuBwJOkB5vSG7bf/BMd/IufggLRXJd6q0Gs8WeuJM4UKlFEzoN2MLPPDvQXDGllRoh n77kmiAmyNhJv4SSPvmKtsLOw++O1FJ583s8Kmk502W6D5q3RBlvGH7F6AmMKh/8F2aU h91YyYXxcjFzWjW4/9YpHotCQWg0prIsUY4xIHoHh8vcUZdsbWDU/imvicpckNHQjhtm 2D38s55vudoNl2LRfpqDzUn7kWP9t4vUEjAk1NkcQt2Tt5XOX+glfgYbyf4gWKDRIchJ uyZO5GIArjLKONNV0VVbw5K/oTfqIeaQqQk6JeHF/zkSEcCKyonZeG8QlQhTB3MlpQnG Oa+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=dT7hUcTd; spf=pass (google.com: domain of linux-ext4+bounces-394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-394-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s24-20020a632158000000b005be0d708412si7421458pgm.31.2023.12.12.05.15.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:15:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=dT7hUcTd; spf=pass (google.com: domain of linux-ext4+bounces-394-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-394-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9180F2816DE for ; Tue, 12 Dec 2023 13:15:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 45EB56168C; Tue, 12 Dec 2023 13:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dT7hUcTd" X-Original-To: linux-ext4@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A045A7; Tue, 12 Dec 2023 05:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d9GOM1CReQqHO2Eq5TSJ+QFrtD+BDx0i0I5iG3RHOkc=; b=dT7hUcTdggq68z9eTLTpZvkowz o0hzxFtGP/1A5CdpXLfKR7IAabXtd6tscvW4EWJ7bqf73me/qP/EdG2B4FI3typytMvICOqncBaZB juLPQegmxMqcDjRUgDWRxj7eyVDzzLp60SQCJEDdgc0OscK42Z3kENibYVgGF0I1l4mcAYgv7Nega dtBKSq2W5Eht1hqZUznEkZjKNtAWvDjb82DMtqFruzGL7aQEKgH38NdlFfSSWk5+OxXcyVtpRNqmc NPwFb5zSyEEcKZJQSk14/2oMDYGzCgMBHQVgCHGvkAUHl3vAl4PoAud1hrwXpknFsKsviOKDCWU7T JzSMOq4g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rD2ae-00BldE-0K; Tue, 12 Dec 2023 13:14:24 +0000 Date: Tue, 12 Dec 2023 05:14:24 -0800 From: Christoph Hellwig To: Jan Kara Cc: Yu Kuai , axboe@kernel.dk, roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com, joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, viro@zeniv.linux.org.uk, brauner@kernel.org, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, agruenba@redhat.com, jack@suse.com, konishi.ryusuke@gmail.com, willy@infradead.org, akpm@linux-foundation.org, p.raghav@samsung.com, hare@suse.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis Message-ID: References: <20231211140552.973290-1-yukuai1@huaweicloud.com> <20231211140552.973290-2-yukuai1@huaweicloud.com> <20231211165217.fil437byq7w2vcp7@quack3> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211165217.fil437byq7w2vcp7@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Dec 11, 2023 at 05:52:17PM +0100, Jan Kara wrote: > > +void bdev_associated_mapping(struct block_device *bdev, > > + struct address_space *mapping) > > +{ > > + mapping->host = bdev->bd_inode; > > +} > > Here I'm not sure - is the helper really a win? It seems a bit obscure to > me. This initialization of another mapping for a bdev looks really special. If we want to hide bd_inode we'll something like this helper even if I don't particularly like it either. But it might be a good idea to move out of this series and into the follow on removing bd_inode, as it's rather pointless without that context.