Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4630296rdb; Tue, 12 Dec 2023 05:17:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqHhAC7Py41sRotBzjKQYGMqP3VTkYPGJ1Sw7oIfGK2A0gammgT6t8AM3mRiG8SWkR1mVN X-Received: by 2002:a05:6359:223:b0:16b:f950:3d83 with SMTP id ej35-20020a056359022300b0016bf9503d83mr5783147rwb.31.1702387058394; Tue, 12 Dec 2023 05:17:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702387058; cv=none; d=google.com; s=arc-20160816; b=FlNOoHTYpeZi6GAduuzPupIYp2k23yNoYUJnlfwedif4YoAXvZqf3egzWsH8xt3p8g dNJ3IG1W/WMFUkXM1sMo4YPGNtzFIv1miw9ST2XQ/B0zNpmXoswRuwvIKMXPzm2PKQxT yu7UNU/CNYRLn8qDLc0jq+XlEC2/V/yZ3GH4lq+PcTTIIDJ03T2DKb6a1KcgE+XpuivF Aox0n8pCCMl3aZFDK8NxJSQiFadQUZmZWdi2HqCQbA/1qI6EkoM8aHOgpaxiBjPqlGAf 7q1KIMb46QCzzMl1HxOcdtsM7mKEQ/B0OT8mtT3HpD8GsVG8kmF9T8bH5KpiM5eDOp2v iekw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=76xsvfvsQao0L1F4mpEWw4iFvDSKTUGOH0rkCxylyR0=; fh=MeUUOj2j+iy27Ff8NnB29oTRl/j/84R5JYZt8JRFf0g=; b=nBJShJ8S+QaTiSqRfg4i6RWhnFBCs3Gjxecbo6xDRtxrsh81fbcOPR1jeR5ZZ/ocaq QptKO4+M9sYltWGmUz9DIncZhsY74tONFxusffaDJU/L+iOoil/aMXQ/YIxCVDQ7yoVP lGCsW8f5omtnPWVQNPOYfb0L/YwmPv8W08npX4CP3AhZqaplwF1M6Hx1RSxMGw6WbwKe 4HMoPc8gJoeOsCAIVuHoahLFmkwjmOg94duq9D9GVbfMYRaYvZsLuKnE99vyu8m4Hw4r vrqdXZP3IxGUkS7UaTEy2dNVeiyVjU9e4glSVsnssM6jt+WoUTtjVSHpb+HolbJzJIs5 jh4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QmO1jXrH; spf=pass (google.com: domain of linux-ext4+bounces-395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-395-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id br21-20020a05622a1e1500b004254561c6b3si11089995qtb.802.2023.12.12.05.17.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:17:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QmO1jXrH; spf=pass (google.com: domain of linux-ext4+bounces-395-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-395-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2597E1C20C91 for ; Tue, 12 Dec 2023 13:17:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C91EF61699; Tue, 12 Dec 2023 13:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QmO1jXrH" X-Original-To: linux-ext4@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D856210E; Tue, 12 Dec 2023 05:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=76xsvfvsQao0L1F4mpEWw4iFvDSKTUGOH0rkCxylyR0=; b=QmO1jXrHyamW18FiZ0XlDmH8Gd J6J4dTRw2FLTkkOKvQrns7exRXAFguyfbw2uOyWEWmNoQXBfbqBZNewfmIkmoQ6bdSNxZ1x5tnPZH 084wgWpxKkNR2iIpsHjtrRZ9JY1ddTp/EvS2MbTosRtewIEI8Orvb3OQJiNOerl/hksqowqURXjvG fYWtLshBV60dlUDv9CIGwurTqiWt8vAiJIHs2JUjuped4+Ibfiu5fRUW9EHItbwHjIC6CXlZJyNyk OIbxjiE1dEkn9Ncl10qwLKuiHA8BtEyU6VYvKAm8AyY9ExdjsSwpGxcfoUdawzLHnMiAOJUPVSQrR k2K6LA6Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rD2d4-00Bm1M-0C; Tue, 12 Dec 2023 13:16:54 +0000 Date: Tue, 12 Dec 2023 05:16:54 -0800 From: Christoph Hellwig To: Yu Kuai Cc: axboe@kernel.dk, roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com, joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, viro@zeniv.linux.org.uk, brauner@kernel.org, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, agruenba@redhat.com, jack@suse.com, konishi.ryusuke@gmail.com, willy@infradead.org, akpm@linux-foundation.org, p.raghav@samsung.com, hare@suse.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis Message-ID: References: <20231211140552.973290-1-yukuai1@huaweicloud.com> <20231211140552.973290-2-yukuai1@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231211140552.973290-2-yukuai1@huaweicloud.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > +void invalidate_bdev_range(struct block_device *bdev, pgoff_t start, > + pgoff_t end) > +{ > + invalidate_mapping_pages(bdev->bd_inode->i_mapping, start, end); > +} > +EXPORT_SYMBOL_GPL(invalidate_bdev_range); Can we have kerneldoc comments for the new helpers please? > +struct folio *__bdev_get_folio(struct block_device *bdev, loff_t pos, > + fgf_t fgp_flags, gfp_t gfp) > +{ > + return __filemap_get_folio(bdev->bd_inode->i_mapping, pos >> PAGE_SHIFT, > + fgp_flags, gfp); > +} > +EXPORT_SYMBOL_GPL(__bdev_get_folio); It's a bit silly to have a __-prefixed API without a version that doesn't have the prefix, so I'd prefer to drop it. Unless willy has a good argument for keeping it the same as the filemap API.