Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp6476250rdb; Tue, 2 Jan 2024 03:23:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiFp2rYtlSnfKsGfDOk91zSXDrGVXQSiAu2ybYvbHdMxh7f6SsrNqlvkRLqDJmNfxgQs+V X-Received: by 2002:a05:6a20:1442:b0:195:efb7:5c9d with SMTP id a2-20020a056a20144200b00195efb75c9dmr13644182pzi.49.1704194603435; Tue, 02 Jan 2024 03:23:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704194603; cv=none; d=google.com; s=arc-20160816; b=feiJ7CMetloLTNZXnigJh+fBObReGtVpKgHSN+jDRr48jc6KsN8zFojOzDTF5Jk5zs geS0OoEs7dmEP6xnwhsKMriQ+elM1vvvIkK39Ak8cQ7gNjEiBejjkcLIF5aPrS6YzFG+ 1ftd5sSK7r5SZ5XG2U3LokwlgO8A7wjz8cWn9mwvPfsAiae1JcsuvLGfIwoUnxXWsv9g DJfnqhdmEjimOqlLRFWACQQlcw1CwvqU9loQXCPMduHi3KP3sZbEmz0MiaAH6vwoZCxS 4PzMpA+sms5sDEFXKIAIkH3uL65HDOlzFGLo0XpBpnM0JHnKCiOqxhHjUxRkbftJvuTY T0Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=1MJbqjIA9i7ydghr/09GLiAWhZ7XVcZsDNuWGdzATY0=; fh=g1H2JjuacV03RCWbi+yPJLWJGm5Q25u3Vhrxm/0wGDM=; b=GrFAGJiuEohC3EqynQXqa4Wu8+FG5xcSbeFTVDzTaknyw/eZbHM9lrqrlcNmgtp31M YTVbpO29pACpVy68/jaZ2bbrCxwPpCo203dzuxdPTPSWma/l5fWuuHoCabyXdkwJwj+j sn6vQ4DsHLwtsjBI9GY9+2Q57kEPPkLif5pfPrXDfzSMTRI2hlCl89eUGPqh+o73Szhu wtHLKl8x1Ru4u6QAg2Ia4rCugA2n59hX2wRQ9+Vqdwg+QiG+aPL7ZF7iKfzuWssaSJWe 2FYF0xJP3Nu9UAgffzlSibG8j+VA4LNZ5W5DZwBowNRzRL6254WNu+PhvAD13U6yvk+O Jk3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-591-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-591-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2-20020aa78e42000000b006d9abdaaf7fsi15357905pfr.303.2024.01.02.03.23.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 03:23:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-591-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4+bounces-591-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-591-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1DD01283194 for ; Tue, 2 Jan 2024 11:23:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29DA5EAD7; Tue, 2 Jan 2024 11:23:05 +0000 (UTC) X-Original-To: linux-ext4@vger.kernel.org Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F965EACB for ; Tue, 2 Jan 2024 11:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4T49SY2fztz4f3jJ5 for ; Tue, 2 Jan 2024 19:22:53 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 992101A05AA for ; Tue, 2 Jan 2024 19:22:56 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP1 (Coremail) with SMTP id cCh0CgDn6hAK8pNlRXREFQ--.38187S4; Tue, 02 Jan 2024 19:22:56 +0800 (CST) From: yangerkun To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz Cc: linux-ext4@vger.kernel.org Subject: [PATCH] ext4: return 0 when ext4_get_group_info failed in __mb_check_buddy Date: Tue, 2 Jan 2024 19:20:12 +0800 Message-Id: <20240102112012.672260-1-yangerkun@huawei.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgDn6hAK8pNlRXREFQ--.38187S4 X-Coremail-Antispam: 1UD129KBjvdXoWrZFykCw4ruw4fKF43Xw1DJrb_yoW3Grb_Ka 4xAr4rGrs5JF1IkFnYkwnYvr4ftFs3Wr45XFZ5Jr43XFWUWFZ3ua4kJr93AF47u3ySkFW7 Cry5Jry7AF1S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb2xYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2Ij64vIr41l42xK82IY64kExVAv wVAq07x20xyl4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s 026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF 0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0x vE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E 87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUr_MaUUUUU Sender: yangerkun@huaweicloud.com X-CM-SenderInfo: 51dqwvhunx0q5kxd4v5lfo033gof0z/ The return value for __mb_check_buddy should be a integer. Found this by code review. Fixes: 5354b2af3406 ("ext4: allow ext4_get_group_info() to fail") Signed-off-by: yangerkun --- fs/ext4/mballoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index d72b5e3c92ec..55c70a1b445a 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -758,7 +758,7 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file, grp = ext4_get_group_info(sb, e4b->bd_group); if (!grp) - return NULL; + return 0; list_for_each(cur, &grp->bb_prealloc_list) { ext4_group_t groupnr; struct ext4_prealloc_space *pa; -- 2.39.2