Received-SPF: pass (google.com: domain of linux-ext4+bounces-630-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Subject: Re: [PATCH 8/8] ext4: remove unnecessary parameter "needed" in
 ext4_discard_preallocations
To: Jan Kara <jack@suse.cz>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20231125161143.3945726-1-shikemeng@huaweicloud.com>
 <20231125161143.3945726-9-shikemeng@huaweicloud.com>
 <20240102131058.3ue6phafczjezlic@quack3>
From: Kemeng Shi <shikemeng@huaweicloud.com>
Message-ID: <48611a18-004f-7721-cc1f-104a5980b6cf@huaweicloud.com>
Date: Wed, 3 Jan 2024 09:27:29 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240102131058.3ue6phafczjezlic@quack3>
Content-Type: text/plain; charset=gbk
Content-Transfer-Encoding: 7bit


on 1/2/2024 9:10 PM, Jan Kara wrote:
> On Sun 26-11-23 00:11:43, Kemeng Shi wrote:
>> The "needed" controls the number of ext4_prealloc_space to discard in
>> ext4_discard_preallocations. Function ext4_discard_preallocations is
>> supposed to discard all non-used preallocated blocks when "needed"
>> is 0 and now ext4_discard_preallocations is always called with "needed"
>> = 0. Remove unnecessary parameter "needed" and remove all non-used
>> preallocated spaces in ext4_discard_preallocations to simplify the
>> code.
>>
>> Note: If count of non-used preallocated spaces could be more than
>> UINT_MAX, there was a memory leak as some non-used preallocated
>> spaces are left unused and this commit will fix it. Otherwise,
>> there is no behavior change.
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> 
> Looks good, just one nit:
> 
>> @@ -5491,15 +5491,12 @@ void ext4_discard_preallocations(struct inode *inode, unsigned int needed)
>>  	mb_debug(sb, "discard preallocation for inode %lu\n",
>>  		 inode->i_ino);
>>  	trace_ext4_discard_preallocations(inode,
>> -			atomic_read(&ei->i_prealloc_active), needed);
>> -
>> -	if (needed == 0)
>> -		needed = UINT_MAX;
>> +			atomic_read(&ei->i_prealloc_active), 0);
> 
> There's no point in always returning 0 in the tracepoint so I'd just update
> it to not print the 'needed' value as well.
Thanks for review! Sure, 'needed' looks meaningless to the tracepoint. I
will remove it in next version.
> 
> 								Honza
>