Received-SPF: pass (google.com: domain of linux-ext4+bounces-666-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 4 Jan 2024 11:27:47 +0530
From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/9] ext4: remove unused parameter group in
 ext4_mb_choose_next_group_*()
Message-ID: <ZZZI2yTyAXs3gIzL@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
References: <20240103102821.448134-1-shikemeng@huaweicloud.com>
 <20240103102821.448134-3-shikemeng@huaweicloud.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240103102821.448134-3-shikemeng@huaweicloud.com>

On Wed, Jan 03, 2024 at 06:28:14PM +0800, Kemeng Shi wrote:
> Remove unused parameter group in ext4_mb_choose_next_group_*().

Hey Kemeng, 

Just a small thing, the parameter we are removing is "ngroups" rather
than "group" so maybe fix that in the commit message. 

Other than that looks good, feel free to add

Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
>  fs/ext4/mballoc.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 9f9b8dd06..765b62729 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp)
>   * cr level needs an update.
>   */
>  static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac,
> -			enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
> +			enum criteria *new_cr, ext4_group_t *group)
>  {