Received-SPF: pass (google.com: domain of linux-ext4+bounces-669-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [PATCH v2 2/9] ext4: remove unused parameter group in
 ext4_mb_choose_next_group_*()
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
 linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240103102821.448134-1-shikemeng@huaweicloud.com>
 <20240103102821.448134-3-shikemeng@huaweicloud.com>
 <ZZZI2yTyAXs3gIzL@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
From: Kemeng Shi <shikemeng@huaweicloud.com>
Message-ID: <7a7df602-37b1-d134-ec51-7dba26f72213@huaweicloud.com>
Date: Thu, 4 Jan 2024 14:50:18 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <ZZZI2yTyAXs3gIzL@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Content-Type: text/plain; charset=gbk
Content-Transfer-Encoding: 7bit


on 1/4/2024 1:57 PM, Ojaswin Mujoo wrote:
> On Wed, Jan 03, 2024 at 06:28:14PM +0800, Kemeng Shi wrote:
>> Remove unused parameter group in ext4_mb_choose_next_group_*().
> 
> Hey Kemeng, 
> 
> Just a small thing, the parameter we are removing is "ngroups" rather
> than "group" so maybe fix that in the commit message. 
> 
> Other than that looks good, feel free to add
> 
Thanks for let me know. I will fix it in next version.
> Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> Reviewed-by: Jan Kara <jack@suse.cz>
>> ---
>>  fs/ext4/mballoc.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
>> index 9f9b8dd06..765b62729 100644
>> --- a/fs/ext4/mballoc.c
>> +++ b/fs/ext4/mballoc.c
>> @@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp)
>>   * cr level needs an update.
>>   */
>>  static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac,
>> -			enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
>> +			enum criteria *new_cr, ext4_group_t *group)
>>  {
>