Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp8129497rdb; Thu, 4 Jan 2024 22:09:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4EUgLvv9z0BhCz4CfYm5w7QXbugKKtxukP/3Kcu9rg59vcJMLlaVnyuloZfuOvk10J/ri X-Received: by 2002:a05:6512:3049:b0:50e:7e93:4d38 with SMTP id b9-20020a056512304900b0050e7e934d38mr523718lfb.112.1704434985797; Thu, 04 Jan 2024 22:09:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704434985; cv=none; d=google.com; s=arc-20160816; b=DdWKrgb7AUjP3E1hlkJXPrT+CLJSaIlH4YiNmR5GUDN0aKCYIaQeZeb9OSHBaNmw1f hDy/PV3vjW95xtrz4fh58vmixC4S0fHToUedEqXPu+s6ICnaEoW5kF2qBiWZv7IYDDj+ 4qyLm8ZveCVZlnFP0kR8WE7mlv6YcGkMmMfu+bCgVGbXdzmChCJkrFX9RiSVJij5Fg4A YsuiPkuiulr8UKiFEIS0bpU3Qbjd/4TefY0NdrT7uFiDqHtNKUYt/FA69/ZhWT0fDL5k 0xPW3EW2nYpJoyFDg8zJSnDaNs/CiPtu+B0pfbFrDGunn2xdbzwtwSUv1JIv9mRbjsf8 YUHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MfpbILepFAZMB7h2HpBoL7ju9YNJfneelNa0zdsWGTE=; fh=jCtQQgjEKt1ruENbs7NH38RtxzP4SAJUAX1Qyh5MNsU=; b=GLTD7axF+W85VQoNFjveS8EtpnPPu0ltptrZmtQfxJJJ7mJrxINXS3oT1AFcsI3zTS lFHTJPdiT379NAZTK5T+8yYaN7/VCldVOUUe7kMh7eeDHtbF6TX5iU5Xgy86qFOdzNIb OgDhyuU7kBh9FD0N7Wo5xH/lqrjglbG5EEMRFvdpvsqmmsnW8ID9EgA+CLmlop0qr/dS o4SuG18UlLeCfXWiIW4lEmvPd+wnVnjHMf8TA+8R8D6ErfX1K06c1EW92SToJmklHjKB 2jPRqyUbqHHkbTdWMrZI92aKeyxdLmFDMmqBYdf5+JQIbGz8f9QYODQ2zWQ2KnraUBvu g9pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=e70OEnap; spf=pass (google.com: domain of linux-ext4+bounces-724-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-724-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 20-20020a508e14000000b00552f9eeb7c9si367045edw.323.2024.01.04.22.09.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 22:09:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-724-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=e70OEnap; spf=pass (google.com: domain of linux-ext4+bounces-724-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-724-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8529C1F233A4 for ; Fri, 5 Jan 2024 06:09:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EFE3315EA2; Fri, 5 Jan 2024 06:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="e70OEnap" X-Original-To: linux-ext4@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53483566A; Fri, 5 Jan 2024 06:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MfpbILepFAZMB7h2HpBoL7ju9YNJfneelNa0zdsWGTE=; b=e70OEnapxROCnryMJ+/p/ZRb6q Co5Z26/TzQb4j3uqh1HZXPyKmCgH2RwmGzkFPqv/2KSdkod23+EEjl5k+gUFVeqhE5cLIgjhrZRln /TXAnczuvmS/5fv3lonygpNZAr1rkpjLeOKpUo4IcO+WT8eqyhpsxuK7Ezd7daqbCvaeMhieEDC36 2YdiX92FOcKP4zmjzJggSzAOI+XBEn3tUqKwk8TRuVaK3ZW0yVd/FMa71m8GX6rJkaQu4CkxJRsNW K9G8CtK6Nzof6XV0ra5vX4twK05qlkoQTCHmArqOs9K34hsqfqleQt54ZZt7JnrErtkJGz1qKQ4DI JcEjMrNg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rLdNq-00G2Lb-1Y; Fri, 05 Jan 2024 06:08:42 +0000 Date: Thu, 4 Jan 2024 22:08:42 -0800 From: Christoph Hellwig To: Jan Kara Cc: Yu Kuai , axboe@kernel.dk, roger.pau@citrix.com, colyli@suse.de, kent.overstreet@gmail.com, joern@lazybastard.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, sth@linux.ibm.com, hoeppner@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, jejb@linux.ibm.com, martin.petersen@oracle.com, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, viro@zeniv.linux.org.uk, brauner@kernel.org, nico@fluxnic.net, xiang@kernel.org, chao@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.com, konishi.ryusuke@gmail.com, willy@infradead.org, akpm@linux-foundation.org, hare@suse.de, p.raghav@samsung.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-nilfs@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH RFC v3 for-6.8/block 02/17] xen/blkback: use bdev api in xen_update_blkif_status() Message-ID: References: <20231221085712.1766333-1-yukuai1@huaweicloud.com> <20231221085712.1766333-3-yukuai1@huaweicloud.com> <20240104110631.3vspsvxbbvcpdqdu@quack3> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104110631.3vspsvxbbvcpdqdu@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Jan 04, 2024 at 12:06:31PM +0100, Jan Kara wrote: > This function uses invalidate_inode_pages2() while invalidate_bdev() ends > up using mapping_try_invalidate() and there are subtle behavioral > differences between these two (for example invalidate_inode_pages2() tries > to clean dirty pages using the ->launder_folio method). So I think you'll > need helper like invalidate_bdev2() for this. That assues that the existing code actually does this intentionally, which seems doubtful. But the change in behavior does not to be documented and explained.