Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp81424rdd; Mon, 8 Jan 2024 18:54:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOrU4fvdk+7/TY/uk0NnTxlN5g0dJJ2Uka09yWEDbQIzXFaUF1OaQ7RjgPEZ3lkBhMOapB X-Received: by 2002:a05:6a20:12c7:b0:199:c77d:b3c1 with SMTP id v7-20020a056a2012c700b00199c77db3c1mr105224pzg.28.1704768856003; Mon, 08 Jan 2024 18:54:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704768855; cv=none; d=google.com; s=arc-20160816; b=k35+b/MNkbDHQCx3bHyWnozmSt/aJ3kNdaJRxQrkZ58zjdrkJT6bXw79LIIiC5bNmC fh4oUUo995RtFtiJAhF4IlZsk2RgY4CfyUoLAYXHdRbqC4OA5qDDollrXMmYu3wH1OBU 8L3ShYyO7ozqU5EkxR0QDElQ9fU3ZTMTVsyMTeNBU4pDFrW9O9sCpg7otf93Mc+MlX9F 7L9DAiKkLBGNSPEVFhINZ2oTTZwEPJG+a7XWuozuHD4KWaVR8QmwQ72tTM4Bex30x0BG 28rorBqCgMDj9jZZYHQUTSfGaiv8kF1/gJeLjh9hscoRRpEnIPxx4yyRBul0cM2khqx3 F7aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=UXhuEBuXDwLotKDGSEMTd6ASaj351WFs7d8iaB5s+uM=; fh=nqT66pA3i6eS2dzEiVNV2VO6RIbF7qace+xSCd9L2/I=; b=Aq835E6wysTZJ5q2LgR323PY/zc92T1tpMqNeYqrZi9l5bOnwaDZ6zCkqL8hjsqXAb UY8w/3Cg2vPVG9PJrnaHEhhn0G1ulR3NWBmdJbyWQuBm9HfVdSBU2WrF2LveyvGvpM4B qM/vfAJrsPRQrTSrcnpb1qj0alMjW4kkD/aXRZ02y1rrWmWbb3C1E7gYodkwSfiUHPx3 mTzUDg/UwK5dXf/rKPXl0YjZH7gPNZlVFRw5TCWbM60OGbNGrAK3dU0VDsdCag83pE8h daNdhzNdjIrMIAaCtz/r+GUmV6Xbzr9Ef0rro1ySpMb6zsN2zI08G3loJ+nWfWE9kJlS slEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=eR+8wtya; spf=pass (google.com: domain of linux-ext4+bounces-742-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-742-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v124-20020a626182000000b006d9bb8e9e5esi724088pfb.356.2024.01.08.18.54.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 18:54:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-742-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=eR+8wtya; spf=pass (google.com: domain of linux-ext4+bounces-742-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-742-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B009A2856DF for ; Tue, 9 Jan 2024 02:54:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2A76763A4; Tue, 9 Jan 2024 02:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="eR+8wtya" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 455824680 for ; Tue, 9 Jan 2024 02:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-211.bstnma.fios.verizon.net [173.48.82.211]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4092rVGL010644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Jan 2024 21:53:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1704768813; bh=UXhuEBuXDwLotKDGSEMTd6ASaj351WFs7d8iaB5s+uM=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=eR+8wtyam50HwGclMNTIYF+gfDuEowo9N0gAN5+WIdtzwN7QmWbW943zhdIIUSQhJ 3QxKS7Qtxdba1E2E1Z4EnEjEVH4W9uOnlnI7imQssD2YvUWyvyuSdk2TcpfQ9O1oU/ YLPVpJjRZ+DzLHd2EvVo4IaF9W2JPjuUl88mOASDdk71cHqysg7bRGIUHD+JcBTu2W zKS0RhCtsSmAwDXe9k4KwpQU25JXlN+JDBVZpfHUxMu87mKfEvRG4Lnp6GQVATD53w IM/VA+4LDus50zvX8RvAxD4yFwvPLYfKKA7ADwvm48F9UDiNSrdgIev+Kk2f3KGycB SLdzg6c4YBc4w== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 29BA515C0312; Mon, 8 Jan 2024 21:53:28 -0500 (EST) From: "Theodore Ts'o" To: "Matthew Wilcox (Oracle)" Cc: "Theodore Ts'o" , Andreas Dilger , linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: Convert ext4_da_do_write_end() to take a folio Date: Mon, 8 Jan 2024 21:53:22 -0500 Message-ID: <170476879010.637731.3816879496253053607.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231214053035.1018876-1-willy@infradead.org> References: <20231214053035.1018876-1-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 14 Dec 2023 05:30:35 +0000, Matthew Wilcox (Oracle) wrote: > There's nothing page-specific happening in ext4_da_do_write_end(); > it's merely used for its refcount & lock, both of which are folio > properties. Saves four calls to compound_head(). > > Applied, thanks! [1/1] ext4: Convert ext4_da_do_write_end() to take a folio commit: 05f240655f03fd7fcdbfc6129b6fb7dcc3f64e0e Best regards, -- Theodore Ts'o