Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp81495rdd; Mon, 8 Jan 2024 18:54:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcPWsDuSWKDgkzd0x7BtH4+7xQfZUGolC6cxZDu3Z8NCKt3IMl5avBpZ+JlAmBSrTRW/ZJ X-Received: by 2002:a05:6a20:1610:b0:199:d31f:43b with SMTP id l16-20020a056a20161000b00199d31f043bmr1409821pzj.65.1704768867283; Mon, 08 Jan 2024 18:54:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704768867; cv=none; d=google.com; s=arc-20160816; b=HZBCOH+cUqgsvBQR5MvPJ4atnMTtaMEKMeUhYABDqE2oPr0yQW+IAniYsIEfouABNP v4aMvwd0h3zn3nMWIJvUZBblfhJHoWDF4UM0EHqAfe/9XyjGnmK55NUJ5RM1thHtLKzO Y7BJUgBh3MrdhAymcOncI9IQFyEyMvk7EKXmTlPAvk3u6PvlLychO4qnHQKqPDV+hLaV o6J3IIiZMnuZZRLOcbIaeRr0ImxkmXqvWMq/JRzq3gBFJqV0ccgArZ8p7hdI+CgM+jKT iyuCB+QSO+V7dFMjkutqfHA2jYERZ6lewwvbOg0AJfaTdv9oKw6PCbO1vWPDKbIA7W1g fgzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=dS0rHUHIXFe3N5enAhc30rZHiqo2/yFMRYHCtke7c3k=; fh=040ISa9LIodtDRg1N2dXG37Da8v2us14bnuAX2ylM9w=; b=bktlBPtkQo9W8c2TrG4GRH1fBlIZSJTB8F6JLFbSNXkRt207R4VxRafIJxY2AfvuOR TPPo8ykfw9x/Y3rCgnGLKFZ9yRdfc9KidY//THsF/8d/YNMa8W41lciBcNmcROEALz7E AyNz5f7pS5m8/j/8MhrJOIyXm0uj466uJbSzxRTqxLowN9HYxzWA6wsGa1xBcVX9ln/A zSUp3DJlmWkU+FX1lg9fbkjBXg9PQU/iOi/GSElZ8eWWs/m3dY/eH6xMSFAhJd4GqtzJ pxQunsva6oy9zM8OsYyeYt0SkE3qBBg/dFKwDNqbE/zsb7G5Wwc+ODrKxklj1OjclMNv QQ0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=eze4RAO0; spf=pass (google.com: domain of linux-ext4+bounces-744-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-744-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v124-20020a626182000000b006d9bb8e9e5esi724088pfb.356.2024.01.08.18.54.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 18:54:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-744-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=eze4RAO0; spf=pass (google.com: domain of linux-ext4+bounces-744-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-744-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F11CF2856C2 for ; Tue, 9 Jan 2024 02:54:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4E11FDF62; Tue, 9 Jan 2024 02:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="eze4RAO0" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8520B6106 for ; Tue, 9 Jan 2024 02:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-211.bstnma.fios.verizon.net [173.48.82.211]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4092rS01010560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Jan 2024 21:53:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1704768811; bh=dS0rHUHIXFe3N5enAhc30rZHiqo2/yFMRYHCtke7c3k=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=eze4RAO0cvBZBGu8HF+lngKjVJ45ARPs/SQM9VpeEQtPhypDqJEDe7sxfRBF0A47t BnwRhfhl0Q3MUnlVOdYabw54zcN+YEOX5xtEj2BCkmC3AniyXELCbXoCjRdOkJQg/C 2WeKo6czuyOBZkviXu9sEehMiB6smqLtNltsDtnm8OBUUCow/AAeJiNM9tuQi7We4c HBFdw3HeYIjRwcbqCPA1BSt/n9iZ4bBbMO5ZmirYNmY4Bn+2TZ0Ps1wfD8/iQvlb7s uku9JndipIaY6/B3ryiQZcd0gPlSko1yjNSBpcwfvo4QP2xfNIjJyAhtfVaiJAXemT lqAnjPa1cqmDQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1D51C15C027B; Mon, 8 Jan 2024 21:53:28 -0500 (EST) From: "Theodore Ts'o" To: Gou Hao Cc: "Theodore Ts'o" , adilger.kernel@dilger.ca, gouhaojake@163.com, jack@suse.cz, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] ext4: delete redundant calculations in ext4_mb_get_buddy_page_lock() Date: Mon, 8 Jan 2024 21:53:16 -0500 Message-ID: <170476879010.637731.5184546578471274100.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231024035215.29474-1-gouhao@uniontech.com> References: <20231023013416.17246-1-gouhao@uniontech.com> <20231024035215.29474-1-gouhao@uniontech.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 24 Oct 2023 11:52:15 +0800, Gou Hao wrote: > 'blocks_per_page' is always 1 after 'if (blocks_per_page >= 2)', > 'pnum' and 'block' are equal in this case. > > Applied, thanks! [1/1] ext4: delete redundant calculations in ext4_mb_get_buddy_page_lock() commit: f2fec3e99a32d7c14dbf63c824f8286ebc94b18d Best regards, -- Theodore Ts'o