Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp81677rdd; Mon, 8 Jan 2024 18:55:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjYbSamU75YjkK3MUXVKASyBqg45pJjEessSR/rlM1tZ8eAJaHFCmRoepCUR2V3pKniuOs X-Received: by 2002:a17:907:9301:b0:a29:b035:c7f7 with SMTP id bu1-20020a170907930100b00a29b035c7f7mr208498ejc.32.1704768905404; Mon, 08 Jan 2024 18:55:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704768905; cv=none; d=google.com; s=arc-20160816; b=JBX7VqBnJWuoFjnnAFituT5jsF+BjQiiZtPwo7vHAQ7T+IMU59GXycAJwTKj11fRTR jdkmnrkX8z0W5XqSQGDdoWpiizR43NJJK6OcPjhbNMIRRKa/r15Oklr4IjhBQmRoi8xv xJkzsLZp6K+a4VTgheWiE35WHcT8kM3gl4PDOVepN86xJMOyFXitAhjZo4Vpm+FnEpSL x5N5JXYCkiWCFrhD/lsPn3WSuguuBi44YRe7YOKdiUcqFyCkaymH2fpM5Q+JSqIJ0bHj gUTbZJ79abBdDBf9kF9R4s3pHWQoq0Ag0UQN8ISSj4ar8EuU9b5AVwtf6mBUv6BF1hv5 4IOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=wJjThj/L+4pgCgHHvQiPOC+bHviqX0aP3zZ61vZYdVo=; fh=a9ojchvKRswdtaEvKCUt1XHa3wp6xj3F9MNPV5xyRys=; b=LWCqon/Bk0D3mfxGcs2trj+bNPKDfq1Ewx8VQj/nv3Tio8aXLNhDlXHnwjML57yGHy 7eZk93aUFKzgqr+JWUAu4Syo9/v/GnsclxsJ5BJcOt4CKccJzzX58pZRB1fws3nG6ukz Hu+feXaoyLwRdFHaTIXEebaR9IDH+NHETdaqXv7zb5QwwM37n/yNCAl+ylUMeYzinbKd hzedQaPC8M2y7CxT+wi116ZkXA1B0c6jYs3cRGB9opGbDvwFr9KqVQIOBoW+9rpA+9Uj BXu6E+XTgivkZ+lVl5KxxnQXAPL0KWzUrxzI4tVwEr5s50syA5Ca0FtbXXRbxFmo4dV3 1QYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=UKQs21PK; spf=pass (google.com: domain of linux-ext4+bounces-746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-746-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cd18-20020a170906b35200b00a2750b90bfcsi426721ejb.175.2024.01.08.18.55.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 18:55:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=UKQs21PK; spf=pass (google.com: domain of linux-ext4+bounces-746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-ext4+bounces-746-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2CCC01F24446 for ; Tue, 9 Jan 2024 02:55:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7525C2555A; Tue, 9 Jan 2024 02:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="UKQs21PK" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F19C28FD for ; Tue, 9 Jan 2024 02:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-211.bstnma.fios.verizon.net [173.48.82.211]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4092rSal010558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Jan 2024 21:53:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1704768809; bh=wJjThj/L+4pgCgHHvQiPOC+bHviqX0aP3zZ61vZYdVo=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=UKQs21PKPdREzagjxkTcwFENudXslVFgXsnDyE1JAhNfHTC3WsPVwOzC6EUeB6yjL 8bibniuScvUGOysrE1HRrfMt4NJ0lse86bpy5a/H799LzcPEk8dU+faJDSu1HhBWJx jo3dLpXCB/uEGMJeNjVkl5Twh8BFhBuiouke9hwmPr1Xm2dSlMnp5emZBKezN4i+zr ICAP8SReRtmx0hy+9RTDa/kTKmtAx6GLP4dRZGi4dXnitvyvXw1uHGG9H3ch3//ysY nuCrdegkNaTVK8r0rWIw456g3c3UATr2lHXTAIrSzj0ONNpmOtvDOHyHsACwq1rjHD 7nZP3ACe8EuaQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 19C8E15C0276; Mon, 8 Jan 2024 21:53:28 -0500 (EST) From: "Theodore Ts'o" To: jack@suse.com, Zhihao Cheng Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v2 0/5] jbd2: Add errseq to detect writeback Date: Mon, 8 Jan 2024 21:53:14 -0500 Message-ID: <170476879011.637731.3198917367251947159.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231213013224.2100050-1-chengzhihao1@huawei.com> References: <20231213013224.2100050-1-chengzhihao1@huawei.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Wed, 13 Dec 2023 09:32:19 +0800, Zhihao Cheng wrote: > According to discussions in [1], this patchset adds errseq in journal to > enable JDB2 detecting meatadata writeback error of fs dev. Then, orginal > checking mechanism could be removed. > > [1] https://lore.kernel.org/all/20230908124317.2955345-1-chengzhihao1@huawei.com/T/ > > v1->v2: > Fix some misspelling words. > Patch 1: "fallen on" -> "written to" > Patch 4: "can detects" -> "can detect" > > [...] Applied, thanks! [1/5] jbd2: Add errseq to detect client fs's bdev writeback error commit: 990b6b5b13b7993b7f44740c0add3119d407ccbf [2/5] jbd2: Replace journal state flag by checking errseq commit: 62ec1707cb071c95706d1bab85fbee8d5a3d2f24 [3/5] jbd2: Remove unused 'JBD2_CHECKPOINT_IO_ERROR' and 'j_atomic_flags' commit: 8a4fd33d879fb303b207f06ea6340d73f698c4ed [4/5] jbd2: Abort journal when detecting metadata writeback error of fs dev commit: b4e73e61268903d82dacff2bc6f4bb766c6ed555 [5/5] ext4: Move ext4_check_bdev_write_error() into nojournal mode commit: ada3fb86a3f3aea40903d5ad9aeec708dc049b8b Best regards, -- Theodore Ts'o