Received-SPF: pass (google.com: domain of linux-ext4+bounces-748-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Theodore Ts'o" <tytso@mit.edu>
To: Suraj Jitindar Singh <surajjs@amazon.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, adilger.kernel@dilger.ca, jack@suse.cz,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        sjitindarsingh@smail.com, stable@vger.kernel.org
Subject: Re: [PATCH] fs/ext4: Allow for the last group to be marked as trimmed
Date: Mon,  8 Jan 2024 21:53:21 -0500
Message-ID: <170476879009.637731.2909208687184523548.b4-ty@mit.edu>
In-Reply-To: <20231213051635.37731-1-surajjs@amazon.com>
References: <20231213051635.37731-1-surajjs@amazon.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


On Wed, 13 Dec 2023 16:16:35 +1100, Suraj Jitindar Singh wrote:
> The ext4 filesystem tracks the trim status of blocks at the group level.
> When an entire group has been trimmed then it is marked as such and subsequent
> trim invocations with the same minimum trim size will not be attempted on that
> group unless it is marked as able to be trimmed again such as when a block is
> freed.
> 
> Currently the last group can't be marked as trimmed due to incorrect logic
> in ext4_last_grp_cluster(). ext4_last_grp_cluster() is supposed to return the
> zero based index of the last cluster in a group. This is then used by
> ext4_try_to_trim_range() to determine if the trim operation spans the entire
> group and as such if the trim status of the group should be recorded.
> 
> [...]

Applied, thanks!

[1/1] fs/ext4: Allow for the last group to be marked as trimmed
      commit: ddf2aa1bac7d9be3b8ba374c5bdb88da06e3e10f

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>