Received: by 2002:a05:7412:e794:b0:fa:551:50a7 with SMTP id o20csp81874rdd; Mon, 8 Jan 2024 18:55:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6GokhIQ8LyqlvBbqt0Qd1KsO8356wTSvYX52Qk/3PQDkO0cMErtF1fmvZAxIilBdTxDeN X-Received: by 2002:a05:6808:6491:b0:3bd:3309:a26f with SMTP id fh17-20020a056808649100b003bd3309a26fmr2406123oib.77.1704768945714; Mon, 08 Jan 2024 18:55:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704768945; cv=none; d=google.com; s=arc-20160816; b=UYDGVSAjkekj4yAIpYW0neRxivAhtm/c/1lVUW9f2OOrZmM1QYoI7YU8gooJcoUBEJ azk7VwBeaVi6awEhSefAFhnITgsJi0qASxQhbg/TmQK8h4WKJpNl0mSyAfye+ndgi/Xb efFVTsTz91j4yzdG4XqvlV2FIu/F0rnpmnYcDbBceEmHpxjiqrM5/KgK0HFl6xideO/7 0F7G+CsYR+gzc97mz9A9HkLAr0ZaUIoXIVfb92p9vYLy+5EW8bgsVECojZaO7EuXDPI7 KSXncDYdXwIVz7OEM/fxoTI55dTXRKrZYk8KscSMppzForF/IZtEdE2s8umFXO+0de95 Strg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=XCQxnqBSboJZiKMl447tY+hmTGpXedyOAMVXLwgQDCc=; fh=4t/NkBMNh8Pp33cX1Z9UBgj3ZpcPJixRAAtFBq8z2bc=; b=Xo+uaiMJI1Tl3Q7yH3qRKYTnjY/eTa90Ovg/HMoFhbn6yv443uOTcu3bKEfkrd/XFW znO/4of6OZRswnU6XO3/9/XSu0K+TRSHrPPlG53oGK6z5YU9YaLJ+EL2s0p63i2G2DFh efF/Zvngm0Vp12KpmI9Q+rDT0RrQiYxWdApAfX5g6DY+us0lIXpULr9hjtHaFDSCmX7r dJKegT8Ak9RN2pfFJ/vtERQyyIMH54T2/8DR/SzfoSDCHlku3u5FXTLVvWnHPb3MQbTl LsabjUcciIWk+l/SfsLd5h63O9T6C+wLdagZky4N55+vH2gTqVuM7X84EsEuLd5slSWP TWrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=PrXtT0cq; spf=pass (google.com: domain of linux-ext4+bounces-749-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-749-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id m21-20020a056a00081500b006da7d962a0esi754627pfk.123.2024.01.08.18.55.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 18:55:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-749-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=PrXtT0cq; spf=pass (google.com: domain of linux-ext4+bounces-749-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-749-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6287B285130 for ; Tue, 9 Jan 2024 02:55:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1234E29D05; Tue, 9 Jan 2024 02:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="PrXtT0cq" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51C2529417 for ; Tue, 9 Jan 2024 02:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-211.bstnma.fios.verizon.net [173.48.82.211]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4092rSJU010557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Jan 2024 21:53:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1704768811; bh=XCQxnqBSboJZiKMl447tY+hmTGpXedyOAMVXLwgQDCc=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=PrXtT0cqhvwmSoO+GvgYOn6F8TrqmVHujZHpsiwL7ulIrBEDk+vRnsJa5y8jVKgFY bseIDUjurPINbG1N82yLZaEVOIHNcBHLvxClCskWab2qNi/8vtGKPPAUw7vN+C9olM TffflU/ssphph9b3mhBA6I+7zu7LZaf10eW5F0pvDNZ/MPkm6rEAb+Dx76+SvTImD/ /EzHHbzGo9QuZX0neY6xWyECDBJszTiir3NYbRcasYMhJ/NPDsdipO/d5cOrujvBuu GJ95q9+NbmFWnVC1GViOSh6vXAcGTPoedfYHbmP5O0UOkOHhREnWwI6YmGoDOATmNF dCCTECBo5Q58A== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1FA0215C028F; Mon, 8 Jan 2024 21:53:28 -0500 (EST) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Baokun Li Cc: "Theodore Ts'o" , adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v2 0/4] ext4: fix WARN_ON in alloc_flex_gd() Date: Mon, 8 Jan 2024 21:53:17 -0500 Message-ID: <170476879009.637731.1586655538249198326.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231023013057.2117948-1-libaokun1@huawei.com> References: <20231023013057.2117948-1-libaokun1@huawei.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 23 Oct 2023 09:30:53 +0800, Baokun Li wrote: > Changes since v1: > * Modified the comments in patch 4. > > Baokun Li (4): > ext4: unify the type of flexbg_size to unsigned int > ext4: remove unnecessary check from alloc_flex_gd() > ext4: avoid online resizing failures due to oversized flex bg > ext4: reduce unnecessary memory allocation in alloc_flex_gd() > > [...] Applied, thanks! [1/4] ext4: unify the type of flexbg_size to unsigned int (no commit info) [2/4] ext4: remove unnecessary check from alloc_flex_gd() (no commit info) [3/4] ext4: avoid online resizing failures due to oversized flex bg (no commit info) [4/4] ext4: reduce unnecessary memory allocation in alloc_flex_gd() (no commit info) Best regards, -- Theodore Ts'o