Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp546261rdb; Tue, 23 Jan 2024 07:26:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGD+y87CcBJ2Jhu50IWk9E1ihaVE7bhnAmRKDjU35npmnmgabMiufc5jx0xoaOjyGTSl90H X-Received: by 2002:ac8:5705:0:b0:42a:4b35:54c0 with SMTP id 5-20020ac85705000000b0042a4b3554c0mr1151045qtw.62.1706023594385; Tue, 23 Jan 2024 07:26:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706023594; cv=pass; d=google.com; s=arc-20160816; b=hhBfMKH/Q+lvPr2gIEqUbM+SKwHWjAS1V8/eQobbiUt7UwUYd8+/6oR4rQLcjH2uXE 2xs23dVzOWVN6al/QUYQrcg7rJIcpQjeym0+VOzNMgpEH4iMIwOaKk6LwxP47TcVmeo1 i8QhXX0w1k29LRV9ShdHqOlyNfyfQL9q1C3hFLVX/l0XWJXrizryi0ZRmUwG3px27JJv tiqVHONBO7YezBhFSCyjAPmaELEfTt7pPQgIwf6DleA+1IcVDqmojPyP0N059Vo37KAD iXnPCNqAvldQOEraaWWbxhldcvH/SiV5qarILZIu0/UYfiIC9vq3+ZGxlVD+pRbsvvL1 Xj6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=VwCAMufR7GUSs9UGpUmAZb9QF/BRRq2SmaaN3jQUOuY=; fh=qXaivh2Fa7d3K+n0GuvghyA0j4Zb6rNWiQ6clbur/Lw=; b=bBYj/L8PSRb0sHs8UetWhnhq5RWojWR4RzaQFxPNmv7iCvN5boKh2EiOTSKui19+Le MTto+hSyDXrIs7ftT4yXsn6lNdNqOmtgOyP0xRcOmgSk5GI4101JwWSUk9ztukmvAzgk 6rKXJDskgIjrxy7Trpa3pUgbNWauM22zE7mXzST1mo5VO0GglbvxlLhcJI5bpJ+QacTQ 85Qi8/rI/V3daleie1plCpxfOtGGOHVW6jMRQzh3wF17B6IQdn9IaVpbT9oyFKWuIQoi j/PvpEsiP5KA5ezollaSytcw8o9UCiDIBLGegDTWr4PVK+QwsUIjq+YgDvq5MkLL+qnw O86A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Aw+gU7f2; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Aw+gU7f2; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-ext4+bounces-876-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-876-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 20-20020ac85714000000b0042a4e0b2e4fsi1701431qtw.250.2024.01.23.07.26.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 07:26:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-876-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Aw+gU7f2; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Aw+gU7f2; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-ext4+bounces-876-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-876-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B499C1C23990 for ; Tue, 23 Jan 2024 15:26:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EDFE2604B6; Tue, 23 Jan 2024 15:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="Aw+gU7f2"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="5HIWDf39"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="Aw+gU7f2"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="5HIWDf39" X-Original-To: linux-ext4@vger.kernel.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099795FDBA; Tue, 23 Jan 2024 15:25:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706023532; cv=none; b=F9CUz9XQlF0G0sYQtS3faVOPUBqy7iRH875BBur1hiLTHnQ8gaJBbya4/VHPVwE8b+mQFrTUyOl1CcrjXzkRdHEqNMxSoWwo1x2KZ6gX93b+guhNynZw5QWoJWHt6HEqCBbmBYtIHbSFCMsr1rVy16tcF47+9+4SgxCzKluoAOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706023532; c=relaxed/simple; bh=RMRnku4DuNfv2uoJ9TsdDQxPnVMzxFjKpiFLO1B2l0o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=t+R1liOyASrlSAlamsc6ihBmYEX/ldqqd2u+XI6nZXl9vRvJ3cN/oaeVeSq+mCu1hl0bZSNf6pey3u/gTSIrh1y3rtUweI+rzNoUCQLMqiR17UXntr6qf4Usp6TIoziGdZN/V7H8dOBTWxFErq6XNYL3BNDJqose6S+wNvmcwvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=Aw+gU7f2; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=5HIWDf39; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=Aw+gU7f2; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=5HIWDf39; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0EBE6222D9; Tue, 23 Jan 2024 15:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706023526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VwCAMufR7GUSs9UGpUmAZb9QF/BRRq2SmaaN3jQUOuY=; b=Aw+gU7f2c3fhZRvNADuKp3PYCG35dfvLDe/z1npKj3u3n+y/kUAu4n962l2LGP8AZIZXk5 MWyD2IXHvDMC/CrYccGK5dyICZLTd+8QLencZVMAFzkzaLyl3XLKJJ9jkTlghPf2c8ss3r nK26ALNBmsn46pFl1erTrStnCx8XNPI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706023526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VwCAMufR7GUSs9UGpUmAZb9QF/BRRq2SmaaN3jQUOuY=; b=5HIWDf39oRhigExMDw9RVp/QM/SxxB2Ee0plOupxYA975EqgkvF0Raeog+uBpQpAmqS5eT HqqLiMkjUVCECxAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706023526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VwCAMufR7GUSs9UGpUmAZb9QF/BRRq2SmaaN3jQUOuY=; b=Aw+gU7f2c3fhZRvNADuKp3PYCG35dfvLDe/z1npKj3u3n+y/kUAu4n962l2LGP8AZIZXk5 MWyD2IXHvDMC/CrYccGK5dyICZLTd+8QLencZVMAFzkzaLyl3XLKJJ9jkTlghPf2c8ss3r nK26ALNBmsn46pFl1erTrStnCx8XNPI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706023526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VwCAMufR7GUSs9UGpUmAZb9QF/BRRq2SmaaN3jQUOuY=; b=5HIWDf39oRhigExMDw9RVp/QM/SxxB2Ee0plOupxYA975EqgkvF0Raeog+uBpQpAmqS5eT HqqLiMkjUVCECxAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F2CBD139B7; Tue, 23 Jan 2024 15:25:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BQZIO2Xar2WsdQAAD6G6ig (envelope-from ); Tue, 23 Jan 2024 15:25:25 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id F0A9AA0809; Tue, 23 Jan 2024 16:25:20 +0100 (CET) From: Jan Kara To: Cc: , Matthew Wilcox , Jan Kara Subject: [PATCH 5/9] ext2: Drop GFP_NOFS allocation from ext2_init_block_alloc_info() Date: Tue, 23 Jan 2024 16:25:04 +0100 Message-Id: <20240123152520.4294-5-jack@suse.cz> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240123152113.13352-1-jack@suse.cz> References: <20240123152113.13352-1-jack@suse.cz> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=813; i=jack@suse.cz; h=from:subject; bh=RMRnku4DuNfv2uoJ9TsdDQxPnVMzxFjKpiFLO1B2l0o=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBlr9pQJmDbkzCzGSmAMW0KWQi6FDNaYVtnGwXb4B6E HWHxX8yJATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCZa/aUAAKCRCcnaoHP2RA2ctNB/ 0egt/sEM8nIS9SVaDlUOXhuOVW3S/6O2CWuLqFq1pW/ZEnANb8XtPX19CKyaU1J/m3OW6XgxRYnnz4 hMMs47xMuRaUsiQe2f5WADAezJQHd87BGdGxbaeUUGUvi+3SNGxqhfTKveutFu0le3R/Njmv7vAr7O AX4g2aLRSTcJuBz+MtW4M6cD7o2DbDULzicHTeqkXlPlrMuF3nxr9mA9I9sRVcW/I3f979uMNMXgHs KF9fGuIXgR7aZd/jfI+9sWrFw7u9UwM0o6AQc4CS0IFndZ7MeHOt/uVX1WbLsEaAi7aOfx0f20lniw 6dF/Le68v7bBTgyhn4jWc2pyuzn6rG X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Aw+gU7f2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5HIWDf39 X-Spamd-Result: default: False [4.69 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; BROKEN_CONTENT_TYPE(1.50)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.cz:+]; MX_GOOD(-0.01)[]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[35.87%] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: 4.69 X-Rspamd-Queue-Id: 0EBE6222D9 X-Spam-Level: **** X-Spam-Flag: NO X-Spamd-Bar: ++++ The allocation happens under inode->i_rwsem and EXT2_I(inode)->i_truncate_mutex. Neither of them is acquired during direct fs reclaim so the allocation can be changed to GFP_KERNEL. Signed-off-by: Jan Kara --- fs/ext2/balloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index e124f3d709b2..1bfd6ab11038 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -412,7 +412,7 @@ void ext2_init_block_alloc_info(struct inode *inode) struct ext2_block_alloc_info *block_i; struct super_block *sb = inode->i_sb; - block_i = kmalloc(sizeof(*block_i), GFP_NOFS); + block_i = kmalloc(sizeof(*block_i), GFP_KERNEL); if (block_i) { struct ext2_reserve_window_node *rsv = &block_i->rsv_window_node; -- 2.35.3