Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp863418rdb; Tue, 30 Jan 2024 00:13:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IElPTRCceID2EZSRKqLh09gUbczKNfWskee9nHGKiii11NhoCMjaxkords1pWPjfN+FqnwK X-Received: by 2002:a05:6122:c90:b0:4b6:e73d:71e5 with SMTP id ba16-20020a0561220c9000b004b6e73d71e5mr3770436vkb.15.1706602419836; Tue, 30 Jan 2024 00:13:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706602419; cv=pass; d=google.com; s=arc-20160816; b=J6cgSCBtBOdsc8GfFa4iE36eZ7PdnGtE7yCW9/rb5D/NcOTAqb9FQL/5w3gtmprhYD O/c2XQN4YvmqbRClXOKJSXVk2aOeA9/9FfkYMbl2XvTIL+tYWP5d/tq4+5/CEhFiLaPb EiVBRP2l//SNxXo623IsBE/2JZKL2LCshydmRqsyW6zUuemOvURj+NTPBbgwqsuUz3D8 waXon/RdXo6uygQpzpzldTsRSz63VY09ezOoAUhEIT8uaRA2/2EkIDO6NG0DAbhIdljI 4ud5E0rHdsZ7DyqDHTFd0JdENfAt0h7Kbxy3TL9P3c2LYQGCWFthTfVOBQpe7yJ5bCB0 hNzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=DuKx+sfajxEqWzuyC07xlt8/JtAA+i5eB8wbk2tchGM=; fh=Dk305f9xd/mXvI4Xk50RrI85sYdneBYagoj2h78w+Ao=; b=wXuu13C6UdxZ+YVNxTTGdijDNR1wIWefPKxouNyeeywuHRPyVI7b9Yqtv/cOrFgBGU h1GTrSjN0LHZbISV4COlJp3Vu5CWQ4X8WY+l46lheJZF+vZO5hZTx20IbTTf+G5fXmBe D387PoohtwLo+1tmZMubHufaR6A0tAc68PBBfZOvHnbUwUYJYT0Wn5cYAJl7akpsoIfn Om9Ge2ahHdsw+y14UV19SZG8TGEtTx943mJBaSpMLs8mMR0eeYo+RkuhtFWl1pOdybIC 9AEMzA/Zc8m3OaQZ9G4m/Jzf+6v83BnlSQTombByhqi90l3F48/nUvB6kH3kwRqK+avt uTgQ== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-ext4+bounces-1022-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1022-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id a9-20020a05620a102900b00783f802af8dsi4940583qkk.160.2024.01.30.00.13.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 00:13:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1022-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-ext4+bounces-1022-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1022-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 968921C24BE7 for ; Tue, 30 Jan 2024 08:13:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C71F854F92; Tue, 30 Jan 2024 08:13:31 +0000 (UTC) X-Original-To: linux-ext4@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F19C254730; Tue, 30 Jan 2024 08:13:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602411; cv=none; b=qHxlMfGL08jQ/3HCHehQ4algUjfl6TDNMg/Dv6lQ+8cRXfyarRG52UB/2axgYeohewDirNsCtClUPM5igJdy18Woj9zS6j+oKHlnfkpB/9jl8OVtvhNvoTInZKp+NO5C4i1rq8ltClMqRq8i1DVQtOxrJtEbNZudX7sh7E4dkXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706602411; c=relaxed/simple; bh=H9Uzgoak4i6LUsljZliictwGDjYmDADI3JxrR/uu71w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qCFordJfAbkxKvPQhCnr4cZA51bl1bWkwbzQnNnHMMv4lkIWDJX1krawbEml5uBmnSwU2c8pRjdJJkc9ForVk9Gdt2sk5ECCRR/Z0Hh7ctkmXaClvSdLNX6VAyj8Urgcc4DlPiGnOzeIreruX2UMKF7Sri1meI5xhPQXxwtqEBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id E3FF368C4E; Tue, 30 Jan 2024 09:13:26 +0100 (CET) Date: Tue, 30 Jan 2024 09:13:25 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 3/3] ext4: Convert to buffered_write_operations Message-ID: <20240130081325.GD22621@lst.de> References: <20240130055414.2143959-1-willy@infradead.org> <20240130055414.2143959-4-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130055414.2143959-4-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Given that an ext4 conversion to iomap is pending on the list I wonder if this is the best example. But the conversion itself looks sensible to me with the fixup.