Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1529666rdb; Sat, 3 Feb 2024 09:57:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/F/hjJ2XEm1nV+m8kVnocort8z+9HoCn93On7yrRtvDzjXNtIlsKO20Ic1/YrPHSf1QlS X-Received: by 2002:a05:6a00:b0d:b0:6da:bcea:4cd4 with SMTP id f13-20020a056a000b0d00b006dabcea4cd4mr2378884pfu.16.1706983057209; Sat, 03 Feb 2024 09:57:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706983057; cv=pass; d=google.com; s=arc-20160816; b=Ggu+6CNzzQo/iGNWM4ChAOxpSmp7kTK9gWYE+Z1/QDFa4XAPEmjLO4FFXR5b3b+eOq lwvKAnHSsba327QM3+PdvLPHKCjxjDkV3+bz7I4tia9nUj8QZApshogwVCWioBV9JdLZ wI3y04TnUGRDuLf7qwXS94HisDJcbgpUaFyGnv+qrbjCkwBohUCwdMqghw1R0q2xeTdn /qpbVOceZLUDi7iBKzpWQ9E8I0ZHaXeWMuD5i9MVhJfcLvSjPQXBWxKVFYhll5EPiNXd h9a1Gc3Ejy/5pp+H1C3WaN/bk94bN7FscS11ayaaDksT1BZWoaqxDFN9K2Nf4y0s2jXR t8pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ykOOFay+2IfEzshY6L1t7gF/goIrR1N822e2+ESCJlU=; fh=Dfp9MEIyXmFrckFaKlwFUMOtcg+zUEi/UkoQVpcyNGM=; b=qJH5wpCOzA/OhoBgnGz75T1opyEYIKN+28e7QLTT4AZ0vc0ZlboELJpUUgWigBXC9h SS52eB4TX0BNXVV+g1lC+HdF900pAEkQLgKZ9Mugrs/S1+geOUvJWehx4J/I0KvMlEmH 2bC8A2Rj86y5chktPTtvsPwB5ndPe5lG9UzOzXH8Y8+yJJJYyVnxtA3C3K3OV+zJJHbK cSfzWPNA0PlEukmypP2E7Jtxt6L8THlvgT54oa3wT8HR+xrTFcmihzNRYmVzbWLk2cKf gtO68kOLg/hxlqSACvg+flc8MaDbPzAGrZv0zoRt4qQ2sPdTx0iSSWb4gsSuxtVE8ck9 1UnA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b="Vk1L5/Vf"; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1071-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1071-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu X-Forwarded-Encrypted: i=1; AJvYcCUJG2MgB8ZgYvJgI03khfKH2vt88mvonA0Xw2tSZUJSsJCdDrRiVpGhViZfHxMY9kZdm8CVGWs5o8+jxDofwEaH5ih6+yoe2shsgWUc4w== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i26-20020aa787da000000b006e0387c3aedsi107284pfo.52.2024.02.03.09.57.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 09:57:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1071-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b="Vk1L5/Vf"; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1071-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1071-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C6216B238FF for ; Sat, 3 Feb 2024 17:57:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2CC125FB9D; Sat, 3 Feb 2024 17:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="Vk1L5/Vf" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23DA65F554 for ; Sat, 3 Feb 2024 17:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706983045; cv=none; b=JlPFVmoCN/JBHsl0QExo5RX600escvmPBkh5v/TUsnCRDVjPyhSquwF/2e9hfvbfP1MLa1awSHKVi3WfAoZIxq0698mJXYawiN4bGrv9oG89WvlZDvCYQcAZWpp84aTkS/7KRUt053d7mdppQE1UNJmpm5cM8e+Uc9gWlxysglw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706983045; c=relaxed/simple; bh=/NQk2cDsc/ggDqxAIYb4Sdq12gy7QJZdwvsLLQDIuG8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TT1tj3KPuL3xkJIZYVvyGZE6YvkTvqrc4pfLYpblx7z9zkoPF/8+sRTEFwAjPIJtM+BNY8odJnA9n0nWOggLwXyyrtXqypiNLK1u3gPuFGFrY1G2oPqUx24QFx2BboiP3KwbX5Eg+ZEL8Hr4+BhyoUTirIBExkhyAQwQTvgFmDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=Vk1L5/Vf; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-236.bstnma.fios.verizon.net [173.48.82.236]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 413HuClN016639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 3 Feb 2024 12:56:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1706982976; bh=ykOOFay+2IfEzshY6L1t7gF/goIrR1N822e2+ESCJlU=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=Vk1L5/VfsKskGJpf6kj1FqSI9spLbmpo0OMN1uZCsa+rUQuM5qtPiLL5y1W/fhAYb cL45+7C3/Wgh0+dxd8RotJLxAIJFHDKvba4KAtEX92dq9iauIz06YXfMvET9IyUu9K A3udZQcY3yEOdAHaa0EkgYWPMS9kDP3J6lLRiu7Bs8ooGv3TeuKzmp8yAL6uqpFxwJ 4uMfnpKu1mHh1UIuw85YTTQFGyevCVd94MkBio4d/45deq0m+e8Aet2M0RiSvjzVyu Xy4OkJPUfrKx8QTGJ8Oj7rist3+Uye/a3AuJRQLeoMWFtnoAcQlxCIrJwUO3N66NaC HjWRVEWLx0aTQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id D733315C02FC; Sat, 3 Feb 2024 12:56:11 -0500 (EST) Date: Sat, 3 Feb 2024 12:56:11 -0500 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 01/26] ext4: refactor ext4_da_map_blocks() Message-ID: <20240203175611.GD36616@mit.edu> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-2-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240127015825.1608160-2-yi.zhang@huaweicloud.com> On Sat, Jan 27, 2024 at 09:58:00AM +0800, Zhang Yi wrote: > From: Zhang Yi > > Refactor and cleanup ext4_da_map_blocks(), reduce some unnecessary > parameters and branches, no logic changes. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Thanks, applied. I've taken the first six patches in this series since they are clearly bug fixes / prepartory changes for the rest of the series. (There were one minor patch conflicts that I fixed up.) - Ted