Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp1530122rdb; Sat, 3 Feb 2024 09:59:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IH21sUpY6W4uNQXxQIaL4Bdf2vHL98a0CAofGEd7OWra2YgX8X9Vfk2W9qcGJq8n++fUpzZ X-Received: by 2002:a05:6214:cc5:b0:68c:4e10:a713 with SMTP id 5-20020a0562140cc500b0068c4e10a713mr3277045qvx.17.1706983157101; Sat, 03 Feb 2024 09:59:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706983157; cv=pass; d=google.com; s=arc-20160816; b=eTtbn2JMdTz7iJYvqT2wpP+SOWSDTC4VQWBSn9nmEkwZ7XQokpIUP7lU52zGDGUX/0 /7DLlzl5uMUA3IHJuCokKu/jIam+JCPe/ahwOXNAH/NUVXWDGlKe9kEsCajv7KVg2zYg bYZIQwshtT/fsW4lEDR9QG2qchRRTmqkAWZ+CY8T67ZCnZbMqFuTGPhbdqWrAxDNqYC3 pjZ+T7RJPu01CJBY5hDvXSElZVAwscvemDW7wYxn0gqlux41rQUvvvX2JfdSBgI4XqXd zYZ4rTmuUaFEmBLhV4nOdR9vlKsMQkLEwyrh9naClK4XNNWUHca/Nc7XIlPvQ9pvAnvx r8zQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=99dxy2PFAEd7Ric/sKT9cxcAPUbPHecGHYu/LOqgnzI=; fh=K1eom8RX8Jbu0PT7R6pOoC5akpnniZwmB4ozCLy9CgQ=; b=cSzi9JrHjxOwVQ7fZxNOilPrI3vi7Tl+1Aa8HVjfC2OhkOi7HxINKAQrCtGATq8zj8 wLc3KqupGI4CkO5EEK6eSkP0JiwSaiqU6z0hXue6Yl3rOb8RIk0kW0AqXKXT8EBzuF7H 9Avk0YeHuWlaY/nzWZ9fG0WChGDHAPut4Up8Xzhm8zxSegrkujizmu+DQ4MiCTWRsD1I N73A+LC8Y3sU4k153WHGPz5t/Nq7LqQkPVndvZ6QPvZPeEBDZMnBLLgqqQP80rnm32E0 4FY8OvaGTytyr43FdEi4QV0r73NWAo32nPeqcBC9J/qsuSYGPPsIo6L/5O9GiENTm1RD ZgBw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=SSiVdQgy; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1076-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1076-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu X-Forwarded-Encrypted: i=1; AJvYcCWMZZbzFWf2eCqrCpr9vecBPl5in7lvtVw5wKIxeFK+GHKoLlZkMBvF+qM71P6hjJqv14EjtjTyQS3CM/vgFnL8XsCX2vR/rjk9ppFIqw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u11-20020a05620a084b00b007855ef7ed20si2823497qku.411.2024.02.03.09.59.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 09:59:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1076-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=SSiVdQgy; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1076-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1076-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D65511C232E3 for ; Sat, 3 Feb 2024 17:59:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 70F475FBA9; Sat, 3 Feb 2024 17:58:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="SSiVdQgy" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97ABE60ED7 for ; Sat, 3 Feb 2024 17:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706983088; cv=none; b=Pm7iF5bQip/mwz0gWYb8w3JfOOaoBgB0INuj1BEm03i8uUIHuJANS+wFoYI/lbJrQRaS49Oht1tlNxc/7BOAVLUENDs118agkgVy5iBJXNnmHq0iIO4zw4itBFZ/bK0RPWugHlsQrPTdNMqDrpbY/JMlvciNG9oE4wdLHIgDTsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706983088; c=relaxed/simple; bh=5+XzlAwnVCFv70Ro0EjvOwnKj1A6wybqH/l1KAjYwRE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JzhpI9xfoDo7KTk5C04ClhfXGGbORZLA98vQfK2eOJ87LlI5324Yf4ovDbbLNgaET/IRxKdQaoCnh1ekoVzwLpS6d6RXrhx8ZIDSnCgvjG+bqpbmnLEN+r2NOap009f29jaPKKD8Qq8hLbEOH8RdgP76z+mqByz2HCENp3CxdhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=SSiVdQgy; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-236.bstnma.fios.verizon.net [173.48.82.236]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 413HvSjx017208 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 3 Feb 2024 12:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1706983051; bh=99dxy2PFAEd7Ric/sKT9cxcAPUbPHecGHYu/LOqgnzI=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=SSiVdQgy+T3CGwQlxhTgGe+KTMtd3GMBDDA0ppa6jXfL2WsmsfVPMQRezrSvtqcqL eEcVfIGsSL6XNXvnt8vMxzHoDkPUFUOHHq2wLqe1BsASbU736Ko7lRHNXVt+UECGhU BA1euK/3icFNIgYc4x4/uHB2nLhVL9lwo+0R/BcmIyqquwT8dfYi2z32KW5YbX5KuT 6Wq+f7hnSTXpi3kN20vQvqsPKq2YBW47DRM/4mBoEi4aMDwGRWX0dKdXPnoAjAN7dD QwEsVu18cNa691rlaR6nK01ikJx/aeAgQcba3yz0GJn8yGC4cu4pf4l6UlTLW1RE7U 9XeVlSstdb0DQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 2482315C02FC; Sat, 3 Feb 2024 12:57:28 -0500 (EST) Date: Sat, 3 Feb 2024 12:57:28 -0500 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 06/26] ext4: make ext4_set_iomap() recognize IOMAP_DELALLOC map type Message-ID: <20240203175728.GI36616@mit.edu> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-7-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240127015825.1608160-7-yi.zhang@huaweicloud.com> On Sat, Jan 27, 2024 at 09:58:05AM +0800, Zhang Yi wrote: > From: Zhang Yi > > Since ext4_map_blocks() can recognize a delayed allocated only extent, > make ext4_set_iomap() can also recognize it, and remove the useless > separate check in ext4_iomap_begin_report(). > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Thanks, applied.