Received-SPF: pass (google.com: domain of linux-ext4+bounces-1231-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Andreas Dilger <adilger@dilger.ca>
Message-Id: <4AC7AEC3-25FC-4147-9C62-2CE5A1686199@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_B704EF62-C594-4F51-9EC4-2B34EFFEB9F3";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] ext4: Don't report EOPNOTSUPP errors from discard
Date: Wed, 14 Feb 2024 16:01:57 -0700
In-Reply-To: <20240213101601.17463-1-jack@suse.cz>
Cc: Ted Tso <tytso@mit.edu>,
 linux-ext4@vger.kernel.org
To: Jan Kara <jack@suse.cz>
References: <20240213101601.17463-1-jack@suse.cz>


--Apple-Mail=_B704EF62-C594-4F51-9EC4-2B34EFFEB9F3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Feb 13, 2024, at 3:16 AM, Jan Kara <jack@suse.cz> wrote:
>=20
> When ext4 is mounted without journal, with discard mount option, and =
on
> a device not supporting trim, we print error for each and every freed
> extent. This is not only useless but actively harmful. Instead ignore
> the EOPNOTSUPP error. Trim is only advisory anyway and when the
> filesystem has journal we silently ignore trim error as well.
>=20

> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ext4/mballoc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index e4f7cf9d89c4..aed620cf4d40 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -6488,7 +6488,13 @@ static void ext4_mb_clear_bb(handle_t *handle, =
struct inode *inode,
> 		if (test_opt(sb, DISCARD)) {
> 			err =3D ext4_issue_discard(sb, block_group, bit,
> 						 count_clusters, NULL);
> -			if (err && err !=3D -EOPNOTSUPP)
> +			/*
> +			 * Ignore EOPNOTSUPP error. This is consistent =
with
> +			 * what happens when using journal.
> +			 */
> +			if (err =3D=3D -EOPNOTSUPP)
> +				err =3D 0;
> +			if (err)

I don't see how this patch is actually changing whether the error =
message
is printed?  Previously, if "err" was set and err was -EOPNOTSUPP the
message was skipped.  Now it is doing the same thing in a different way?

The "err" value is overwritten 50 lines later on without being used:

        err =3D ext4_handle_dirty_metadata(handle, NULL, bitmap_bh);

so the setting "err =3D 0" doesn't really affect the later code either.
What am I missing?

Cheers, Andreas


--Apple-Mail=_B704EF62-C594-4F51-9EC4-2B34EFFEB9F3
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmXNRmUACgkQcqXauRfM
H+C8eRAAjGZln6nX+nfX3THOmJ6QSNO4b9k8MmbFYKbY0FRXroS9b1S4zjOSYVy5
JODdoeBEWnYwqH2Gtz7KaQAn/SsGnSYhlFfwB61H85sLD6Vw0zggOCySByRHx+HP
bLoJuMmCGcA0SZSv/l94/zsHXjrnMhIrDd2DU+hLimcee8X71u9ExwE2DuR/44jK
7NQIWJ+cKwBDNvZx2ioV3J/Oz9kvARc5gssM5jKCIkiCFmPBZs14uBxgEKTjwdqt
VHQVYrBj3YruLZt6MLASkHAMrVAwMwfium8VqOrii/hAgQfPHOIg17fP7m+2mCER
Lj94CL40nGfzGKLmfqXOE3uDPLz7NAFb48l9uVQGWoR7H2FSpp/YITa0KCGNTF+X
lwCBtVGPESs9HxeiO9XCy/Dgj1ZFLq36kNTcQhkWcOr+pAHJdKlnZIWP2U++1yCW
w3DVEDea8XCOkrnXIJ8LGM4B3/RTWp/khcRKfV7AfBTGqzKFxUfq0Yl4k5fZwf71
AyCxYyjXF3Am3pG8LzNCyGpYW58vuhgWK6uVVyMGVkl80VDnF7Q7lYY7do9eo3x/
W6i7vW9JoevIF7AiZ8FNjHRQ+KNwZl7YFUWVWjAVgRvftgpUHefaHI9LpR7S5/jb
qImY6Am6YxFMtwIRcuy3075Gs0H4fshkKj/1dUIMLI91ub3ngTA=
=4z1W
-----END PGP SIGNATURE-----

--Apple-Mail=_B704EF62-C594-4F51-9EC4-2B34EFFEB9F3--