Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp551902rdb; Thu, 15 Feb 2024 08:04:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUrHXbQ6tNBb7/8rXpDtlrYndkbujvOLGI5doxr0TxDYzPmrtzHwfEhujjNO0WRFbp1rR4pDqPpPUZNxjuC2y4yRGy2NX6rzcIFstlCAw== X-Google-Smtp-Source: AGHT+IG09sM18ARWP+r18VPbdQgu/6Dem+fYxv0XZeD+PoS7rMiBFFAw6FRqSvL5lSMZVC8j6+cQ X-Received: by 2002:a05:6a20:d808:b0:19e:cf1a:5369 with SMTP id iv8-20020a056a20d80800b0019ecf1a5369mr3490000pzb.24.1708013099602; Thu, 15 Feb 2024 08:04:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708013099; cv=pass; d=google.com; s=arc-20160816; b=Xe/ipaiscF8Ob43Wzxsh56O7EfGAbN8pf+APUV+r0yEcGcinZq2lzphvMJKE0u89Ce k9MdkAcfrlLYzWa/Esl6NQqxBIYyxWSW61DlOxCsi0v32jHQvb2iWMYffCC+YLDv1+gN v4YzOVIJk5oNmwfNPyoItXRkEnk78M7WhCSwjeY/Rn+lg3ABvZgbZHaJXPsRFQCvvemb w377cXOAN+CX9QaIErdaL+VT/BECIoWD8FdhZ/1tlC1oGAi8eridNxTMGR/9qVfJLOqR 5+bCo52zGEOM5My9Mf1kehK3lTpoEULX3hZ+hn0h94XNxzW+hDdZYQkLChD6/CREKwst VBDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ziNCxk5Fw1xseh3Sg36UUTITDZiH/WcD0CrZmgDMZk8=; fh=b2xXmU3/DpBXDRltlmmZ6MlIvpwnGkzVnoB3PmyjVq4=; b=JuGtHnrggCbEJJpfaCuvYZ6Vf5uQvaAmo12xLN5gXiRBS2cSXCbXAG+keNGYNWWPMq NvCFHPHARKXlI1rMAOT/9DPy9ZXX1mYf52d6dDdaHxiUhIVi5RftlH39WR+DA5KfipCv jTXocbt0LnuiuIgGv2xRxQBSgJ/Fv1FM0X7OSS1AAp9I3iq3cOjbMaszrS+ivsiCmmET ceht9gqzQd7PTPGw7EIeUwRlL/zjLuAW6Aj1jMjFIiRp/5esMnHod/qOu5ONFAtybzt+ pjRbf916qA5amfWRy/vavlCRKZW6zeb+bwuRqMXWCS8QT2s6NY6SzqQIWBpGJZhGKrPm oKAg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=J64dugUe; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1250-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id n7-20020aa78a47000000b006db05fad13fsi1313403pfa.380.2024.02.15.08.04.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 08:04:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1250-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=J64dugUe; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1250-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 96ED028F269 for ; Thu, 15 Feb 2024 15:58:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 87AE6133982; Thu, 15 Feb 2024 15:58:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="J64dugUe" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463167CF03 for ; Thu, 15 Feb 2024 15:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708012727; cv=none; b=UErDM3TdZtRB4CGyhVZR5brqrv7o8QZFLWYZxtNDwRo6ioKeE212SiSYRAefalCjp9AS3ZyoGD/Nk8fWm5YK+dQ5m6jRiYKDY2oj/hZlRMOMNVPEg9+Fbn3AMntwgVLUvvqTCzALPkQcAmLhYc6SL0sXcbufhKQgjewoZQzNmbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708012727; c=relaxed/simple; bh=eIsU37tYzInmaHRipq7y9TWJ/HG2GIdzgAvYwREqvvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q13lxbO5WsoxYxeYb/s5mJNGzqRFv6fB89UiQUd1nfWbBnPcq/pFq/MLxY+Z3mwnUcAxBeOAo8Eao2ygyzrGblL0qPeoJ9oEpUCG3OwIApBCnpaibhfQuRz5gSh1ygChtcrw7rP0SVN06do67yQJNOk2QbcgXupOupK13uRBD2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=J64dugUe; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-116-68.bstnma.fios.verizon.net [173.48.116.68]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 41FFwJ4d024827 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 10:58:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1708012702; bh=ziNCxk5Fw1xseh3Sg36UUTITDZiH/WcD0CrZmgDMZk8=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=J64dugUeVimZIU7EgjMHLBa0xUOBfXzURaazQa5AZlEVhrxxdypWsYkNT4Mcg8N14 oXACta8kS5qNfNoB1tJV41AiC4JoGsPNFJ+Xkr4dKmJezHwrV0sVNLz4YVbFUw2nms 5Z6zrXpHsl0WLfLBCcUITb3sB43Fu+WIxD/ayzMnmZcs8gOfxfMxtpXvIn7GJcjvRR k3ZJ6USmASk7MBU2unZE7/sqy8jsIniuZLtZpsWdXHG4urAidvCx+Rw+yDu/lLHVsD Yqf8l2HbVPWdmeErbLKjM50MOyE3Rqx9VvhJAQyCxSGm9EJDFZndlTd+ZWpB7BGH0e kGn6jZ9jDe1dQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id AC38215C0336; Thu, 15 Feb 2024 10:58:19 -0500 (EST) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, jack@suse.cz, yangerkun Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, yangerkun@huaweicloud.com Subject: Re: [PATCH v2 1/2] ext4: remove unused buddy_loaded in ext4_mb_seq_groups_show Date: Thu, 15 Feb 2024 10:58:18 -0500 Message-ID: <170801269220.557465.8141847571506704045.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240118042557.380058-1-yangerkun@huawei.com> References: <20240118042557.380058-1-yangerkun@huawei.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 18 Jan 2024 12:25:56 +0800, yangerkun wrote: > We can just first call ext4_mb_unload_buddy, then copy information from > ext4_group_info. So remove this unused value. > > Applied, thanks! [1/2] ext4: remove unused buddy_loaded in ext4_mb_seq_groups_show (no commit info) [2/2] ext4: improve error msg for ext4_mb_seq_groups_show (no commit info) Best regards, -- Theodore Ts'o