Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp423953rdb; Thu, 22 Feb 2024 07:55:10 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV8twed62mQPxJS4n7MsWFj44ttIZs0nZWProOELp4LAkxnF7r+phNhw/zY2r63c05cFNaslodL421KIp6IinC6YgAttn0OeCZXUQ5mpw== X-Google-Smtp-Source: AGHT+IFwSiwDPjmsh/vvu8D5jxjvSmb5lDDBWpD1rj7Kx6oJn+uObZNbMXyulN4f8GnK8EN1GNWQ X-Received: by 2002:a9d:66c9:0:b0:6e2:f24d:697c with SMTP id t9-20020a9d66c9000000b006e2f24d697cmr24463914otm.11.1708617310464; Thu, 22 Feb 2024 07:55:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708617310; cv=pass; d=google.com; s=arc-20160816; b=K1VGKmq+fGqYsY20zdJTrimD7lKePqwg2sB7XY9xZvss+TBZqAnxrPJ59k6resMCBS PhHT/meJalhHA1kGp712xyZmktLPCTZipSmBsOf+fZvxvtgEk2UJfnBEX8hTDxKJQqLO WJTq9cVvi0Xk6Y/TvwVu2SgtYZb98NXeUjKyfVZkjSVgMj1yci5yu4D8L1wjVfTInTWf AY0Ib+K4OjF1gIczNBk384ib/oWEUYrD8Ivjty72oT+d/FyMhp2K3I+6+EaFavGYU6cx zq4kbZFkVYTiWvnDBVmSt+zIzPhXaXzTO1yp8qn2ANsi+bGy1KIwtBF3pUBLrsJe+c3Z 6STA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=4KEodA6HsyUJpOvCLWhuiNIE3cmXsNuj9MIhHoVGIbg=; fh=qNI36f+i519pO60t4np6wsBL/UgcCZgRvdxX4OT+EvM=; b=xE2Pn5ZWYKzAUG+CiOvbje/BeVOFGVZcCiTFkCsUBHOw7z7m3cFd1kRm5al7zI87bW UXIBQ1qSX7RT6bpPg4ooYJiqQiP1sbr+q0rkbLW/DPywBhuQJnfKF5lUQTNJZ6oap1q6 YxWCvUOmagZKgSr4pzJgaGoO9X47DDZ9e4Yt55WZp/c7Q18GROUz4T8p09xbJzjVFOeQ 4MqfWzHI56f++vBfuhRPVopqsygwtMs3dgLlCG3U8IgkdYrj+0DA51B6iWIGJKouyHRx fobrYvD1MeE7JmQw7weutm/BQkCsPqaZTLRpNXQi8iCbSUMks0eSYUX9yzjxzWu6oJEA uJpg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=nB0CSrmR; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1365-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f14-20020a05622a104e00b0042e3c2e2446si3328835qte.135.2024.02.22.07.55.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 07:55:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=nB0CSrmR; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1365-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3189A1C2514B for ; Thu, 22 Feb 2024 15:55:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F2B7B150993; Thu, 22 Feb 2024 15:54:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="nB0CSrmR" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06AA514E2EC for ; Thu, 22 Feb 2024 15:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617296; cv=none; b=gaheqNQ9RfKyqjRoZWPMFIrykfYgsttZk/onn35cPmrLRpOwhEZwg8i4QqSNvc8xuCjgtgtVEVMKLUd4JzuyvtwDh4hUxm3BSN6+cYRNWW1+AhyjeRpPzJUY3ch23iywDid1bZ9+jwZbQ4h6SLT/CT/VJu5gq3+Nk2ProYMGG7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617296; c=relaxed/simple; bh=3gudls+qOVnJJ2Z6I9k9ViRZ5gG6pFI5d3hFmaBqiQk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pUSsBF8lCD927lkqJtc+hF/a0Fli7Nyb6nmwNJFGv//Bc/kmAmiZOyrRWV38odRdalwPYTnBNVLOiN6uXhBjankotyLtFpKeCp9PR42EKCHw7tFD6PiX0Ajf3accIYh+8cISx7Jj5VG8ngs4OmONe0hlSXFQE7DKOzIT6TmHIHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=nB0CSrmR; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-102-198.bstnma.fios.verizon.net [173.48.102.198]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 41MFsecV030805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Feb 2024 10:54:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1708617282; bh=4KEodA6HsyUJpOvCLWhuiNIE3cmXsNuj9MIhHoVGIbg=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=nB0CSrmRqnuPeJ6MRMK9Lmu+KQ1kiW6i+QPDCS9EHP61D74dRvAl7ReMpf4OGR+ru llQPE/s8QafEMOwvPx8PvsnPzYJBlYo3KGWa+sj1u6HKvMoUwwNHCv9HkaTZZ3bAm0 Sc7S30hAxxAakHQkj8Cwwj7lb9S8khafxxA0t7QKzP7jOkff70DOpFx9uVqUX+q6rv q3UG3UZQaxXwuYq9D/OlD3qzC5SyBjccYz+8t+mHRzqgTAXQZ5cHbv+nQNiiZe0/Y+ pKHwQU8ThMPnPQkoXdE05idJjyCov2r54JFTF5w0bZJBmOru75B0pIEgojIqxaX5SW pc0XEKO1Nu8bw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3A90F15C1443; Thu, 22 Feb 2024 10:54:40 -0500 (EST) From: "Theodore Ts'o" To: Maximilian Heyne Cc: "Theodore Ts'o" , ravib@amazon.com, stable@vger.kernel.org, Andreas Dilger , Yongqiang Yang , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ext4: fix corruption during on-line resize Date: Thu, 22 Feb 2024 10:54:32 -0500 Message-ID: <170861726754.823885.5472128846628604301.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240215155009.94493-1-mheyne@amazon.de> References: <20240215155009.94493-1-mheyne@amazon.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 15 Feb 2024 15:50:09 +0000, Maximilian Heyne wrote: > We observed a corruption during on-line resize of a file system that is > larger than 16 TiB with 4k block size. With having more then 2^32 blocks > resize_inode is turned off by default by mke2fs. The issue can be > reproduced on a smaller file system for convenience by explicitly > turning off resize_inode. An on-line resize across an 8 GiB boundary (the > size of a meta block group in this setup) then leads to a corruption: > > [...] Applied, thanks! [1/1] ext4: fix corruption during on-line resize commit: 3a944549dd26ccaf1f898a4be952e75a42bf37dd Best regards, -- Theodore Ts'o