Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp424064rdb; Thu, 22 Feb 2024 07:55:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW0mXd9kySdc0osu/pq0Si1TcbTynmDTKdaTKTl7hwqap9Ii9SrmF+3UfUCeL0F3GZdTq8WnK1RumSmY2NA1z/tU42oRZJBGtj3CK26Mg== X-Google-Smtp-Source: AGHT+IF9GiIKkmkKW5W6g04TpxsaJDPHe9Izr7InTZLVJInw088bjK/tAuIPOlRFTHsQwCoGiYVQ X-Received: by 2002:a17:906:468d:b0:a3f:9c9b:2037 with SMTP id a13-20020a170906468d00b00a3f9c9b2037mr1034019ejr.67.1708617324553; Thu, 22 Feb 2024 07:55:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708617324; cv=pass; d=google.com; s=arc-20160816; b=Ut//EC3XR9+CcAyJ5CPFZRoD4q2NlDDM5YBb6PAVLPnZRUS0FGyTHVJ/CAT/T9gsr5 7ADsz3TZ+42aUeHPouvB3LVIR2coDkoWDbpClLEa0mdJ868nGqDte5d+eWcJ1m6GwVzJ Nyqi0jMF9EizlHLEMTOCAQIuPRD5KMeu5PFjBpFPt1600hiMwOnbg451Yhuc4XzOAgmQ 8/Dh15yMNZrLaV5j9D75Bpyicp7oodH0nT/DtnlHgxwBmEXij88o8dxBk+BikW1jSffA 59wIehgPOToxJB27fr6fQMeBbV57LMYGFPHzrX1VSsxPdU5yt1WthmKprhrrFvnsyV8L zbCQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=va26ubDfjVqf3AasDsVt7PlhmdIYT6yVBEJCl7RCZ30=; fh=VdA+S4N4aAkwzEFNMW8fD1NRDVfQMSpFdu0BtT7D5Qw=; b=aEtRin6ucM9sArjfAXTvinEtIOBDTclhcJi92+tJrVTw6/ximZcLyZ+w/09OxRJ3dc XiPG0ZM28u0y4JvjHMc7vCuRCJoNJtZ/ecLoghdoILnlhPFFDatP2SoZhJUAf/jEZb0B UuCdIoPOS654xD2dstuujoH25U5Mclf9/d049LpY+Dl1EF1DgEtc8v395p+7h6JCrze1 O3DfZTPq/zTJb6gE0v8+kYhtXqyOpP1HX65hvxqm0ZKdBiuEpsCj04hwaUrSRkympaHQ VEb8eK680E1RmuKXnIoYhKtpmUDIZZnHmSfO0cyLsWegp3J1TBXamPHVSGqmSRLmCm4y 3hQQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=MNaqjWLp; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1366-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id q11-20020a170906770b00b00a381de492a6si5383373ejm.969.2024.02.22.07.55.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 07:55:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=MNaqjWLp; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1366-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1366-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 32F5F1F230CB for ; Thu, 22 Feb 2024 15:55:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 92026152DF6; Thu, 22 Feb 2024 15:54:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="MNaqjWLp" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5976C14E2EC for ; Thu, 22 Feb 2024 15:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617299; cv=none; b=sN0AWPy8VwlgCy/88hI+ifhrdw8RHZUDIsZgjiRwAFYecgvQL4P/FmfXGPAN82qqbrXP4XiBtuTMc49Ppy/2iVtKe6O0X0+HtQCsnaQwM5sCpEKym3Ef6hjD0ZQdgxybeESZZIze9GwOmg5PhjWcOKw+SgZ2/suuwOE7FP0ykMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617299; c=relaxed/simple; bh=JfkoAz50awV0qbSc4V8fA6NAcDNFyoem9HJGiEOJz1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HEC3wPvkoLQoSoWxEIFWIthjSaxXGK1+2an2lZsg88fiUKpiveFEIVDSrWh/6pBEZte22wZ1J4+1Gr4tWJfFhGxMcNqsYBdF+iiwh8ODuGrJX6nkGBUs9a1u/zvRo81l9JqOAM2AfW5UDjq8prv7D3RdlX/OEJhRPLcbf59CC10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=MNaqjWLp; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-102-198.bstnma.fios.verizon.net [173.48.102.198]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 41MFsgVA030847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Feb 2024 10:54:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1708617284; bh=va26ubDfjVqf3AasDsVt7PlhmdIYT6yVBEJCl7RCZ30=; h=From:Subject:Date:Message-ID:MIME-Version:Content-Type; b=MNaqjWLpudSxaj/AaFOC0P7YTx4DaEB9lUWtJ3bsQpzmFPpTc8hk5Ls1gHY3ECQK8 rRwsrKFot3+in98amj+uWbVshXUHdDJemZztPzallI9sPZRRYvmC/TZYMuCwkgUj1E segZ5B/e0HUAprShlmxk0U8aGUHPKEDCwcnpSSPqfP0BN7Qc+EpOT5joJ+2bHLMbCJ 21jhUKZsQtMdecOkhy/PIIATYkDYxc7kRA9LUG/riPsSDlYD+V0Z3zdpGcmQJGwcuW BT6iXzAXBLv1Krn1gFR/ieEF353VA1+SupSoa0/+Emto3+Aztn9tjGm3/PJ7IV/yfD 60Ye/VLMWg5MA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 40DD215C1489; Thu, 22 Feb 2024 10:54:40 -0500 (EST) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, Ye Bin Cc: "Theodore Ts'o" , linux-kernel@vger.kernel.org, jack@suse.cz Subject: Re: [PATCH] ext4: forbid commit inconsistent quota data when errors=remount-ro Date: Thu, 22 Feb 2024 10:54:35 -0500 Message-ID: <170861726752.823885.428276685390671750.b4-ty@mit.edu> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240119062908.3598806-1-yebin10@huawei.com> References: <20240119062908.3598806-1-yebin10@huawei.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 19 Jan 2024 14:29:08 +0800, Ye Bin wrote: > There's issue as follows When do IO fault injection test: > Quota error (device dm-3): find_block_dqentry: Quota for id 101 referenced but not present > Quota error (device dm-3): qtree_read_dquot: Can't read quota structure for id 101 > Quota error (device dm-3): do_check_range: Getting block 2021161007 out of range 1-186 > Quota error (device dm-3): qtree_read_dquot: Can't read quota structure for id 661 > > Now, ext4_write_dquot()/ext4_acquire_dquot()/ext4_release_dquot() may commit > inconsistent quota data even if process failed. This may lead to filesystem > corruption. > To ensure filesystem consistent when errors=remount-ro there is need to call > ext4_handle_error() to abort journal. > > [...] Applied, thanks! [1/1] ext4: forbid commit inconsistent quota data when errors=remount-ro commit: d8b945fa475f13d787df00c26a6dc45a3e2e1d1d Best regards, -- Theodore Ts'o