Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp610164rbe; Thu, 29 Feb 2024 08:43:22 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUhkz3D00/y4Msj+dxA5Q6RJvyG1/5AwMzEguyTwQS/hYQIpQ5DH52LhHNLngQCfUoOkeXk5LDg7AR8VBDss87+66ttjxBi/6FHK97omw== X-Google-Smtp-Source: AGHT+IHcih6X8+nmPbRyct3EU6xot30sQnFhaGGVFJ3IxWohiXaNU/Myjf6DaBEQ1cEAFTTl5EW8 X-Received: by 2002:a05:6a20:6713:b0:1a1:b38:be61 with SMTP id q19-20020a056a20671300b001a10b38be61mr2477863pzh.51.1709225001703; Thu, 29 Feb 2024 08:43:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709225001; cv=pass; d=google.com; s=arc-20160816; b=VjR5mQJKaVskVufwlFtpVFT2zQvxkkiuLUQ7S/IX97gFM34ljYLTUOqvxnxNZMy4+h xDDrZyA3y/zvey2AR1LgvNuWm+gCWJQsEnW/Xzadt+X49alBk4H0vv4b6NgyzkgvlEgQ 42hhkIHMacS8DUTK4vBHsnaRzMDgK/2da02m6pVhY+Y4FPcUkQihK0jxGjup3Ii+hYSq ZiH/VfB/ne8bQ7RHTEAEl62lrE7fBLQRza9voCzjPYvtQ3Bm1iEIT1QDmDX9iwwhSl3p ozZxdPEyeabK3HHO05XBsCykHIIfq0YiFYK4ZD0ttLJZ7Zoiseuqax6mC+mmZBI/rQEQ pzAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=jLvHQVGDVDaZj/+IzGodoOjcGc/wj7OEewe/zHwFSCc=; fh=jGdaoZ9f8fxaZ4S3XMcGs4Y5Dr6Ro1lg3HBgLAvBHb8=; b=tcoGGGcmhfHBJDi/v4IwIMK39qnvc36MdACnjWAw1H+DURePnwVRLXgs9LpNjOCein i7NpWqaJp4xS15Ey7tKNyvIir6aysen39wXjhX0kgW9VRe+F5bSDklO3VOiZ69m5YTa5 0yBDaro4p3g9Og53SFlL1CJMElqJsvwr/zN4Ebd6kRnq8RRJU4Rpya09BVQJhO/mKCz4 P/ASyGG4VwiI8fXdbuAVHmX8+wU/3sT0KPhfLgDFw8WIPCiQVzXGwQfX6Dap6vuKg8fC EWrNuoZbS5voMcCc/uOcI3zL6DXgFyXyi9SqzH7M0ZL1nDix2tEhNZBCv3Bus5NHD7WI J4Tg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-ext4+bounces-1440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1440-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i38-20020a635866000000b005d44c945aebsi1704041pgm.82.2024.02.29.08.43.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 08:43:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-ext4+bounces-1440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1440-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6BAE928B9B4 for ; Thu, 29 Feb 2024 16:33:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53D167A127; Thu, 29 Feb 2024 16:30:21 +0000 (UTC) X-Original-To: linux-ext4@vger.kernel.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74A1E381B0; Thu, 29 Feb 2024 16:30:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709224221; cv=none; b=lsF24aMoUe1awThDe0rxMPxaGCbqUkphiBAFU83JXSpF6R3hXjNQymk+p85QTGCMQsNXCQQXBoz7lVmjSVmDavlwPcoSOCLwJFhGMNg//soa7fttdjJC15vCAbx+UN0vV/YHGzj4UZFV8mYl0HmtIZ4AD8p2dlA2YdUleGtl0KI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709224221; c=relaxed/simple; bh=6/KrjLjKH3bauC/9VQHcqfuKTv2YG01tiR8gHwzXGeM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R7t78A9Rgy+56mEwEI0BXEbRdNzBjOnyFifnt3nC2YBcMfOnhD1Wpp8aaepujSZKFq3ScCG/GZH8hn20tsgmI7vPtJpQFQyGmEy7rRLPMsQlLmSclex/v9qIXz1XCAT+Dop4l94QYdknK0cyM8Xy64UfeQbE3yNQ5Jf7QnmOeDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A728921FE2; Thu, 29 Feb 2024 16:30:17 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA54713A4B; Thu, 29 Feb 2024 16:30:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CEMPMhix4GU0PwAAD6G6ig (envelope-from ); Thu, 29 Feb 2024 16:30:16 +0000 Received: from localhost (brahms.olymp [local]) by brahms.olymp (OpenSMTPD) with ESMTPA id bdc647ed; Thu, 29 Feb 2024 16:30:14 +0000 (UTC) From: Luis Henriques To: Theodore Ts'o , Andreas Dilger , Alexander Viro , Christian Brauner , Jan Kara , Miklos Szeredi , Amir Goldstein Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Henriques Subject: [PATCH 3/3] overlay: fix mount parameters check for empty values Date: Thu, 29 Feb 2024 16:30:10 +0000 Message-ID: <20240229163011.16248-4-lhenriques@suse.de> In-Reply-To: <20240229163011.16248-1-lhenriques@suse.de> References: <20240229163011.16248-1-lhenriques@suse.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: A728921FE2 X-Spam-Level: X-Spam-Score: -4.00 X-Spam-Flag: NO Now that parameters that have the flag 'fs_param_can_be_empty' set and their value is NULL are handled as 'flag' type, we need to properly check for empty (NULL) values. Signed-off-by: Luis Henriques --- fs/overlayfs/params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c index 112b4b12f825..09428af6abc5 100644 --- a/fs/overlayfs/params.c +++ b/fs/overlayfs/params.c @@ -441,7 +441,7 @@ static int ovl_parse_param_lowerdir(const char *name, struct fs_context *fc) /* drop all existing lower layers */ ovl_reset_lowerdirs(ctx); - if (!*name) + if (!name) return 0; if (*name == ':') {