Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp302049lqs; Tue, 5 Mar 2024 02:26:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV9Lpy/gUgCm26MJjMdapMZ0sjf4xrnmqnaAid9F9B6Z6dPQYcb/T6tlbhNoNJ2IjFtSqTt9nY3lftJe8X50l907RHNMowh4hab3qLPLw== X-Google-Smtp-Source: AGHT+IEgrSO61FAO2y2u7YRW43Cu1nUSENnsHhsJXJBn+2GAfW/5J0UvtHcEwZZZqTWp0swumZZ6 X-Received: by 2002:a05:620a:9d0:b0:787:f739:9836 with SMTP id y16-20020a05620a09d000b00787f7399836mr1505340qky.52.1709634377166; Tue, 05 Mar 2024 02:26:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709634377; cv=pass; d=google.com; s=arc-20160816; b=c00rm7+U4aOgzP4qSInYiBBAbPBhO1KbeD4pQpCU5MZWscwueWfyL1trETRNcJk8NB LXESkgOE5f2LA9pAc0UADLhAE34z02pV+dsqCV8bovj1lNh4FKovGi5e29RAV+Rl56GB EbOuXk0ggE0tPcatsYgo9LEp75fiWkDervsHr3FDXYGx+eRdBg8hx0WjjYEJJBovCYV2 uFW13fy7+77XpqgWElhtfC4dILYAGFM9fbO3oHQl/oKMKhx7/W/jZ0mN9IjZdOzZpJAc kRC10X5d+a78VrAfJduugwVcTiBkxxBbmu8kg0kmGuSa3G4NyfrI6iDgKsBndLaXO6Md n0rQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=prhBV3AD6wPGEmJOiPV1noI0wHQ/KY6pKMN3W0SziRo=; fh=leNjPu/3B1/amj8pWgnZPg+v2NORBP0eXUn2DeKKAIs=; b=t+U+/B+YITcoxhow6ptlNwkKeYmfyYw9joY2dpV0wUdG3qHINHPl3/4Xv5KZ1Hg8q6 mqsT1EMptNC+rbxA9z5BoXGBCXohVF25czNvpWBHTAxSPThZdbwit2QXQgAnp50fSIv4 poVE3qdZNyOFuHm6zcpJn+HXmLsxTrGB8Si7HGgxd4V8qfRuKO2kxwvtmqy9E7LAMpQD //bUkeuCAqyRunXQy+2XT8PZm+B53azsnI+zFr6LK0D3o8dWmedHMhCNyEu1/nQMq3B4 kAwcxG4ztPuKHx4L6Z5QhCyMg8VK+z7V+9aXs57+fRq8AZqOz24tbevz4/hTGnSXgNzG r5aw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=hIASFsMv; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-ext4+bounces-1508-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1508-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id i21-20020a05620a405500b007881ea79b05si7099933qko.547.2024.03.05.02.26.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 02:26:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1508-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=hIASFsMv; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-ext4+bounces-1508-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1508-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E1B621C20B07 for ; Tue, 5 Mar 2024 10:26:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5D04C60EF9; Tue, 5 Mar 2024 10:16:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="hIASFsMv" X-Original-To: linux-ext4@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5907F60DF7; Tue, 5 Mar 2024 10:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709633786; cv=none; b=ceF6LcZmqkznQHPw/RgExQaMsx/pQrZa85y8uS8Y9QbwGN/xmdMROSzcyU6RZvHUamoBjXqIZf5+EfLj8MK5a2LFZXEwyH1uXEEAla/GS5Ao49dAaeJuQdDcMEsXARykjzMOYsE00uqp08E5psqqYw77VvXUv5C5PzMOwTTMeek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709633786; c=relaxed/simple; bh=i/9ZW+kNqpZnJVbMsf5b8+hAV2dVj/G+FqywABYCn2o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hgVdTT077j5Lcufn/jcEexBl4meETuJJrt8rtTjFuBrh5ImsuZ82hKRr+zk7pBFCiQ4cjWNSCPEoIiRRr1qgIISsi0g/cY1psfq1bE5zgmOKOfBR16Az5de5bhXPADBNXKa2eWJ21n/saTQi454+Z+mN8VPFUwXYgkmc/CW7GDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=hIASFsMv; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709633783; bh=i/9ZW+kNqpZnJVbMsf5b8+hAV2dVj/G+FqywABYCn2o=; h=From:To:Cc:Subject:Date:From; b=hIASFsMvENDZkfwrWl7aEgXOJK9SjbtAmPR07fRshhtuD4+jt406NG79i5DYiWELf Xghf/2KavoY3OIpydipg6j2iPOav0POFQALRPe2b6KL9SqfIkjMnhal0MOooaKAz3X VVy452exObbp+l5etRpn4D7aeBGDLeeVWGIrBIZOCHpgE+hhVB/9oS3m86etzuSuPD ILWevtXYjMl1kkw3yXnqC02zM1pt+jg5UfZfrcuHK5Tbn9549J+sOGID56mgnk3nk/ gD3KKHQf0fVPxu9lo3KdqF9ur4kdK856U/2dS1h3R8oBvKifVOmpARUqEOOyJ+jLS0 oFFRcSeC5P6EQ== Received: from eugen-station.domain.com (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 355D9378045F; Tue, 5 Mar 2024 10:16:20 +0000 (UTC) From: Eugen Hristev To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@collabora.com, eugen.hristev@collabora.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, krisman@suse.de Subject: [PATCH v13 0/9] Cache insensitive cleanup for ext4/f2fs Date: Tue, 5 Mar 2024 12:15:59 +0200 Message-Id: <20240305101608.67943-1-eugen.hristev@collabora.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, I am trying to respin the series here : https://www.spinics.net/lists/linux-ext4/msg85081.html I resent some of the v9 patches and got some reviews from Gabriel, I did changes as requested and here is v13. Changes in v13: - removed stray wrong line in 2/8 - removed old R-b as it's too long since they were given - removed check for null buff in 2/8 - added new patch `f2fs: Log error when lookup of encoded dentry fails` as suggested - rebased on unicode.git for-next branch Changes in v12: - revert to v10 comparison with propagating the error code from utf comparison Changes in v11: - revert to the original v9 implementation for the comparison helper. Changes in v10: - reworked a bit the comparison helper to improve performance by first performing the exact lookup. * Original commit letter The case-insensitive implementations in f2fs and ext4 have quite a bit of duplicated code. This series simplifies the ext4 version, with the goal of extracting ext4_ci_compare into a helper library that can be used by both filesystems. It also reduces the clutter from many codeguards for CONFIG_UNICODE; as requested by Linus, they are part of the codeflow now. While there, I noticed we can leverage the utf8 functions to detect encoded names that are corrupted in the filesystem. Therefore, it also adds an ext4 error on that scenario, to mark the filesystem as corrupted. This series survived passes of xfstests -g quick. Eugen Hristev (1): f2fs: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi (8): ext4: Simplify the handling of cached insensitive names f2fs: Simplify the handling of cached insensitive names libfs: Introduce case-insensitive string comparison helper ext4: Reuse generic_ci_match for ci comparisons f2fs: Reuse generic_ci_match for ci comparisons ext4: Log error when lookup of encoded dentry fails ext4: Move CONFIG_UNICODE defguards into the code flow f2fs: Move CONFIG_UNICODE defguards into the code flow fs/ext4/crypto.c | 19 ++----- fs/ext4/ext4.h | 35 +++++++----- fs/ext4/namei.c | 129 ++++++++++++++++----------------------------- fs/ext4/super.c | 4 +- fs/f2fs/dir.c | 112 ++++++++++++++------------------------- fs/f2fs/f2fs.h | 16 +++++- fs/f2fs/namei.c | 10 ++-- fs/f2fs/recovery.c | 5 +- fs/f2fs/super.c | 8 +-- fs/libfs.c | 81 ++++++++++++++++++++++++++++ include/linux/fs.h | 4 ++ 11 files changed, 219 insertions(+), 204 deletions(-) -- 2.34.1