Received-SPF: pass (google.com: domain of linux-ext4+bounces-1519-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 5 Mar 2024 15:12:21 +0100
From: Jan Kara <jack@suse.cz>
To: chengming.zhou@linux.dev
Cc: jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev,
	Xiongwei.Song@windriver.com,
	Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [PATCH] ext2: remove SLAB_MEM_SPREAD flag usage
Message-ID: <20240305141221.um4zuvnro7tg5fgq@quack3>
References: <20240224134816.829424-1-chengming.zhou@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240224134816.829424-1-chengming.zhou@linux.dev>

On Sat 24-02-24 13:48:16, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/ext2/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 6d8587505cea..7162c61c0402 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -213,8 +213,7 @@ static int __init init_inodecache(void)
>  {
>  	ext2_inode_cachep = kmem_cache_create_usercopy("ext2_inode_cache",
>  				sizeof(struct ext2_inode_info), 0,
> -				(SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
> -					SLAB_ACCOUNT),
> +				SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
>  				offsetof(struct ext2_inode_info, i_data),
>  				sizeof_field(struct ext2_inode_info, i_data),
>  				init_once);
> -- 
> 2.40.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR