Received-SPF: pass (google.com: domain of linux-ext4+bounces-1522-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Srivathsa Dara <srivathsa.d.dara@oracle.com>
To: Ritesh Harjani <ritesh.list@gmail.com>,
        "linux-ext4@vger.kernel.org"
	<linux-ext4@vger.kernel.org>
CC: "tytso@mit.edu" <tytso@mit.edu>,
        "adilger.kernel@dilger.ca"
	<adilger.kernel@dilger.ca>,
        Rajesh Sivaramasubramaniom
	<rajesh.sivaramasubramaniom@oracle.com>,
        Junxiao Bi <junxiao.bi@oracle.com>
Subject: RE: [PATCH] ext4: Enable meta_bg only when new desc blocks are needed
Thread-Topic: [PATCH] ext4: Enable meta_bg only when new desc blocks are
 needed
Thread-Index: AQHab3sgNnst4KeDY0eSTg2qglKft7EqP+cw
Date: Wed, 6 Mar 2024 06:55:33 +0000
Message-ID: 
 <DM6PR10MB434724909C97728F1618F589A0212@DM6PR10MB4347.namprd10.prod.outlook.com>
References: <20240227131329.2608466-1-srivathsa.d.dara@oracle.com>
 <87o7bsovn6.fsf@doe.com>
In-Reply-To: <87o7bsovn6.fsf@doe.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?UuLuD1hMHpVcI73bP2oj5YFeKC+Z+MMQCQRtTZChKMPGzaSDOYrmBpZnQSlU?=
 =?us-ascii?Q?40rXvxPDg3v56QVMceghaPuc52gTvSBV2akvgLLbJdFYm2PJFWVyw3qqkp5M?=
 =?us-ascii?Q?kz/inFkUjxzpz7ByVqdRfflMt08TULJvvIabVuDARJVxds1/MJCmWsYPlXMw?=
 =?us-ascii?Q?5YAiAG0k1jMyGaF5Sm2lkCc93OeSGL6t2NMwbW+T9yIg2fPtV6QdknrBU564?=
 =?us-ascii?Q?0PUxGHPYQfiAmQc8lOo9hzNR2I9jIZEume4OCWcFitQpkc9Hb/Q1/Tb4gdTp?=
 =?us-ascii?Q?U7KJhTheKcErut3SIDslMu3An9dq7fo+aq8xlLeaR7qwZ+jvz0vrxPsxcaRd?=
 =?us-ascii?Q?UdXVIBWOaQ88LFXWz5P3c2VTo0wfREaMxmejEuIRhifjjgtw1MLyRx3uBfUn?=
 =?us-ascii?Q?Z2/G+4VCzzybTvW3RiEkMwQT/Ome5vhj9/MB4rog/9b3MdIqKSVrGz0GbPEx?=
 =?us-ascii?Q?YQscToSgloBy/+xxolT/hp0b5zF8Own3ZW4NupFFLlSMcK8iHpC/zaZRQEGA?=
 =?us-ascii?Q?OGh2P2rWRrDc5Rt4K2ZxrXY8zCCIQNdGBOWV3T5FnAYnbgJyUnnl0QRYj70c?=
 =?us-ascii?Q?BDM476oAix1ac/P2G2DLjuhJhdsCj0Qijknx6QIp1eZP2Xu3hY3TZrhGSboy?=
 =?us-ascii?Q?0CMVYoneQQkLRQa3fVAUKI+j6N2eW71OpIXLkQmMpi8gCReSP15jV3w0O8o7?=
 =?us-ascii?Q?gWK2GZEsVsUcFab7VHesTzthCjKMm/DCRHAeA154+CdgZNUKHMoqsN8WTVbm?=
 =?us-ascii?Q?K6dqXdqvf+hVXf9N8nGgmzhYzAzV8zFwTiP8jlMlnVzjIiYqkKJjreOaOObK?=
 =?us-ascii?Q?0Ig7rY+IdsE1z7hFdnmOtsmD+Yc3ssF5MepBeOYUJe7zoTUiK97MVRBzzU8d?=
 =?us-ascii?Q?Kji22hw1cEZEGsJdHKeekCYTmar0nTnCutJyW6tBNPUKYKV+x7WR4+Jdw1SA?=
 =?us-ascii?Q?LXBkP2jSPn5znnZ51o3hz5WZodYOUjcfpkOmkX4oWsl6K/x/GnnHKIar45sU?=
 =?us-ascii?Q?AlwHDoKnI35MZ6jNc48IZarRfGw0WpXy7tgsFGGSRnbOVNudJt078T4655rP?=
 =?us-ascii?Q?BlOjaEarLFrhBwxMP/XjyYtlNJCEeVvvkiAVVpRGvCqxdAQzxhj2SPdFfUEG?=
 =?us-ascii?Q?vnagK4Pfvrw1X+V1ce9rAHWU8okbprG6zo+AZZcFoeP534ii/yI6NwmtqcS5?=
 =?us-ascii?Q?b9XEvuK6aTvcEo32np4nE4undjxNsGHoVNsl1CTEGXRw54JUPveO+19RSedU?=
 =?us-ascii?Q?9gGp0v8fq9A0p91oZBmtmax6I66xyfYagOtcXWFcLWM+9xtZxHi6W9e/nbNB?=
 =?us-ascii?Q?oY+UhKjYXKHsCv8dkolkrbP7NIqglaWzpMByNDghHDckM2cIPnQ5GPLBDntS?=
 =?us-ascii?Q?2eb2vpdzMM/hSF1DIgACHOtmk7KiU69vclHzTMKEZeu8TSywyZtnh7gQgjgg?=
 =?us-ascii?Q?r880mVVM5Gqx0GOO6reFG7TW/Vl/ftdXy0dMIiRzFgi/vqr/DwENCF+4El5F?=
 =?us-ascii?Q?pImNjMBcgRv/l2MQ4vdaPlcxBIvi9jRNEwixqwKtEesvXpdtGmXF02PK4M6U?=
 =?us-ascii?Q?G69zRgZuubpG5cRCezQ6pXK/zx1TnZoa13A7uRbO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-ext4@vger.kernel.org
List-Id: <linux-ext4.vger.kernel.org>
List-Subscribe: <mailto:linux-ext4+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-ext4+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	A33S+Q16upj7ZuMd553eHMbyEfU/T+/lSo6yJB1Oeplv/+0mK8l/ogYsAaFvqMIcRR8qxaxYy6qif/1Mj2tDQBQFSgOIExaz7syStCsjbA22W6b7Uasec3tSMm8KSdkM99dkMODk7ZdQ8Bcq/rPEZeqwb+ViETgofLrdjV9ZnA+RFfmO4zDNHGCPyki8OnSuCogl5CFKfGIAZgiyznj66sJDfKNIa6Gzj+M9+TRpTYuoUlpUX8kIWEhYan8XSg1G0BPgedKMA+K67ysoFFRSzLH3fQ08qWWkAqMCX8pX/JlD//FAl8dBheTLlST5u0LSoYWeIZ3lK+6EtxbymSRYBrUUT4N5bSErt5ghrEx161+IYrw7Q46BzROwVfN3Qz2GQnAnRaDIQFU84a0Px6tR0PiYpf+N8Ugztud3dhthTEuB1IvUy8yCvUGqmH5XSEZ1dLMERb2w/E2TfBUetkrGm+No48wZzDV4nhhTEt92aEnhqgRmpEjUrKD5O/0a6Y02g/MTQ5y+ngQCMKdM94JrXSBo/StNlBTzz39kT0wbe8s5dJTgpqoHzLpRhuFwJuP+K1e1bmQqA5Lsc2QWwVNgw7OGzHuXplkEdYOthzuKPfw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4347.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1dbc81e-b601-484a-f0c5-08dc3daa6b53
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2024 06:55:33.3973
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bO67Tjkx6A3dXZjr2l58BT5070j+ovhHyL3/QNnikm7/flyddy6+HJqsp0pGb/laVSjAc5zw2eJp1i6zXW2/x5EgyGOFv1qrE7NUpRIkDuQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6832
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-06_04,2024-03-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999
 spamscore=0 phishscore=0 mlxscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403060054
X-Proofpoint-ORIG-GUID: 8YF_gLmtkVKMvSm1jKQoE7CvMx5PrtB8
X-Proofpoint-GUID: 8YF_gLmtkVKMvSm1jKQoE7CvMx5PrtB8

Hi Ritesh,

> -----Original Message-----
> From: Ritesh Harjani <ritesh.list@gmail.com>=20
> Sent: Wednesday, March 6, 2024 9:32 AM
> To: Srivathsa Dara <srivathsa.d.dara@oracle.com>; linux-ext4@vger.kernel.=
org
> Cc: tytso@mit.edu; adilger.kernel@dilger.ca; Rajesh Sivaramasubramaniom <=
rajesh.sivaramasubramaniom@oracle.com>; Junxiao Bi <junxiao.bi@oracle.com>
> Subject: Re: [PATCH] ext4: Enable meta_bg only when new desc blocks are n=
eeded
>=20
> Srivathsa Dara <srivathsa.d.dara@oracle.com> writes:
>=20
> > This patch addresses an issue observed when resize_inode is disabled
>=20
> Other than "meta_bg unwatedly getting enabled when not required", is ther=
e any other issue you observed?

Yes, we have seen an issue where a data block is being corrupted by group=20
descriptor block because of this. The following patch fixes that issue.

	ext4: fix corruption during on-line resize
	commit: 3a944549dd26ccaf1f898a4be952e75a42bf37dd
=09
>=20
> > and an online extension of a filesysyem is performed. When a=20
> > filesystem is expanded to a size that does not require a addition of a=
=20
> > new descriptor block, the meta_bg feature is being enabled even though=
=20
> > no part of the filesystem uses this layout.
> >
> > This patch ensures that the meta_bg feature is only enabled if any of=20
> > the added block groups utilize meta_bg layout.
>=20
> Make sense to me.=20
>=20
> >
> > Signed-off-by: Srivathsa Dara <srivathsa.d.dara@oracle.com>
> > ---
> >  fs/ext4/resize.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index=20
> > 928700d57eb6..99b52f26e818 100644
> > --- a/fs/ext4/resize.c
> > +++ b/fs/ext4/resize.c
> > @@ -1996,7 +1996,7 @@ int ext4_resize_fs(struct super_block *sb, ext4_f=
sblk_t n_blocks_count)
> >  		}
> >  	}
> > =20
> > -	if ((!resize_inode && !meta_bg) || n_blocks_count =3D=3D o_blocks_cou=
nt) {
> > +	if ((!resize_inode && !meta_bg && n_desc_blocks > o_desc_blocks) ||=20
> > +n_blocks_count =3D=3D o_blocks_count) {
>=20
> Beyond 80 chars line. You might want to fix that.

Sorry, I missed that, will send a V2.

>=20
> -ritesh
>=20
> >  		err =3D ext4_convert_meta_bg(sb, resize_inode);
> >  		if (err)
> >  			goto out;
> > --
> > 2.39.3

Thanks,
Srivathsa Dara