Received-SPF: pass (google.com: domain of linux-ext4+bounces-1557-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <e4bd58d4-723f-4c94-bf46-826bceeb6a8d@oracle.com>
Date: Wed, 6 Mar 2024 11:22:44 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 0/9] ext4: Add direct-io atomic write support using fsawu
Content-Language: en-US
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Cc: Ojaswin Mujoo <ojaswin@linux.ibm.com>, Jan Kara <jack@suse.cz>,
        Theodore Ts'o <tytso@mit.edu>, Matthew Wilcox <willy@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Luis Chamberlain
 <mcgrof@kernel.org>, linux-kernel@vger.kernel.org
References: <cover.1709356594.git.ritesh.list@gmail.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <cover.1709356594.git.ritesh.list@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bTZqekRJcDVRQVQ1VUlFWDIzN3hGUEN3MEdIUTVIMUtibStsTURDMWpjQUpw?=
 =?utf-8?B?UjJQdFRhWFZrWk81dGJPOC9GVmNtWVFMWENScnRVUmVkR0s2eldUVm1KUm91?=
 =?utf-8?B?QU9tbmh4cEhERWV0cHZtelR2RUIyc2NCT0hobitmZEhRWC8rYWRVQmQ3VFRM?=
 =?utf-8?B?SWpGQUlYOVVGN0Vxa0NReWhaZTVtK3pXeldjOHNSV28zeGNIREZtUlV2TFpP?=
 =?utf-8?B?Q2d1N2hzRVgvSmdMTVgrN1JIbzlOMGhFRWFOOUVhclJvWW1hVmU2VVZyeUJD?=
 =?utf-8?B?VWp1WjFZTTdzbjRCT3p4VjYvY2Z2Mk9ZQXdzVUR4VlJzY2dXaUN2aG1xNGlJ?=
 =?utf-8?B?SkRueThiSkVOaFg1WXNpcDZNUGM2TDhwZ2c1amFWY0RhK0xDV0lQZTIwRkpR?=
 =?utf-8?B?SnEvZ0lkeStyRmtIVEtydzd1a0lZTGRuM3FuOHhRd05pZW1nSU0zTnczL2Nv?=
 =?utf-8?B?ZEt4T2xWOS9RVVlEdWQ0eUFSUXprMXZHSS8rZGxCd2NLcVc5d0orcUJEYVpS?=
 =?utf-8?B?ZE50Ylgyc0JRSGY3dHdwVmJyUHZsRDdHU2ljRklkOUY5dDFFWmo2aHgxRUpi?=
 =?utf-8?B?elFVVHpCME1kaldiM3NvMGx2bnUwVG5qb1JxMXpPV0gwTXA3MWVucHd2Tk5w?=
 =?utf-8?B?bksrZXNqN09nQ2pWb1lFM2F5RWlSOEllYTFjZE1JZVkxZlV3TUErOWF0K3NM?=
 =?utf-8?B?cWxqSVlhRG15Rm56YWV1cHpUN2xZVzR0SW9CV3RGQjBSUXNlVzJab2lHdHA2?=
 =?utf-8?B?eTBRM2NoNmY3SXMwM2pZcjlzZmsyZmZpM0ZIbFJYZzJxcXNvWXBHOEczVnZv?=
 =?utf-8?B?UzVYUnc3d0JrWmJvVkZOL01NUCtlbVlVMEd5Rm1GK0dkQWg4SUVPYmRyUlUr?=
 =?utf-8?B?Q1JTS2NGdmJ6azVTcCtpYUlzQnIxR3lzL2t0ZXFlZWJlK3RuYzBZZlhjOUpn?=
 =?utf-8?B?ZkpYc2JIWXNsNnduMWtRZ3RDNnFTakJtOUJ5N2hSWnVHUTNYeGZsSjlVZVh5?=
 =?utf-8?B?cXlITjNTb1VYYXVMYTBwY0F0NTRDSXhKdFpSQTdnc1ZRVkJXR2FvNGtWM1NY?=
 =?utf-8?B?MVNXMC9XRmYxL3hIWFY5Q0wvMnQvTzFxWjdHMzBCUlNTcDI0dzJhVk1lU2l2?=
 =?utf-8?B?UUxCWFhPU0FBVTI1WmRYKzl5d2oyajJ4d1VyV3p6SHcvK1FqMFZjb2NIWTRT?=
 =?utf-8?B?RytpRm9jb3hpeGp3OVNJL0MzaHd0YmtVVmhkeklFcHo2QXV5TExrWnlwR3p3?=
 =?utf-8?B?N01idURJMjRpZCt5Q0EyeStISWZQdzRkVHJMd1llMGxxUjVOWDdWMXo2NU9u?=
 =?utf-8?B?NGpoWmE5OWpUVmdJT21FL3JqV28zWS9qNjhPNDZMWC9RQlF6VndjY0ttRmlD?=
 =?utf-8?B?eittQ2wvNHlVaXR0dTFjdU1mcU4rc0laTVhCdmJwR3BIOFhmbEdvWEk4dU1v?=
 =?utf-8?B?a2JPQ01HcUpXaGRyWS9SZG1Ycm5IdzV5ZWUzM3V3Z0pYaVhtbVZxaGVFbjZS?=
 =?utf-8?B?MFJ3cmxEU2E2bkVKUzZVQ05ZZFI0Sy9xTTg1Y1FjQ3oxbjh3enZmdGk2VUxk?=
 =?utf-8?B?dUxlN3AxYVVRdkQwMmc2eE1uQlkzL1R5OUlwVDZYVC8yRm0zNHFEck1WcWlY?=
 =?utf-8?B?SzZuSTJXWkFtL0k1eEgzRnNzdE1ydkhxNndJWTRpcktRLzVMSmFGWVNueGZH?=
 =?utf-8?B?SCtqRWd1Vkt3cElrTTI0OUk1ZFlxd0FYU3Bxc0kwNHh5bWsrYWNibTJLd2Y3?=
 =?utf-8?B?SXRCa0p3c2dxa003YnVmS2pUZzh2S1ZSUk9ScHp4YjJxNk1RdVptODZPOFVt?=
 =?utf-8?B?d2F3R1htdHRiajM1am5Uanp5S0o3VGJDUnRBN3kwMjBLOWlqd09NZFgxZnYr?=
 =?utf-8?B?Zm1sYTRPQXRyK2ZUeUlFYVZ5Ym43TVdiekR6Q3VabWdCUlMyQ1g2QUlrN3hC?=
 =?utf-8?B?QllqNW53bmVZaVdES3JwL1lBSjFOUm1zckJMaEdYN0xFbi9NNThoWEZrdWoz?=
 =?utf-8?B?emZRTHJQc2U1SXc3UmxhbFBuc09tV1prZkREa1hoM1JGbmxPT2ZpbXhtNWRZ?=
 =?utf-8?B?eUw1NUIrWjFPTFgwR3BNeGhEMjVMdW5URnV5UHVONUJoVEVaTExOMTJma3lG?=
 =?utf-8?B?NnVuYTFpRnZ5Qks0RzdTTlBja3UxWVlsSlBrdFdJNFhlK2NIT1VsL3ZzaDZP?=
 =?utf-8?B?aVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	McdgODiBhkH+Sk2j1jVXAnpIP5MJFNdAP+VsJjoZvjSK575pSmYKzs8bh8g5FDqOyTNxCi+QMcvRIAWz8/TaaRo53r4Y6eqxKYt6yJSLUavaZw0aH8zW+YmIWket4rtFM2udb74U6w/VI9cnC4b1yacjdFmB9GPGraSvkwi1xs6/QmslpCUV6Gf61Q8hSuTIzruyA6iIxU82aXeVHvNERnzknKIH4Xqz63WwRbGSK8Wrv5+B8EJmg2TvS52Dd9I1QqzhmnWqQdgB01vfW+7ALATpr8BaugFTiyTxoH8cA/ihWpauuD7wiBr7cVVk6Mw0egi6Aws7+CHLekFd+uZJKadeY3L0z0bz+IhvM8W1ml/51FuDL9mqKubrl6E3cVtPxq4ZoXSri0oWZXP8VybRmuArvY1kce/gVx25Ps0INuxTPlKrzEONHhSU3lphpJ+7UqeS/xXp///SOWbUspl1RKKAlYu2VJkAD62hEtapZrV5iXMYiTqjI5S09mywiLVFt1i3MCxjUNS4IlA7oPQIPxA3O6vKyU6AohsxQMuJf/HOTWRHOSSznQruGW5BVsG18BiVsHAIzIlGDVaEQVU+xQyNwAq9c0AvcCc6EOYklN8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb2c723d-e90e-493a-8877-08dc3dcfc0eb
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 11:22:48.5598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ie9KFKKjC8R+XsyRRsanJA+34OcxKZ1uH+6MpoJyuC1NItUFJFyqoBTYl1TAmWAs19Q9fP+gb7dZz2ZVI6TEgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4926
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-06_06,2024-03-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403060090
X-Proofpoint-ORIG-GUID: SSXmau51TvkqVo1G54dUKDPOoVYzmS_x
X-Proofpoint-GUID: SSXmau51TvkqVo1G54dUKDPOoVYzmS_x

On 02/03/2024 07:41, Ritesh Harjani (IBM) wrote:
> Hello all,
> 
> This RFC series adds support for atomic writes to ext4 direct-io using
> filesystem atomic write unit. It's built on top of John's "block atomic
> write v5" series which adds RWF_ATOMIC flag interface to pwritev2() and enables
> atomic write support in underlying device driver and block layer.
> 
> This series uses the same RWF_ATOMIC interface for adding atomic write support
> to ext4's direct-io path. One can utilize it by 2 of the methods explained below.
> ((1)mkfs.ext4 -b <BS>, (2) with bigalloc).
> 
> Filesystem atomic write unit (fsawu):
> ============================================
> Atomic writes within ext4 can be supported using below 3 methods -
> 1. On a large pagesize system (e.g. Power with 64k pagesize or aarch64 with 64k pagesize),
>     we can mkfs using different blocksizes. e.g. mkfs.ext4 -b <4k/8k/16k/32k/64k).
>     Now if the underlying HW device supports atomic writes, than a corresponding
>     blocksize can be chosen as a filesystem atomic write unit (fsawu) which
>     should be within the underlying hw defined [awu_min, awu_max] range.
>     For such filesystem, fsawu_[min|max] both are equal to blocksize (e.g. 16k)
> 
>     On a smaller pagesize system this can be utilized when support for LBS is
>     complete (on ext4).
> 
> 2. EXT4 already supports a feature called bigalloc. In that ext4 can handle
>     allocation in cluster size units. So for e.g. we can create a filesystem with
>     4k blocksize but with 64k clustersize. Such a configuration can also be used
>     to support atomic writes if the underlying hw device supports it.
>     In such case the fsawu_min will most likely be the filesystem blocksize and
>     fsawu_max will mostly likely be the cluster size.
> 
>     So a user can do an atomic write of any size between [fsawu_min, fsawu_max]
>     range as long as it satisfies other constraints being laid out by HW device
>     (or by software stack) to support atomic writes.
>     e.g. len should be a power of 2, pos % len should be naturally
>     aligned and [start | end] (phys offsets) should not straddle over
>     an atomic write boundary.

JFYI, I gave this a quick try, and it seems to work ok. Naturally it 
suffers from the same issue discussed at 
https://lore.kernel.org/linux-fsdevel/434c570e-39b2-4f1c-9b49-ac5241d310ca@oracle.com/ 
with regards to writing to partially written extents, which I have tried 
to address properly in my v2 for that same series.

Thanks,
John