Received-SPF: pass (google.com: domain of linux-ext4+bounces-1675-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <22a24d3c-9d0e-410b-a49c-b89d0c00ccd8@oracle.com>
Date: Mon, 18 Mar 2024 08:22:15 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC] ext4: Add support for ext4_map_blocks_atomic()
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Cc: Jan Kara <jack@suse.cz>, Theodore Ts'o <tytso@mit.edu>,
        Ojaswin Mujoo <ojaswin@linux.ibm.com>,
        Matthew Wilcox <willy@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Luis Chamberlain
 <mcgrof@kernel.org>, linux-kernel@vger.kernel.org,
        Dave Chinner <david@fromorbit.com>
References: <87r0gcn74h.fsf@doe.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <87r0gcn74h.fsf@doe.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VmxvS1JzcnhRQTNTdkxhZ2lCNW9vbmJXZnc2cnA2SGt5SHR4ZDRIZ3pnTFg1?=
 =?utf-8?B?d05Bc29VRjVkaTdSSHFWd0l4NWtjTlVHNXBSb2szZCtGazlJRkJEbEtQQ1Z3?=
 =?utf-8?B?NWVHMTRXYmtzSEZKMjdybWJLWjdOZnliQkxtNTE3U3Q4R2JicWhWdHdNNHVI?=
 =?utf-8?B?dVcwdnBydFk5d0R2RnZoMlI1a0hqS1lwcStlSlJlR25tVmFTcGladFp1Nit0?=
 =?utf-8?B?eSs1bGhKaWdXWHowV1lqNVNuV3RZUDFCbmN6TkZVKzNDMGJvT3pGWUwxYnpT?=
 =?utf-8?B?dWNIT1hjSEs5STdoQVVNaW5nQWQ1ZGtJRm5TWTJadGdudmY5cmdlTHg0dTZN?=
 =?utf-8?B?YkJmMHB2RFlOdFNzSU1LVDBYajBrYWpyVmE4S1lpSlRxQlREZUNWNzhrY08v?=
 =?utf-8?B?Y1NHbmsxeDBOSU1yNVN3UVVySmlPa1ExTVI3WUVDUEUrNkl0Y3NPdXpYRW16?=
 =?utf-8?B?S0huaDRnYWhXeGdsRm0vRDk3d1lRSC9rK2dSZmNWK2JZemtjd2h5Z3ZmUmJ6?=
 =?utf-8?B?VUlEY1ExWmdneGNOdVI4emxlNFVKcnE0ODY0WEwyNUFZTmM4bGFwcFhUam1j?=
 =?utf-8?B?UXpkSlhmYytpanV0Yk16TVhtd1pIQ0xpK2VIa1Y3TjdZcUpXcGxsTlo4WEw1?=
 =?utf-8?B?aUNyU0hGaTFJeHVTcnBmYytldVJLZXI0L1ZYTGdqcXVSSlI5WndpMDVxNTJD?=
 =?utf-8?B?M0ptZTFmMlFXNUVQKzVocFNPMjM1TDY1N2U4UlFmMlZVMjluUVNadHYxN1Bp?=
 =?utf-8?B?c29ORTdTdHFkQmhCQ3MyTFBGL2lrTStZTXZGcGlmODlidDJvM1hEYm1rNE9V?=
 =?utf-8?B?Z3lrcFFYcjlBUGJidXNySXdtbzBDMVlhdTJWM1hmdk16WG1ZTi9uOHdVK2Jl?=
 =?utf-8?B?UW1GYVF4bEVtZ3NlcGVKOXJncHo3VjF6cU8rZkZJeHhRMGVHOXNwSHovY3Bv?=
 =?utf-8?B?TWF1U1FxTmpLSHFTNGU2YmFUWDYzb3g3bk9LNnhZdHBnTXJYcmxWNkhMT2dF?=
 =?utf-8?B?QS8vVTVzdmw1c2ljUkt3Z2lRVmJ0bFl6RXJJNVBFQzNTSWR5UDZzSi92OEFv?=
 =?utf-8?B?V2NmRm9ocUU2Y1A2TWZSK2VCd1RhZ2ZiSlFNZnl3QUVsQ2Faam1wMTA2OGRH?=
 =?utf-8?B?RVd6OGhJZzc0emppV0RpRlZTV2t0L2tERWp4a3oxcVJLM2NKcmhnNmpVbDlL?=
 =?utf-8?B?YXNuWjlHREpmbzZVdlMxcHRXck1VcS9xaGxXTHhvcG1NVFRMbCs1dkpycFNq?=
 =?utf-8?B?eFVIRnVxL0krdGNsTlp4ZHBob2V6YWJhUUNPdmhHUGpjL2w0MXFOVVlJZXVB?=
 =?utf-8?B?cGZRY1dmU2Rmeld0d3lRK2tES3cwVWhkK0pSVHZRbmNoSHg1Q0VTanI2djcv?=
 =?utf-8?B?anNrTkw4cHIvcFNSNGdNQ2FENlN2RVA3NjZkLzdqeVhUZlIxdFdtNGxKWnNR?=
 =?utf-8?B?WmFaY1ZLRE5mSGwzS0RvN3BQUFdiMFVCSW03WnRaMXJxaHRKYzgzZXlRQ2NR?=
 =?utf-8?B?Y1ZvUFU3cTJ2QklWR2VGYURCYWZ5RDBueUtOK2NCa3NTM2p2UkRkd0pwWnl0?=
 =?utf-8?B?dXRJS3E4QXVqQTBSLy9GaDFUV1pzbTVTU2lSMGU0YjltWFFHRkcva0JYUHBT?=
 =?utf-8?B?UjVHelhJOWVvMlY5dWRidmFGeXRmck42TUhEM0VJN1NTME9IeDQwMDh4UkY2?=
 =?utf-8?B?OWFSWjNwbGVhTXJ4ZkNBUDFiUnlYYWZYZ3k5dWMxZmZOL29iamc3VnFDaUox?=
 =?utf-8?B?WXovczBkYVdvQkQvQmtvWjVpa2pKZ0lvd1dRdWw4ZU9sd2pOZVM3M2FITXhv?=
 =?utf-8?B?c201N3phM25XNXp2UmNZMFZ0L3dPb3NmSitqVDR1dkRUMlJQa0daTUo1VGVa?=
 =?utf-8?B?bmY5dGJncTVqN1FNbGRzcVZabllMUEtzSEtlWWpDSzlZSi9wL1JML3l2bU5u?=
 =?utf-8?B?UWlSVFNmYitjeVZqZXRhNzdFbmlYV0hHZW03Vld2V2tCMzdJMlY3Sm5DN0xm?=
 =?utf-8?B?dnk0Y29FYUpUQzFndHdOTW9wVENLNXZ6cFB5NHBCbGU3R3pEYzZGQXhiK050?=
 =?utf-8?B?R0hOanVMUkpuTlpZbVZlYXpyUE5tdWxHWi9hVkNqRTJxTzhna0liL0xKR1ZG?=
 =?utf-8?Q?MnqAPgKidFBtSWkjaqbf2Xu6t?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	a6SjIs3vCbSviNngVL8Y1XPeTIDjmmRZ03Pp64jGb46VmreWNXORqJX4oGyr7AoEEannj1kK0zjyelY7irtchXCZiHCGdNW7mdaQuOJvrwIWfkGxX5j8Q+PhhUG8Pc5ArVmZUh9GcWiBrtufDpa4LVEV2GZu2ZNyFPV+/UECmzDbPQWEeJTSWfRqcCSGhjIKhKweLmpUGkQfaH8QlTHVRnhvueVJkU2fOL9sHFF6S58eWqXbuPK/fvhOS7RyFVQkHeWeZ4CUuF5CItB8iMPl6G0GkvPVVOewROW5q+Enfs5IXzCK8Dp2bCc32w7WRL9CUTxhl4C9e2jcuXAcQFKmt3NBRP2jqo+StpitfshZY26Wz1m239t8vudBL9f9cP8SbPTYzbc3pdqTAetfz8t0wv7W8sgpHP9sLahVq3W7xRwoHabi1d1B73rWRD5PTHtrGPZ9cUe3uV7A+EAVpEVHgWWTCXLqmUiG2uSuxP8p487yPFcR9DKRdjf4k0atA3wakIZioQ2y3iQgHG42yqhQfzvfKR//AMCA4Z+1OGL7Fg25S8eja8qNjs/qWbKlLS3wP3ML1RH6emzbyM5P/3QVUFy/ZX6eoXH11PCCdyicRmM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20fa7458-8ced-4366-188f-08dc4724884f
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 08:22:33.2366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j6LZJyJ1wN1AmV4rnXaTpn1YgCSIsd8gSFU0jP4ZfOs08jV0gJUau+fi0gl/chZxiEww26UtWOZ2bcfNfDTBCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5093
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-17_12,2024-03-18_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403140000 definitions=main-2403180061
X-Proofpoint-ORIG-GUID: 3Xwjhr8jy25G0GTl6TJ4r9KTj7lr6zgV
X-Proofpoint-GUID: 3Xwjhr8jy25G0GTl6TJ4r9KTj7lr6zgV

On 14/03/2024 15:52, Ritesh Harjani (IBM) wrote:
>> and same as method 3 at
>> https://urldefense.com/v3/__https://lore.kernel.org/linux-fsdevel/cover.1709356594.git.ritesh.list@gmail.com/?__;!!ACWV5N9M2RV99hQ!Pb-HbBdm2OWUIGDFfG1OkemtRSy2LyHsc5s6WiyTtGHW4uGWV6sMkoVjmknmBydf_i6TF_CDqp7dR0Y-CGY8EIc$   
> Hi John,
> 
> No. So this particular patch to add ext4_map_blocks_atomic() method is
> only to support the usecase which you listed should work for a good user
> behaviour. This is because, with bigalloc we advertizes fsawu_min and
> fsawu_max as [blocksize, clustersize]
> i.e.
> 
> That means a user should be allowed to -
> 1. pwrite 0 4k /mnt/test/f1
> followed by
> 2. pwrite 0 16k /mnt/test/f1
> 
> 
> So earlier we were failing the second 16k write at an offset where there
> is already an existing extent smaller that 16k (that was because of the
> assumption that the most of the users won't do such a thing).
> 
> But for a more general usecase, it is not difficult to support the
> second 16k write in such a way for atomic writes with bigalloc,
> so this patch just adds that support to this series.

Is there some reason for which the generic iomap solution in 
https://lore.kernel.org/linux-xfs/20240304130428.13026-1-john.g.garry@oracle.com/ 
won't work? That is, you would just need to set iomap->extent_shift 
appropriately. I will note that we gate this feature on XFS based on 
forcealign enabled for the inode - I am not sure if you would want this 
always for bigalloc.

Thanks,
John