Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp78716lqt; Mon, 18 Mar 2024 01:45:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWonW4eLg5O2usj+s5FLwkISnl8ZOWi69Vvg4sp8WEolZhIdXPCOE46z/yd7Z2lyTTwXmHJtVAkuN0Kofp9dz0ueb+SJ6h/m7Mf6NtQnw== X-Google-Smtp-Source: AGHT+IF424vyRpGClRG1nvYHOpVACuQBT2ZSeybnCd2Cxr81HTbWRX3rcZ9uR8aKkV63uoqvWrty X-Received: by 2002:a05:620a:28c3:b0:78a:ab6:76f9 with SMTP id l3-20020a05620a28c300b0078a0ab676f9mr9674qkp.77.1710751508814; Mon, 18 Mar 2024 01:45:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710751508; cv=pass; d=google.com; s=arc-20160816; b=KAufyaKtFuGb3Cowpy8pRjxoW2b+Ra1gTOC3bkO3QySMv3ioFnaMnywI/XAK+uHuE5 sjPXvPs0qk7uIyHOxDaGilNILDmgHDNDAskm/oKmTlVw7Fr9FWp3tWm0X23/Cljnl2ON E92tboEj4jhkxkxOIbnJDDeOBoYJYpnNQQuvuZjc6O9k7nKbnyEof8BUoqLEVxgddKJy mSILYUQvqN49j0rarTeNWAd5zLU4zqzEw0UxkM7T2Vo/pN65mFAhsZ+Z4RVxuCbbpWfO 8y/H6hM9OQJDVpCf0WFo1KHTuHjkkL0UerdeeBlBR+RuP711eE3V8sX/ogF6/HyHPBJ5 A2YA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RaqNTw0ZKjJTL/0d+wWjQ7eQUmzHeV0Qkagt058NXO4=; fh=1hJ5ydSdUbFTEEwBKPYnds0wyH3MSASKb/AEHM9kBv0=; b=uCDt2XG0BUNVRqhjP42iHN9fjOWdYc+xMLT/2HTH74Lne0Ns8qywF5jfuW3ohJM799 ZD/z2hWSTqFr7oNGK09UurM5Xf+mxFTil+o9BYwd5IrxQIhMi2hEmZCNeaPOzKxrp3jc zQQWmJdPAr3VEH/ES3gvS/ThILkzxXaOxpGQdK0epjBktGh6MDl2HVv1kGDDTChWIjY4 NnQAnvsJ37Rq/7+pFeVJJk6/S6owRK5PeqYjT4QhY6QAhfbAaVu8k6lKHYA0jrgFwhEb VUejdbKqLtVmVSYfL/UOyJr2G/1ynIcufn9cK65uak2UXZDKF7z2dMw76Q4lJF73Q8SF XdzQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fChAnfyd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-ext4+bounces-1676-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1676-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id i6-20020a37c206000000b00787e004f816si8924255qkm.207.2024.03.18.01.45.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 01:45:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1676-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fChAnfyd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-ext4+bounces-1676-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1676-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 711101C21025 for ; Mon, 18 Mar 2024 08:45:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60E8928DBC; Mon, 18 Mar 2024 08:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fChAnfyd" X-Original-To: linux-ext4@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D305126AD8; Mon, 18 Mar 2024 08:44:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710751498; cv=none; b=P/stX7nJ9E5CvUqnrit9CrPPucH1tSaXr1XUfH4wT6shddw4mzKQwODnp7IHuIxwdzfj8rfir9aIfpjg00hJuEKIm4YdjAATXHXa6dE60sgJCcv3WsDuZ7qZDVn3cMClfTMV5rSUMq/IT8UkjtbTuSq8pe99Ji0Wz7wKItnEXrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710751498; c=relaxed/simple; bh=1TmE/xqIyypclwlllLbD4j8U75v6abiKzNmNwMS0poU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=q91rc4kFn1XZxR68W3b68c6hlXI6rTcvNtn1eeKpnAgVC1oky82eYYPtTjhrdD1aRig0EPAW4E/5jeGHOlGDjCo3VlFje26fVR73jH2rMEbdHCAlkglTNkGnLd6DN1KmGwt9jZKtgMR27s7m7duDz8ybphg5x6q8vNvsb5ZGaWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fChAnfyd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58EEBC433F1; Mon, 18 Mar 2024 08:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710751498; bh=1TmE/xqIyypclwlllLbD4j8U75v6abiKzNmNwMS0poU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fChAnfydv2Sa+/WKTFpa5ogjlTfuna7SuStKu7bp2GJ3JC8mbntUUN5vKZXoXF6zq zjAz/WW9W5515GbqdQF6OA2CcDVKGdrH0/3ado6f7B9Hby3o0KV9BXna5qSn7O8a8l B2BI1WK83nJWQjGE2hXsv7QRGi3Te4cJTCEu9DuZuCctSuQt9f89VvPOYm/TG6NFih IeOOfPE66rxG22aAgERjOLFtoi6B33rFYaBF7B9l+I8NF2DClm6DHa41xarMwQ83IQ XoEqHxQpTI/LaAgRe6QLV7wXPvgBeeBSqn5nsI0jauqmqq0SdHZ9R7vqkTtmvxHbwA UpBFDsyRLDsTw== Date: Mon, 18 Mar 2024 09:44:52 +0100 From: Christian Brauner To: Max Kellermann Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, mforney@mforney.org, stable@vger.kernel.org Subject: Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled" Message-ID: <20240318-auswies-poppig-6ad4f7d0665f@brauner> References: <20240315142956.2420360-1-max.kellermann@ionos.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240315142956.2420360-1-max.kellermann@ionos.com> On Fri, Mar 15, 2024 at 03:29:56PM +0100, Max Kellermann wrote: > This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The > commit caused a regression because now the umask was applied to > symlinks and the fix is unnecessary because the umask/O_TMPFILE bug > has been fixed somewhere else already. > > Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/ > Signed-off-by: Max Kellermann > --- Looks good to me, Reviewed-by: Christian Brauner