Received-SPF: pass (google.com: domain of linux-ext4+bounces-1806-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Luis Henriques <luis.henriques@linux.dev>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Wang Jianjian <wangjianjian0@foxmail.com>,  Ext4 Developers List
 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] ext4: Add correct group descriptors and reserved
 GDT blocks to system zone
In-Reply-To: <20230817170557.GA3435781@mit.edu> (Theodore Ts'o's message of
	"Thu, 17 Aug 2023 13:05:57 -0400")
References: <tencent_D744D1450CC169AEA77FCF0A64719909ED05@qq.com>
	<20230817170557.GA3435781@mit.edu>
Date: Mon, 01 Apr 2024 15:23:52 +0100
Message-ID: <87ttkl6u13.fsf@brahms.olymp>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

"Theodore Ts'o" <tytso@mit.edu> writes:

> On Thu, Aug 03, 2023 at 12:28:40AM +0800, Wang Jianjian wrote:
>> When setup_system_zone, flex_bg is not initialzied so it is always 1.
>> ext4_num_base_meta_blocks() returns the meta blocks in this group
>> including reserved GDT blocks, so let's use this helper.
>> 
>> Signed-off-by: Wang Jianjian <wangjianjian0@foxmail.com>
>
> Thanks for the patch.  I ended up collapsing the two patches into a
> single one, and then fixed up some checkpatch errors.

Sorry for revisiting this old thread, but it looks like these patches
(commit 68228da51c9a "ext4: add correct group descriptors and reserved GDT
blocks to system zone") broke fstest ext4/059.

A (very!) quick look seems to show that it's related with the very fact
that sbi->s_es->s_reserved_gdt_blocks are now taken into account to
compute the number of blocks (which is the point of the patch, of course).
Maybe the test needs to be fixed, as it messes up with the GDT reserved
blocks...?

Cheers,
-- 
Luis