Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1805018lqz; Mon, 1 Apr 2024 19:23:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUs9DzDgr2bklZfHhM/9RQMlc1+6D/Gz0AkUQuzYsSaosgdQ42jzd8UeliG48P+x6DJ9UFCrgdjZ01OM2pxOXW86W01+ncxGmhWquk5PA== X-Google-Smtp-Source: AGHT+IFnpE++RWnFKszVoPWmu0Idb+qOOOQWiLGIoGcLRxFblj0eiaJ0UoqeQRSrDtxLdK//aYGk X-Received: by 2002:a17:90a:d193:b0:2a2:414b:ff78 with SMTP id fu19-20020a17090ad19300b002a2414bff78mr3057283pjb.44.1712024604763; Mon, 01 Apr 2024 19:23:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712024604; cv=pass; d=google.com; s=arc-20160816; b=InaJzRYcqrINFxnzJPXNQ9HfDpyXMPkDKgxeW5vkzBtj9Vkw9DFV4kdRYZI3vwDBvs O4XpWHyoKtCuaR6p4abw8lJ/7Q5nCagM0oFoqxUBtn+4mdJNV7V+oyVxYyZ7OdOM2heQ 7NT/9b8mc42Unkwyx/tdcsXZAzZyUhgMkY7m6lkToP9XxbGucuvII+B93soqiBo6pCJ4 Z5WbhSh2ftskzU+fTxc/5rXwSTrNJYFOUOYK+LwVDebdpaFPNipl56XbMwcRDVZS20ad JBLahmh9NO6IcaqcRHJlCGuQsC83JHxSBish41cz+ZEruB9MgUT6LzcY1Ll/C4IEy6l5 MMug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=yTG340g8kByreiVy143nHF54dO9lw3XdxIixprKGw38=; fh=ICnGcGdC7Ak1/H+DrSY3RajhWH4HNxoziYjAhHP+d6I=; b=XVNqohOUo0cKi6RNzTTol/QG01PirCLjxCPWbg8csAzTnSH0LfEqaUKwUDx8hRJXwW NHWeM3Y9cKhHFFDZ0T98uNLOUiYol/TvnPlt3Gt4nZVEVDXr1iDKDE9O3r/UWYVwSNcU MCbg2of1D8cyTX9qlKsfopt49gfjvZC110BrUpg+YPyg2IxXCIYsKNMRv1pG0yaRPmiA Xs41idc3pOWeQkMMWXiRTWJUce+gcQ3VjPli584sb0vg/m6516wTiyhqq6KmYc0ZmUNf 3hLa/VVgrEuo7M2TWw3L7Qlw9pAsqK04aB+gJg00iKQg1vcvRN4OcXK8F80lsyC+hu4S xKog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-ext4+bounces-1813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1813-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id nv2-20020a17090b1b4200b002a23cda1a8esi3381564pjb.19.2024.04.01.19.23.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 19:23:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-ext4+bounces-1813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1813-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 729D62869DA for ; Tue, 2 Apr 2024 02:23:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A522DF51; Tue, 2 Apr 2024 02:23:18 +0000 (UTC) X-Original-To: linux-ext4@vger.kernel.org Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id C1502DDA9; Tue, 2 Apr 2024 02:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=42.101.60.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712024598; cv=none; b=esrQQqlnUobQuzzLwCiPtjcdZbgQ5EeYhpbXl8gdsjkYHqpW5dHPv1/ZbTrHcos7Gf6fxqw0jSP7G0z/2C0PMwGeIVWKLXTy96G4/NRhH/Q4+Tz5wmbpmOtbe1hwab9xeEuTDGlhuLoAfoUrTBwpCnrHp/w3/Gv5am2KTCBAyac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712024598; c=relaxed/simple; bh=lK3dB+eY3hL7m93zgy5ec2mL/lUb+/06ViM6WyDGPNc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=pZn65deEiZ1I5aFAC9/TxnRSbFMJ0GGgv0BXo4EeohJl57/nT/qcQvRw+Xcj6bmtMU8oFRRGo0MixshyZK2wW+7E70/JQcYWDxf5kz9IulajcXfh1uC4/6GzStu2LlJuoioUNOpw7ibKYlnUGS8RxHAUqSsU+szZk07pHPLWFf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com; spf=pass smtp.mailfrom=nfschina.com; arc=none smtp.client-ip=42.101.60.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [219.141.250.2]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 999C46055052C; Tue, 2 Apr 2024 10:23:07 +0800 (CST) X-MD-Sfrom: zeming@nfschina.com X-MD-SrcIP: 219.141.250.2 From: Li zeming To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Li zeming Subject: [PATCH] =?UTF-8?q?ext4:=20block=5Fvalidity:=20Remove=20unnecessar?= =?UTF-8?q?y=20=E2=80=98NULL=E2=80=99=20values=20from=20new=5Fnode?= Date: Tue, 2 Apr 2024 10:23:00 +0800 Message-Id: <20240402022300.25858-1-zeming@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit new_node is assigned first, so it does not need to initialize the assignment. Signed-off-by: Li zeming --- fs/ext4/block_validity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index 6fe3c941b5651..87ee3a17bd29c 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -72,7 +72,7 @@ static int add_system_zone(struct ext4_system_blocks *system_blks, { struct ext4_system_zone *new_entry, *entry; struct rb_node **n = &system_blks->root.rb_node, *node; - struct rb_node *parent = NULL, *new_node = NULL; + struct rb_node *parent = NULL, *new_node; while (*n) { parent = *n; -- 2.18.2