Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1832014lqz; Mon, 1 Apr 2024 20:55:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWmufK+K1NSNEnxGHxgMBMENkWw+A3UOGtpc+KAlW0aN1pwsxEexNxM2x+7HeiJmh+yeybNQI4fjGmh6gYQEoUpTaimxIWK8fK49uZQaw== X-Google-Smtp-Source: AGHT+IFqMOIn+Z4lljiW65OP94bBm74AXaag5qWLrH3oLoRUs8W5tgF3AJxR399XkQ43F3cPFGxw X-Received: by 2002:a05:6a20:3d0a:b0:1a7:23ae:4421 with SMTP id y10-20020a056a203d0a00b001a723ae4421mr184333pzi.24.1712030151051; Mon, 01 Apr 2024 20:55:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712030151; cv=pass; d=google.com; s=arc-20160816; b=S4Xi9+nw+bXWQHf0EE2qkqTSZbCLEgi93mTp0iPQqwYxBPrPMHlcHQXD38IGednn9+ SVzOtityaw4T/A9q23nuADJa8masnnDd1q1gTpUj3rFlIy26T5m0SpT/1wZqt5uwIMpi zpc0wiYy9pt2nJrwh247g/IYqwlRRI0LekRziU4CFYpQK1ODUxg/7O2KC3+CP9o6Zc3V m8IiVrHiWYPLNhmpkw9UQMRp1XIsODspoR3JIed7XTQPGjt3T7FAiwqR5R/zRNYAaMr1 PxHBYB/fp57rrd9a4ZgtgmQFUSxS+1ii5BeC1WQ0FR5bRR7m6TIDuY0JHAWjYa0badFA G2iA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=W9AENbMZ6T30aoSARNRXwRAqIqETtvwIKmOEx7j/tuY=; fh=2/qP6XTRrrgeiTM31Pq2AsKAteG/zgmNKSGuG6O5gRg=; b=xYhmhApfv0EAwJmEKffiDwtJ5mcQQkvxsXjKomw/VdW0aZ2YbDVhw0Q1YQicUTh8xF ktOgtl6D3t/1LpggI7dmOT5D3HRuAFrhyJRdVRcWH8RgnGRoXXjiJcARLUAHFq75iheJ JgbEho5DX4mbgyTdjbvnWnYuOZSO1rYqWdTnrKnF+aZV+UymYx07tkcnuVrsjTQyOZd7 P2JnCGslIn4CYEcBhLNFVCzIg+1fGVJ3dK2F0prZl6c/UkVGe8BJA2ybJmG1aAyGaD0G ijx6m8162XK8MGVA7j52chb8P9+F5VIGF5/WtBgaiV3p2AoalzvXdn+hB/WyZmlELu8W jtSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=mlNKUkcH; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1819-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1819-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b28-20020a63715c000000b005dc8762dce5si10834347pgn.51.2024.04.01.20.55.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 20:55:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4+bounces-1819-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=mlNKUkcH; arc=pass (i=1 spf=pass spfdomain=mit.edu dkim=pass dkdomain=mit.edu dmarc=pass fromdomain=mit.edu); spf=pass (google.com: domain of linux-ext4+bounces-1819-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-ext4+bounces-1819-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B2A26286B42 for ; Tue, 2 Apr 2024 03:55:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9056217597; Tue, 2 Apr 2024 03:55:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="mlNKUkcH" X-Original-To: linux-ext4@vger.kernel.org Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A43CE17BA7 for ; Tue, 2 Apr 2024 03:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712030146; cv=none; b=Brm8WvQmGoexXJ+e2fCE2sdwFZh1H+0EhOPIURgSphlNnwAFLFBveS2hsnSlgSIxU9djUYAkL7Sf+dFdPcx9474Deqvg/cSnbBqyBLI6vzsCtW7NT0T8VrSiT3kwx+suVHqR1rG3+EvgUEBAxrddLXSOGaepj291VJMg4UwRCfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712030146; c=relaxed/simple; bh=Ovu1Zl+lRgprOnzlsNT9/gVbAYFDS0biN7y4UFFEcHU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MOWB2V1E0XWQFmbKI7iEBPHlcewwdJmYKt2+u3nJCjLOrL5M/sJWWUYFQfMQrrvdPoa09hHUNxM8Wf4RIMFOEvKhYbxR1MYZiJMa3IXBb9cWKpr+DR+m5kb7dUgM5jtEoNVewkfCbEHGhFX6U++iGgGFA962jq7eunxUFiDP3Fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=mlNKUkcH; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Received: from cwcc.thunk.org (pool-173-48-113-232.bstnma.fios.verizon.net [173.48.113.232]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4323tZ1X028188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Apr 2024 23:55:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1712030137; bh=W9AENbMZ6T30aoSARNRXwRAqIqETtvwIKmOEx7j/tuY=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=mlNKUkcHa8imT+MUvtaDgSMiaAu2/xGV4g52aaStjZY8Nw1CwonKD26oTyR3hX48T 9mAJLdZmns97uBXH4lxd+NOW4QFScUDx/iDZIyzoKps4yGPd3fZAp+7VScuhbUHXqu nIU+HxTCv6yR+ZR67bfgmASjrIKh6NH0ueofbRN6D8fd1NLKS2ggDEYAGeVlgwGD/f +5/Q5gW0A50GnfO9htePeNKDo7xoCW1VEXIBF51zjgdaueZ4y09HAYUT/UJrjx6pgG Erx/NRv//OAmc65/XeKDfkHLFdwDVUJ5/UzHus4jnb6uQXUdoVGKMzj04zS9s2sduz pRfXKtNCcm85A== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1642A15C00DC; Mon, 1 Apr 2024 23:55:35 -0400 (EDT) Date: Mon, 1 Apr 2024 23:55:35 -0400 From: "Theodore Ts'o" To: Li zeming Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: extents: =?utf-8?Q?Remov?= =?utf-8?B?ZSB1bm5lY2Vzc2FyeSDigJhOVUxM4oCZ?= values from ablocks Message-ID: <20240402035535.GD1189142@mit.edu> References: <20240402024804.29411-1-zeming@nfschina.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240402024804.29411-1-zeming@nfschina.com> On Tue, Apr 02, 2024 at 10:48:04AM +0800, Li zeming wrote: > ablocks is assigned first, so it does not need to initialize the > assignment. That's technically true, but the compiler is perfectly capable of optimizing it out. So it's harmless, and removing it does make the code a bit more fragile, since it needs to be set so that the cleanup code doesn't accidentally dereference an uninitialized pointer. Cheers, - Ted