Received-SPF: pass (google.com: domain of linux-ext4+bounces-2029-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 11 Apr 2024 09:57:23 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alistair Popple <apopple@nvidia.com>
Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com,
	jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org,
	linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org,
	hch@lst.de, david@redhat.com, ruansy.fnst@fujitsu.com,
	nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, jglisse@redhat.com
Subject: Re: [RFC 10/10] mm: Remove pXX_devmap
Message-ID: <20240411125723.GT5383@nvidia.com>
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <93e3772f172918a3c489d803f7580309c3a42fff.1712796818.git-series.apopple@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <93e3772f172918a3c489d803f7580309c3a42fff.1712796818.git-series.apopple@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?f9DbSThLRrgiUx0FUPjzZHQfypbwrg69X1aHOadTnZrsMNZuRP0ZV2nOu49l?=
 =?us-ascii?Q?bLGVgJgTncsXV4Coqf0htqedS3LvCNX1G7g2NRDZoUPyg+P/6F7kOGhAGZvV?=
 =?us-ascii?Q?TR6CM8y6OFdhps7NXBqnLt9mi4paQXGnkFhsq0nlfqesmJraq0r2wNHSVGak?=
 =?us-ascii?Q?+cU44IPq7iQNQxlOLWmWXSTD2D87hzlJn1cgTblT4usrtu3zV2yorqfz09wo?=
 =?us-ascii?Q?Ex/4/1yfMzWt7G5zYgBN509IodOStwIIqBDJtmBFvsaMlZzYCOItlQk2f5A4?=
 =?us-ascii?Q?36m0V8KWgW6KC/7tF/yHccdYqSxOyCzgsCrOk3auuyQqaR+8OLgg0FSRRqIX?=
 =?us-ascii?Q?S2Ic7z4jN5Q8acmNOrLUc5IfV1qrYrRzZhP4209vIpQvWK6izQW0mC4TuDJG?=
 =?us-ascii?Q?PjViD5snXe3FL/M++A8QJyESgdgPB90n1CdazhCwG38VuSN8UR9s69sd2QaY?=
 =?us-ascii?Q?+65FgKEW4cxCl0XtyC0ktBimHu2lMhcHuV6o7ofhsZlQdpRjtR+yPUwL7Mpo?=
 =?us-ascii?Q?K7/xvHpRzv9m77VvVg8MSVHihde9dPeDw4/xywUre8WzXCSvFWX/e0vz7DO4?=
 =?us-ascii?Q?QG5WRxfcP50jb+N9bo1UQwfqXoyucMdooj6zAJab0UfQJbHcoNKyFhjZOlnD?=
 =?us-ascii?Q?tVDla8keWQrMQ2wxuHyhWxzeTHr/FY17oCYS+3jPHxPsfuwueoGqC0btZBDL?=
 =?us-ascii?Q?kZIX26V0eSakPuLJwb+GhLHcANHTDCUOn5fCGWoi/HLETwDQp5dgWykOMHLG?=
 =?us-ascii?Q?/clvT+VdpMQVtARQvfARHM31dF/epreaYp63LzSezQTl+tBuU47DM1Juk8uh?=
 =?us-ascii?Q?7QdRbtwShZCkHdsWir2y/b+NTUDdHJdVK8y2axvpIr544Qgh40MhXFkvU8/P?=
 =?us-ascii?Q?NHxpK1d9olUPl5D/DiONAI7yjZ3zEMeaulQcTdg6wgDjwNCJQiI6MH0evenR?=
 =?us-ascii?Q?vY22VqaEPWcuRCBdHi+Z65hLcyLqWlp2EAhAiWf4EmkVASMBofhqL4fgPIAI?=
 =?us-ascii?Q?FZ2kXn7s9K+ngDVn93jN1uIObLYXr5cSFWXeDtL95bSC3NdvtlWhrgkbSic4?=
 =?us-ascii?Q?jR49850gEaxfH9s2en8DJ7ttHXNbLxXTYNm98Ci1ZxX8ws86KMG4glVcJkJX?=
 =?us-ascii?Q?zancoy1Bo4r4QfPFdZqPemZNdOFGm0JVvGqvDC9F6OpPSQwx9ryYHGMJH6qh?=
 =?us-ascii?Q?i9aGEnYvPzCICre+m6/57s3/CiBviJYyP3Ike7gZyVOgakbB1is+mvLxKp5e?=
 =?us-ascii?Q?AmApNXfNi96g0hOiJc+USlft+EfT7t0YJB2H65wEZWF9dEur6qoYvEvPjd42?=
 =?us-ascii?Q?fE3XqoSW8t7m2C3blVr2YQCbDs4vZJizeR65V8h+vLr5RqNXITWBhXxFyv4y?=
 =?us-ascii?Q?Si+fMxarPhRjY+BYDXSpnq1kpKgP506aqf5+67/mtOXizTvT3OzevPaNskkJ?=
 =?us-ascii?Q?TBZm7LITgD5owDOXgwm4y23KnDl2wh4tVR7+D0447k7mXvKqyvnWexMOexpC?=
 =?us-ascii?Q?RuOLqUY+Sm+rE6NMHk3sGanoMqBEdWO2h8udCealKsAVjlJ9ZD3aw5g+S1Bi?=
 =?us-ascii?Q?J2MfqzIXxio4k8Bi8u6sI4fBpG51lhUtPJbiXWBH?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35cb5d5c-f4ec-44b2-fd46-08dc5a26ef38
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 12:57:25.0076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +wUFtcUf9WoDwW/GsdClcgjw/pfBxcR1m1bVeBOEF1UPuUmJgXL8CLXynMzY7jrz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8520

On Thu, Apr 11, 2024 at 10:57:31AM +1000, Alistair Popple wrote:
> The devmap PTE special bit was used to detect mappings of FS DAX
> pages. This tracking was required to ensure the generic mm did not
> manipulate the page reference counts as FS DAX implemented it's own
> reference counting scheme.
> 
> Now that FS DAX pages have their references counted the same way as
> normal pages this tracking is no longer needed and can be
> removed.
> 
> Almost all existing uses of pmd_devmap() are paired with a check of
> pmd_trans_huge(). As pmd_trans_huge() now returns true for FS DAX pages
> dropping the check in these cases doesn't change anything.
> 
> However care needs to be taken because pmd_trans_huge() also checks that
> a page is not an FS DAX page. This is dealt with either by checking
> !vma_is_dax() or relying on the fact that the page pointer was obtained
> from a page list. This is possible because zone device pages cannot
> appear in any page list due to sharing page->lru with page->pgmap.
> 
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> ---
>  Documentation/mm/arch_pgtable_helpers.rst    |   6 +-
>  arch/arm64/include/asm/pgtable.h             |  24 +---
>  arch/powerpc/include/asm/book3s/64/pgtable.h |  42 +------
>  arch/powerpc/mm/book3s64/hash_pgtable.c      |   3 +-
>  arch/powerpc/mm/book3s64/pgtable.c           |   8 +-
>  arch/powerpc/mm/book3s64/radix_pgtable.c     |   5 +-
>  arch/powerpc/mm/pgtable.c                    |   2 +-
>  arch/x86/include/asm/pgtable.h               |  31 +----
>  fs/dax.c                                     |   5 +-
>  fs/userfaultfd.c                             |   2 +-
>  include/linux/huge_mm.h                      |  10 +-
>  include/linux/mm.h                           |   7 +-
>  include/linux/pgtable.h                      |  17 +--
>  mm/debug_vm_pgtable.c                        |  51 +-------
>  mm/gup.c                                     | 151 +--------------------
>  mm/hmm.c                                     |   5 +-
>  mm/huge_memory.c                             | 100 +-------------
>  mm/khugepaged.c                              |   2 +-
>  mm/mapping_dirty_helpers.c                   |   4 +-
>  mm/memory.c                                  |  25 +---
>  mm/migrate_device.c                          |   2 +-
>  mm/mprotect.c                                |   2 +-
>  mm/mremap.c                                  |   5 +-
>  mm/page_vma_mapped.c                         |   5 +-
>  mm/pgtable-generic.c                         |   7 +-
>  mm/vmscan.c                                  |   5 +-
>  26 files changed, 48 insertions(+), 478 deletions(-)

This is great

I suggest splitting it up into two parts, remove the functional code
in the core mm calling these functions testing and setting pXX_devmap
(and maybe this needs several patches for clarity) and then remove all
the remaining dead code once all the callers are gone.

Jason