Received-SPF: pass (google.com: domain of linux-ext4+bounces-2039-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 11 Apr 2024 14:35:59 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Alistair Popple <apopple@nvidia.com>, linux-mm@kvack.org,
	david@fromorbit.com, jhubbard@nvidia.com, rcampbell@nvidia.com,
	willy@infradead.org, linux-fsdevel@vger.kernel.org, jack@suse.cz,
	djwong@kernel.org, hch@lst.de, david@redhat.com,
	ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev,
	linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
	jglisse@redhat.com
Subject: Re: [RFC 00/10] fs/dax: Fix FS DAX page reference counts
Message-ID: <20240411173559.GX5383@nvidia.com>
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <66181dd83f74e_15786294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <66181dd83f74e_15786294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?qPn8+SpGrdhxfW5YYrcDwadj1neaAe3JyAUFXEDoAUANt88bp0lllP/tzvYB?=
 =?us-ascii?Q?Xx3j3zSxL/tdteTxtitOrTxlYPr/OHm8pkFV9QpnG2F+4CMeFafjK3+E5VUj?=
 =?us-ascii?Q?cs2+yPEZ+FgBpZFTduXrkuPf8ep7as+wi3+tqXSNxv5EJbhsx+9YKIeA9l5M?=
 =?us-ascii?Q?gni09r2Imzenf5qLZv0zYfNXl2rBI3y2iIebtIwewtI7pA2AvvOoSvP8b4QW?=
 =?us-ascii?Q?Wk57fR0zl79wBmbl+237JiwTS5rdO2Y7S4Moj9U/VXMLCZNjCH7Q9pxaKClX?=
 =?us-ascii?Q?Rng5dYDBLyBXdxzPDuv+rMQ4c/P1f+aO+QE+mDEjGBYWhV7dIyrfMrLPsbbM?=
 =?us-ascii?Q?5tFT9BKwHi6VhCWF4tQoSaFLzRUlNrShw0Q23vTobrcMq9JTWGg1l/T9qT6g?=
 =?us-ascii?Q?vLuXylVYlQs7ZNesCb4ahsJb14LkeMm81EtHKWCAFOU3CLHlqSYv2GJsj4Oe?=
 =?us-ascii?Q?wnU4oEe0yJpATz+5BZcAU48WtTzpVqwH7OR22Oq3dUxLVr/jlq4dfOZwzX3G?=
 =?us-ascii?Q?IXa40EPcrbJ4+LFF05rqCYKuCtWuOE6+zXazKTybLkD9lau1l7rEOlmECtHj?=
 =?us-ascii?Q?yewgwaF3+pcASYFlBciPM1dd4ux83rIxbT3zv7R31muE0GI1ByaoZkRq4dJR?=
 =?us-ascii?Q?JTpYNPHi/sk72A0+CZ+f2yfZ9zYPR9b6sOk/JvbfjUEQGAAM2wJJ7S41Azet?=
 =?us-ascii?Q?FjVE4IdA2i+ZqNfSqy9cyOQn+5bS6GVZUQ0kJvvUtNtK1cWSSuY0Ao5feVBH?=
 =?us-ascii?Q?88ScLJfz1HnuxWA+l39iY5PT9m6/bGZ2FWeWJsmA3AAnf+hX94jjSZ+xsqSP?=
 =?us-ascii?Q?CE3zkXA0VVbvdV2wpUQmL/1g1nXZGyrRtFJI40SAXZQIuKOav+Ux4X8CokkI?=
 =?us-ascii?Q?gQo3KtBpo5mcYKxQUvhVFEDIoTCqZcaz9X9QdRwdPS0McwZLFonrmq8o+QCj?=
 =?us-ascii?Q?m39InTiTrPb7EuMj1R+YAmQ0dxnnu/Ok3+OcToKMp+s5QxW/VS+R86kofNGc?=
 =?us-ascii?Q?p6UIMTAuiWcbDhe+M+ShFynDLrIV4W4Cj9e+zNQaitnKXicDTmlMho5VVBMS?=
 =?us-ascii?Q?7igAtlRzVOXbzQaT/h0ufDSTalBxvFsJscJ4wMyJqGWCe30m1S5Hh4FZgOFt?=
 =?us-ascii?Q?HzFdbTvUYJVFRd1X7d7puJARayr8Tai56w3tKbtwdfVEMeV1FwISY8OEqJfy?=
 =?us-ascii?Q?Kduo2Hc9LRkLI5hlLFGkv7PmeOsCR4uqdgYdy6Bh3k/EreG63JSishqkNsZD?=
 =?us-ascii?Q?Q578BOQWxWukMEWXP9NAVXy+zzsLVlr6r+QMxahOzUoJFYZouzdP1mBRlO8e?=
 =?us-ascii?Q?VGei2Ge+PcRWrcQ/hAUsO8Ar3pjfvPdp99VjBAf/CaiuBLvXlfaE1xV6bFOB?=
 =?us-ascii?Q?EVQqkd5P3BcHYm1WzUc7q+2j5O2TR5ng/Wsi/si8EgjtH2xm4GsEOyhD7dM4?=
 =?us-ascii?Q?nIKN3+dKkrxi4LEfBxCiG8fsBUsw9zouyqRVM7zMzmvzqxhPMV1bVcT0JDl/?=
 =?us-ascii?Q?Zmw4H+5oWRcmWjoyP21xGDAYJWKIW3yVBt7VhIxLx3XUcs5vcD64IgFLSL6r?=
 =?us-ascii?Q?Q8OJd4TcxdKWv/fwWFlCL+/8XSXP10EmJoyXucZN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2c1154e-8c8e-4df4-6316-08dc5a4ddac9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 17:36:01.0556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O+q5WH9Yxrp9r9txOgQ8Zkx8Gmx0E3f/eA/HkFl6ZRD+po/oUFXptYhFpnohFE7R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6455

On Thu, Apr 11, 2024 at 10:28:56AM -0700, Dan Williams wrote:
> Alistair Popple wrote:
> > FS DAX pages have always maintained their own page reference counts
> > without following the normal rules for page reference counting. In
> > particular pages are considered free when the refcount hits one rather
> > than zero and refcounts are not added when mapping the page.
> 
> > Tracking this requires special PTE bits (PTE_DEVMAP) and a secondary
> > mechanism for allowing GUP to hold references on the page (see
> > get_dev_pagemap). However there doesn't seem to be any reason why FS
> > DAX pages need their own reference counting scheme.
> 
> This is fair. However, for anyone coming in fresh to this situation
> maybe some more "how we get here" history helps. That longer story is
> here:
> 
> http://lore.kernel.org/all/166579181584.2236710.17813547487183983273.stgit@dwillia2-xfh.jf.intel.com/

This never got merged? :(

Jason