Received-SPF: pass (google.com: domain of linux-ext4+bounces-2041-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 11 Apr 2024 10:56:35 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Dan Williams <dan.j.williams@intel.com>
CC: Alistair Popple <apopple@nvidia.com>, <linux-mm@kvack.org>,
	<david@fromorbit.com>, <jhubbard@nvidia.com>, <rcampbell@nvidia.com>,
	<willy@infradead.org>, <linux-fsdevel@vger.kernel.org>, <jack@suse.cz>,
	<djwong@kernel.org>, <hch@lst.de>, <david@redhat.com>,
	<ruansy.fnst@fujitsu.com>, <nvdimm@lists.linux.dev>,
	<linux-xfs@vger.kernel.org>, <linux-ext4@vger.kernel.org>,
	<jglisse@redhat.com>
Subject: Re: [RFC 00/10] fs/dax: Fix FS DAX page reference counts
Message-ID: <66182453df757_15786294f5@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <66181dd83f74e_15786294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <20240411173559.GX5383@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240411173559.GX5383@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZLP3UoZ6+Ro82jeN+mpOjgFMEl3J/PFaTkFia/jJFa1LA2htcFVZrHIyQxet?=
 =?us-ascii?Q?zoSGD5+G8e5CtQOOW9FiYRLplmPR7XdjKDljaCOzwouRx0dTWvrzlUscYkUQ?=
 =?us-ascii?Q?mhXhnDdby6L3CBWRwbeOeMhZ4pCFh3tgntURyXEFzWNskj7VeQVqaZ1rA3ni?=
 =?us-ascii?Q?xx4NZwBzufbA4Zrmye/nBiwYlH4p2UgroSNFhdkbtM/lzs54ZcFRcspxR780?=
 =?us-ascii?Q?FObePwh68hDhXNRukpMbSHDYxGgfJtCODg+bkUEIh/FU0UZ1hHoYEreAMXAG?=
 =?us-ascii?Q?JXTStOLZ53gIJz6joasQ2BY4w+egDMOQAq58erlxrOppM+AXGmJlwK8BsTjd?=
 =?us-ascii?Q?KmMSqKFPR1T8vlgjl6MooFCfN28eWeDxntk/4dLfS9tTCnhgKrVaxSuij1an?=
 =?us-ascii?Q?9zzSnHQRzggnwx8S3FPOKIIdOLKHQmObZOZ3weLsrtkXwj1g77bHBGPbaTEY?=
 =?us-ascii?Q?pg5+KmLM1RxYZkL3jLE5ofIOMLgAZWiUVC1qrzmbNo9r49gGSZTBy0f9n2cs?=
 =?us-ascii?Q?0Q6+kwSZeAV37sagxfbh25Qz8zJNq75viE/0taNz2VdSNMo1EtY1Z6sbQvhE?=
 =?us-ascii?Q?DCQNKJPN8gwOE7/2Shq1bdI0J/iH8c12DSk8gDrOzTBe3OSjabluJfZVhmOu?=
 =?us-ascii?Q?rnMnZcGQ0pk7xp0B6585UNDWX2UCWZEDi/AnvA/L+CqD3WWqNSeTr8fOIoDj?=
 =?us-ascii?Q?84HzUOsx9wUq8rUYfnNJXwtrkrb/MwzNC9DZeNzeg6ujrF6WhIhOaaQvvuQI?=
 =?us-ascii?Q?NKFx5QfBDEe12maiDMiqNr/PqNH+RTO3RKxrTf78NtxgSeF0uNj0roSKEjhC?=
 =?us-ascii?Q?vIAYkDNc/p05RigqJmbFsxukrZRUXjSsbevgsxNo3l5UTGp7cnxMsaO19GzK?=
 =?us-ascii?Q?2ZbJXSX4VILwz2LV0jZUYyyprVfWA5ABupaqdDWr8rewH16iXc10BG7hTjdw?=
 =?us-ascii?Q?AClPkcOxe3H3JhZJ0um7yGpRCWkvUUEbEjvxfkeygkqMaXAgRFcWhblRSXK5?=
 =?us-ascii?Q?j7z7rp5CAob2ZPHcWu5OQcvtRnsvHYnjEUnfQ92/AOfLNfYnMUzHIG/mtxwG?=
 =?us-ascii?Q?rfF+IR41OL5CHtCOGPdAlHWpn/H6Ehq4JQdXUiIOQl31+DeZsyKeksRiAyzd?=
 =?us-ascii?Q?LpK2YY3Lf0Iqd3fcmRgGNaz/j7gT62G+/IL2tuxHxyGSLRBZATu8OdCTu2fM?=
 =?us-ascii?Q?Fr/t4+aRfESVThckHriwUKggsy4bQGFvoJi6OmNgXTW9eM2w4XXejnEU23mO?=
 =?us-ascii?Q?DfugB+CChsGsgKNCiqQ5qXbOTndx/kp80umWyXSy9ocNxItcNh/wwcLMiKvf?=
 =?us-ascii?Q?zCXP6BFgCvQeXd1axCbMTmSRsM/qruP2HQ25yMJAGG6r7q5Y4z/0M3R/F8Pm?=
 =?us-ascii?Q?9c0hfjuCQwBuCgoAfdxbCxKPYL8kvjFpxFJvCMg6HjUu4dXaEzUPhxd5SKSA?=
 =?us-ascii?Q?hFsaZ9Tik5STiEHXUV6SRZ6MqYxrZKRYinyxVC9lFY2AVxkoNKEiii3q2f2E?=
 =?us-ascii?Q?TYvLdYUxhKlV6QEDDeB3u2I+yKQ+Y6Zb+ClgFIiIDPIyCOiXV8GoCTIGq2HI?=
 =?us-ascii?Q?1s2EV/Cv7KSvAtePak/xbm74ZmwT1J70ZqB7Mek9i7ErHRQfyxn/P3c1Hrab?=
 =?us-ascii?Q?CA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: daf3e89a-4da3-4ec0-985d-08dc5a50bc76
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 17:56:38.6959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i6N3wBKHxrFFK7s6K0Nv3htbb1XMtvhMc0JzMCXIg64WzeH0t1i/PvT9Hh002PRaTbmRQrcpVNJ/LA3NswCMlZBM7/Y2dpuEsMG/y7hmNic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6719
X-OriginatorOrg: intel.com

Jason Gunthorpe wrote:
> On Thu, Apr 11, 2024 at 10:28:56AM -0700, Dan Williams wrote:
> > Alistair Popple wrote:
> > > FS DAX pages have always maintained their own page reference counts
> > > without following the normal rules for page reference counting. In
> > > particular pages are considered free when the refcount hits one rather
> > > than zero and refcounts are not added when mapping the page.
> > 
> > > Tracking this requires special PTE bits (PTE_DEVMAP) and a secondary
> > > mechanism for allowing GUP to hold references on the page (see
> > > get_dev_pagemap). However there doesn't seem to be any reason why FS
> > > DAX pages need their own reference counting scheme.
> > 
> > This is fair. However, for anyone coming in fresh to this situation
> > maybe some more "how we get here" history helps. That longer story is
> > here:
> > 
> > http://lore.kernel.org/all/166579181584.2236710.17813547487183983273.stgit@dwillia2-xfh.jf.intel.com/
> 
> This never got merged? :(

Yeah... I got hung up on the "allocation" API to take ZONE_DEVICE pages
from recfount 0 to 1 and then never circled back.