Received-SPF: pass (google.com: domain of linux-ext4+bounces-2048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <68427031c58645ba4b751022bf032ffd6b247427.1712796818.git-series.apopple@nvidia.com>
 <ce3ea542-9b68-4630-b437-c9daddad2e83@redhat.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Alistair Popple <apopple@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com,
 jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org,
 jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz,
 djwong@kernel.org, hch@lst.de, ruansy.fnst@fujitsu.com,
 nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, jglisse@redhat.com
Subject: Re: [RFC 09/10] mm/khugepage.c: Warn if trying to scan devmap pmd
Date: Fri, 12 Apr 2024 11:34:11 +1000
In-reply-to: <ce3ea542-9b68-4630-b437-c9daddad2e83@redhat.com>
Message-ID: <87sezr5pm3.fsf@nvdebian.thelocal>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?btcZdRBcRAIiSR6KDm0qqTdTqc5g66Rv6iVm0hrRvzwXo5Wfxi6cV7/vdUnC?=
 =?us-ascii?Q?AmdnH0ljHN0ipmS9uNz3Iv6LhMYLUQWKqM5+ty0GIRYjXjkWT06LVnDmQhe3?=
 =?us-ascii?Q?eSSsfjBsGuckSZysx/+ywrCrYTZzr2bXJHEjZnWE6zAB2LJr8EmXTlo9CPHK?=
 =?us-ascii?Q?pDfjBaqfv2mNf6LW46whwT1oO8nVe/y44mkHPQnWIDUCzC1NbHGYd5aTfrf9?=
 =?us-ascii?Q?5DibneJGy0YKFIkNf8HCstDGnKs/IkTz77Ks4rGKdw0rAOaW95qlhSkLSSwb?=
 =?us-ascii?Q?6zYzfWTUbV2IosB1iduZsOxFWk2/xwq8Gnf/+dX8Kc5U265gnVcpCs/lVWHf?=
 =?us-ascii?Q?sP4ns2u2iO0JhQqpgRiO+W5cMOkPQ4/3/Yru+KYLD+JQy5bReAJpkn923Prg?=
 =?us-ascii?Q?0+41rgZ7K+FVzFQYugmOZJpqcbn63oavY3IFdr1uqVIit7WhudZULSfTdbIG?=
 =?us-ascii?Q?vRhCzUlq6g4She3MmzNGdzOPMnfHHHa/lVw/OugzR3XPpvgCUZuG7gl13n+U?=
 =?us-ascii?Q?iKzsz8KXmNNXWiD80qrBW9UA3WN+YIlzoEICNRDsBVquAo48/VLjwHNi0x/Y?=
 =?us-ascii?Q?M1ORBE1jzv4co/5b1eHfKkyKduqL4A65BF4r7j0xFXoWwkJ0IShbhPu2jxGj?=
 =?us-ascii?Q?cGvX8swti9eqtPL2otVsPUxG+TwDewJ8yWYV/8Xzqvzohn+RfKn1no2y1ZUl?=
 =?us-ascii?Q?SvCLhvoIshDUiogKk8rZVcOLP1E1xH3yG4RzKEjdBO2SZtYO4UE3og/0E2rq?=
 =?us-ascii?Q?5HcnXJanp82zeSZvGa9mtdTiArIoZ2hAA+046hizxqKFs1W1sKGRLowi3NIc?=
 =?us-ascii?Q?vsE8kKaErtsxwluFBkQ+Ckn++9+dSqe2Jv56hrqX69Y2wJnoVGdt12H2aCpb?=
 =?us-ascii?Q?jNFmhMbKakN73P+O+RS9RfarMQ/GvKN0QZ2MvSlBZxLqgh9gg30CGPO7rSOG?=
 =?us-ascii?Q?+QwxCL/FwYFyspzJw2F4iRdKRvw+u7qStIaTSavuJShKGIz4jFRBO+VfJwxX?=
 =?us-ascii?Q?rvSBO+dnqzJFGr+sjxSSTFddnx5B0y2bl28FhvtouscqQJsVtx8koaMrhAFQ?=
 =?us-ascii?Q?Z2mlPklAOO4zCX3gJuTq+RFcRDNwQJM80B7g1TK5+UGXkw2f5Cb/RrWzlpK1?=
 =?us-ascii?Q?pateu7s5pjREq6AmMeSRqFK4yTS2PDfqK6VL7KK4bOQBq0ffo91/lNiRc93k?=
 =?us-ascii?Q?odVlgMCTOEelQVGaDW16ExGZdFbMVEUKkM50FVY22ZDcQnOgjqrs3QX01XBh?=
 =?us-ascii?Q?aInegVPFJWdhYANfuU3vNIDamptA93DLv53bI6Vjvcj5NZDfZLyLASYsR4dX?=
 =?us-ascii?Q?83K3f7c7tRtNbq+x/hv9l31HS0ubYOsJf2OEBUBn1UzUAJoOkDtEiDJT9c80?=
 =?us-ascii?Q?FGlleGCyCEN1MPKrPUka3U9zQDlBV++q3NC0/UU8cLdJvIQ8YKFqgTa4iWIj?=
 =?us-ascii?Q?DdtGEBGogW/NFTCiyKwuGrfrMoSLb77tZWhUeAvjedYB2J+y45g7Nd8M7yra?=
 =?us-ascii?Q?pImsBqd5I6/bMmePgGB9OjrU7QovSmA870Rne9/dPkk7dJ/z/Fd+dkAdba6T?=
 =?us-ascii?Q?hdAaEYi7UM9x0gCaVlSWBmVaqYp9Ryl24vudyMKJ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8630557b-a176-4b74-034e-08dc5a90f741
X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB7705.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 01:36:25.0811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DxC2j/PJgv4OOlfmR8fn3n+0PT9Y/fYiboYc6QKZhB/HfCosxSLm5+tAaYSNEd0wPTp7etzPZCzFwioq9OhEPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7440


David Hildenbrand <david@redhat.com> writes:

> On 11.04.24 02:57, Alistair Popple wrote:
>> The only user of devmap PTEs is FS DAX, and khugepaged should not be
>> scanning these VMAs. This is checked by calling
>> hugepage_vma_check. Therefore khugepaged should never encounter a
>> devmap PTE. Warn if this occurs.
>> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>> ---
>> Note this is a transitory patch to test the above assumption both at
>> runtime and during review. I will likely remove it as the whole thing
>> gets deleted when pXX_devmap is removed.
>
> Yes, doesn't make sense for this patch to exist if it would go
> upstream along with the next patch that removes that completely.

Yep. I'd had it to sanity check my own understanding and figured I'd
leave it in the RFC series to see if it provoked a reaction from anyone.

Will drop it in the next version.