Received-SPF: pass (google.com: domain of linux-ext4+bounces-2049-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <ffd72e934eeae28639b636e1e61a9c5109808420.1712796818.git-series.apopple@nvidia.com>
 <f3b38a24-d252-49ea-88ea-ac12fab3c121@redhat.com>
User-agent: mu4e 1.10.8; emacs 29.1
From: Alistair Popple <apopple@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com,
 jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org,
 jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz,
 djwong@kernel.org, hch@lst.de, ruansy.fnst@fujitsu.com,
 nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org,
 linux-ext4@vger.kernel.org, jglisse@redhat.com
Subject: Re: [RFC 01/10] mm/gup.c: Remove redundant check for PCI P2PDMA page
Date: Fri, 12 Apr 2024 11:37:00 +1000
In-reply-to: <f3b38a24-d252-49ea-88ea-ac12fab3c121@redhat.com>
Message-ID: <87o7af5pj9.fsf@nvdebian.thelocal>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fsn7AF266uxYvu1qAfJyt9RtMKELXxndqawXyXRW6KT4WH3yJ++syzPx+1Yd?=
 =?us-ascii?Q?QemYKfh6jlr/EJuzESL6PnUeJTl1RN9X2MB5OHjqUum2LYcDhZAwWYtHQVoW?=
 =?us-ascii?Q?AfUyBuvsBJGRVCsKrQdMTorvPj8dwanqyO/l7sxJ2h7j03YSZTUW884cTm8M?=
 =?us-ascii?Q?tVDLgcYDSoe9+j5/OG7YPSTwnvXmfw1Q96ZTGoJZ2PYmcTHYzEdIVRrlvW17?=
 =?us-ascii?Q?7q/gbc6BnMyYlp7n76bgkTonBx7DZs1O/E4B46pDxezd9UFxKepLu5dwv4Kw?=
 =?us-ascii?Q?Hg0qewWigc8IjZU+cqNsWMWWCfKmRy+7u8Gy9bn7j+HeVfCgRvZatkj+tKXO?=
 =?us-ascii?Q?BVwwnyhFZNhQrYREUYfaMFZs76Aj3jiOnpFBlPH5hrQiR80c499K7Se3hVwS?=
 =?us-ascii?Q?zhA/ISxVtv4DIbYbD/dn/P4bygL9NMkXRnQkBB70i0gdfhJrdFffy2i6uVdH?=
 =?us-ascii?Q?qyeY0bKZIP6ehTUaR4/q4ArV0B1I7ricIxCiLg8gF2nGBB1S8NvRdlLQGijg?=
 =?us-ascii?Q?y+G5a9aZD3QVnuG5cdxCZ/LBvjUo0f8nUk1K0gEeA4Ev/++A8+rIEks0to31?=
 =?us-ascii?Q?ux/uHTwDrovSaEAbvpqfgCHD4e+Plc3hYQXyZK/rvLeWUbkCgeDrGXP+7kBm?=
 =?us-ascii?Q?GKZYBw+6m/sLDFeIPbXCf5v8pWL94xWG3hRrxyRitGZlYp5DQXfHz7IN+Ugm?=
 =?us-ascii?Q?f0G8U+lj1abweI6CCrk6fcPcU8/ymZLzwe0wzMorUNCabZYgyUnWBwo3YZTg?=
 =?us-ascii?Q?f49qGd6pgBHIvj2WIPZuc4E96/SKtmfSlEnc0EZkLih087+gSqdvsZ5orabU?=
 =?us-ascii?Q?t5Ox0F1JeQRjgL693MDdGIZYD7pomhDMJI124Wb22i/WWAww3T3xwK1uD1y9?=
 =?us-ascii?Q?kz3b8qNGnQ/HtQJq1LqUUxFmODrnWT6bPV0o6fQARjTMILq6yxT5d3eMEri6?=
 =?us-ascii?Q?SUqYlmXN1O2MGko5XbqBZHO0Pgqq3wnsuk1K54qsIADPpm5k9V+bIz1TW0Gk?=
 =?us-ascii?Q?hQgPZabe810BQ5xSB7rmKYfylcF76OkUuu5qzfnXvku//sg9OAXIYwOxvbiT?=
 =?us-ascii?Q?KX0DUkcW4LKcebS7D3kCGN7+AFCfQ34mt5EYJ4lmSqdXvOgavASqa1rWSdh1?=
 =?us-ascii?Q?enVjHkgeh52QAiYBJgoOaSp9dQm6CBaI8UoDKwSioxIkTphX2bBnJ8zDCc2a?=
 =?us-ascii?Q?Kncy1aEubB4uhK8wO82qzCjQUBSmG9V+GxFN4ABK1HIZXiRoZf7zCqSQYfGn?=
 =?us-ascii?Q?7pgRgiIk9lKivPGdLoeM2apJQb3n44AArOulWcXXVHgjzIsf8+Ibdel6dC8J?=
 =?us-ascii?Q?PZoQOb7NmC3AnAFUAmtlO+fo2w96eCH6VQnJ89ljLvcebA3A3l8Cm2aRyhnS?=
 =?us-ascii?Q?Cy2EEy8sBRfACKVNT/+7j3kv/58gW7Sh0dlo3THVFBJZJFWclNAj2mqEUsMC?=
 =?us-ascii?Q?CzE4UbKviIxVaP942/OZSFumBmBqY4t/pOajmlxwdcN1Qx/XZtz3pgSOdXbi?=
 =?us-ascii?Q?KIUKZeFmZC6ljVsd5onaA2uoViwfgpR4D12Jw3QaN96913xWynGtOf4zFKKw?=
 =?us-ascii?Q?KRlIhVkYYB69Oa662Xki3/S9aCEFSFAJUF+mKpY0?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be276bb0-b080-4d97-d11a-08dc5a913393
X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB7705.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 01:38:06.2831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +dJkgw/QD/bMhPkoTLDnV+Q8EJwpwjM7/5NJp7GqrPGuVbRVmjaFL4wqPxBaONhUYuXlnOaYHpzezaaPug/EUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6540


David Hildenbrand <david@redhat.com> writes:

> On 11.04.24 02:57, Alistair Popple wrote:
>> PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the
>> check in __gup_device_huge() is redundant. Remove it
>> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>> ---
>>   mm/gup.c | 5 -----
>>   1 file changed, 5 deletions(-)
>> diff --git a/mm/gup.c b/mm/gup.c
>> index 2f8a2d8..a9c8a09 100644
>> --- a/mm/gup.c
>> +++ b/mm/gup.c
>> @@ -2683,11 +2683,6 @@ static int __gup_device_huge(unsigned long pfn, unsigned long addr,
>>   			break;
>>   		}
>>   -		if (!(flags & FOLL_PCI_P2PDMA) &&
>> is_pci_p2pdma_page(page)) {
>> -			undo_dev_pagemap(nr, nr_start, flags, pages);
>> -			break;
>> -		}
>> -
>>   		SetPageReferenced(page);
>>   		pages[*nr] = page;
>>   		if (unlikely(try_grab_page(page, flags))) {
>
> Rebasing on mm-unstable, you'll notice some minor conflicts, but
> nothing earth shattering :)

Thanks. Rebasing was the other thing I meant to add as a TODO in the
cover letter :)

> Acked-by: David Hildenbrand <david@redhat.com>