Received-SPF: pass (google.com: domain of linux-ext4+bounces-2067-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 12 Apr 2024 10:20:07 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Alistair Popple <apopple@nvidia.com>, <linux-mm@kvack.org>
CC: <david@fromorbit.com>, <dan.j.williams@intel.com>, <jhubbard@nvidia.com>,
	<rcampbell@nvidia.com>, <willy@infradead.org>, <jgg@nvidia.com>,
	<linux-fsdevel@vger.kernel.org>, <jack@suse.cz>, <djwong@kernel.org>,
	<hch@lst.de>, <david@redhat.com>, <ruansy.fnst@fujitsu.com>,
	<nvdimm@lists.linux.dev>, <linux-xfs@vger.kernel.org>,
	<linux-ext4@vger.kernel.org>, <jglisse@redhat.com>, Alistair Popple
	<apopple@nvidia.com>
Subject: RE: [RFC 03/10] pci/p2pdma: Don't initialise page refcount to one
Message-ID: <66196d4726670_36222e2942a@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.fe275e9819458a4bbb9451b888cafb88af8867d4.1712796818.git-series.apopple@nvidia.com>
 <a443974e64917824e078485d4e755ef04c89d73f.1712796818.git-series.apopple@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <a443974e64917824e078485d4e755ef04c89d73f.1712796818.git-series.apopple@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K8ylK3EdEEcjkDoWQq3nN/lzP0+Vk61mFO7AOAuovdmddVVJRdMKnbG0bUfX?=
 =?us-ascii?Q?Drz39rYP3UnQ5EU0qg51o/CfoYjv+QUBH+Ti7cmO/4zjc1u5U25FUW3RMb8/?=
 =?us-ascii?Q?WBuO9yjICzXlxzqAL13w2WSflV7MOy/fmENyHpDtVmwHTxOQpZUmENZkqNJw?=
 =?us-ascii?Q?sMxDmHOHIU05mFkWi4mDus70XhXuuJf4JaygCjc1qcvQyFOKhZuXH4Nx4euI?=
 =?us-ascii?Q?l6p2uBmGenDNV9DJDVAsfKwY1atX/t8Mr2cX7AO/NeKPZncMCDIaB5pI4J76?=
 =?us-ascii?Q?xlycbB/C4BN6X7bVnvqprnMtzmNHoXt6g9SLFELBJnX2s25pXMxao/wdyVe9?=
 =?us-ascii?Q?o6Rp2aczqZoY0+d26R6Vnlo0f0JjkOcDpd1EN48tTfRdKt5udHUyuoovBqyA?=
 =?us-ascii?Q?nN5CQL2Zr65NBCihtafQ7W+UHcxsw3lf2QCcvRAwLDnkHemLo67HuBk7tVRH?=
 =?us-ascii?Q?4V25S9amGJ+gp7j5O/A0Cs648w2KTKV3jHD/yxKOZBHSRBRplMwWnaF0BPWL?=
 =?us-ascii?Q?rtt5hHfPyGz3bWqowdkU2djmbugi3wr664+a8tX24GtNwzF9vzrg+KmQpX6N?=
 =?us-ascii?Q?KfU5SFTZ70YmIHA8LDfgCHxDi5DMaq8DCO7cXDeT1HwwqS0/n18wKu9nGMPc?=
 =?us-ascii?Q?00P0r/+vIH9DiQe+IrV55fk26G8OvyC8/g8H3Fp4V0ONemLBiaqtR7/m1MK2?=
 =?us-ascii?Q?EZruR+9dP3NaYM70aiyLgRvau74g9e4K7a3o9hVxx8ZEASHve1GB/rXeSvfa?=
 =?us-ascii?Q?8zzJ9jORBgtxI1wZ4mgRXcInG5wdES2YYWDlB3pkx54YcTYoTIhVjo8CdFpB?=
 =?us-ascii?Q?Jp2KnsvRfn2OZrm6cu871kXK/BiZ8OrsKFFTyN9hMciZTr6zjxSKMMIvZsRF?=
 =?us-ascii?Q?ZNZh/BoY9bYDfBL+xugAUXAp1w5nt6XuquEgGCeUHFuAQZCmT3PUqdUbUEaO?=
 =?us-ascii?Q?+3r6xfaDBCZ7GCA1pd5cDp5y8aIatzGAp5JWsBNFAQg5RjjFuu+fJGEB8d0b?=
 =?us-ascii?Q?v9WSDNFNmBwoCMriO7OapE5ebwj7c20BaURpHnivaToJDwLYAcm9A/zO6Bbl?=
 =?us-ascii?Q?ieFb6It1jZxWNbbR+E/w2DrYAw/isZIRzW+C/5TYuPmOnZ2WBrqFDkIHVGlU?=
 =?us-ascii?Q?zeAMeW2kTWLRQkxxjN3ZTfM1/WFDpnBpOGu24Ok3QgLJ40Ufht32M+UzZ38L?=
 =?us-ascii?Q?KjpnT6UyZExQbbUcu5H550bFARBBa4Ki6BEu6joX2iT22IM0zCzdb8pvl7Rf?=
 =?us-ascii?Q?RO06trKWaaJgeyTrCsMn1+97fKQweD6utpM4p0yxXVHwmc4fA/FPn7LryFkU?=
 =?us-ascii?Q?4Gl07hWm0ZsAu8N+c2Pc0rM2B9SpQd93jhNNRYIHjmiOox6kQUZrJWTSCRoi?=
 =?us-ascii?Q?4iEMIqM5atyhPB52YFgVzqcUpHtyIjbevk0TTKR1VBve4hoxrKCt44we9/pk?=
 =?us-ascii?Q?Bk6G0vE1KQX5kCmFhTgFapmoyrfUFd51zxhT/bHyMCIpcbs5G8gwjGbW6hck?=
 =?us-ascii?Q?P8+Ga33jec3lDk3aVch3YGMsBWxFRtG94cLepqICWruJqzyjoj0SylsCWKuV?=
 =?us-ascii?Q?WjfLcZ/UONpy9+FR2IdPehvDNzM9mpp9egox3iROP5QjafzJq1PvtQ0J0xb+?=
 =?us-ascii?Q?qQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f41ee61-081a-4b5e-55a2-08dc5b14ce7e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 17:20:10.3751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a+x87c+ZMwfe8DqOGhoaQAIIxf9vlKj400pn0zPfMcpKOR0sZUI0f8mzPmW19SuEePEaon+33QIxUX0lGRvTEpA5pGBVXKh62e+svuipF/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7562
X-OriginatorOrg: intel.com

Alistair Popple wrote:
> The reference counts for ZONE_DEVICE private pages should be
> initialised by the driver when the page is actually allocated by the
> driver allocator, not when they are first created. This is currently
> the case for MEMORY_DEVICE_PRIVATE and MEMORY_DEVICE_COHERENT pages
> but not MEMORY_DEVICE_PCI_P2PDMA pages so fix that up.

I know you said to hold off on looking at this series until you fixed up
the kernel assertions, but I would not expect to remove logic before the
replacement is available. So this seems to be in the wrong place in the
series, or am I missing something?